From: Dan Murphy <dmurphy@ti.com> To: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, tony@atomide.com, lee.jones@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com> Subject: [PATCH v4 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Date: Wed, 13 Mar 2019 07:32:47 -0500 [thread overview] Message-ID: <20190313123249.17258-2-dmurphy@ti.com> (raw) In-Reply-To: <20190313123249.17258-1-dmurphy@ti.com> Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- v4 - No change - https://lore.kernel.org/patchwork/patch/1050125/ v3 - updated keypad label on v1 comment - https://lore.kernel.org/patchwork/patch/1049023/ v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values, I did not change the label as it is undecided what it could be - https://lore.kernel.org/patchwork/patch/1048806/ arch/arm/boot/dts/omap4-droid4-xt894.dts | 26 ++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts index e21ec929f096..aea206f04f76 100644 --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts @@ -383,20 +383,30 @@ }; &i2c1 { - lm3532@38 { + led-controller@38 { compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; reg = <0x38>; enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; - lcd_backlight: backlight { - compatible = "ti,lm3532-backlight"; + ramp-up-us = <1024>; + ramp-down-us = <8193>; - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <1>; - ramp-down-msec = <0>; - }; + lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <0>; + label = "backlight"; + linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight"; }; }; }; -- 2.20.1.390.gb5101f9297
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <tony@atomide.com>, <lee.jones@linaro.org> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org>, Dan Murphy <dmurphy@ti.com> Subject: [PATCH v4 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Date: Wed, 13 Mar 2019 07:32:47 -0500 [thread overview] Message-ID: <20190313123249.17258-2-dmurphy@ti.com> (raw) In-Reply-To: <20190313123249.17258-1-dmurphy@ti.com> Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- v4 - No change - https://lore.kernel.org/patchwork/patch/1050125/ v3 - updated keypad label on v1 comment - https://lore.kernel.org/patchwork/patch/1049023/ v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values, I did not change the label as it is undecided what it could be - https://lore.kernel.org/patchwork/patch/1048806/ arch/arm/boot/dts/omap4-droid4-xt894.dts | 26 ++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts index e21ec929f096..aea206f04f76 100644 --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts @@ -383,20 +383,30 @@ }; &i2c1 { - lm3532@38 { + led-controller@38 { compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; reg = <0x38>; enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; - lcd_backlight: backlight { - compatible = "ti,lm3532-backlight"; + ramp-up-us = <1024>; + ramp-down-us = <8193>; - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <1>; - ramp-down-msec = <0>; - }; + lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <0>; + label = "backlight"; + linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight"; }; }; }; -- 2.20.1.390.gb5101f9297
next prev parent reply other threads:[~2019-03-13 12:32 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-13 12:32 [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy 2019-03-13 12:32 ` Dan Murphy 2019-03-13 12:32 ` Dan Murphy [this message] 2019-03-13 12:32 ` [PATCH v4 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy 2019-03-13 12:32 ` [PATCH v4 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy 2019-03-13 12:32 ` Dan Murphy 2019-03-13 12:32 ` [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy 2019-03-13 12:32 ` Dan Murphy 2019-03-20 12:39 ` Dan Murphy 2019-03-20 12:39 ` Dan Murphy 2019-03-20 19:00 ` Jacek Anaszewski 2019-03-20 19:05 ` Dan Murphy 2019-03-20 19:05 ` Dan Murphy 2019-03-20 18:59 ` Jacek Anaszewski 2019-03-20 19:04 ` Dan Murphy 2019-03-20 19:04 ` Dan Murphy 2019-03-21 8:21 ` Lee Jones 2019-03-21 8:20 ` Lee Jones 2019-03-14 9:39 ` [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Pavel Machek 2019-03-14 12:52 ` Dan Murphy 2019-03-14 12:52 ` Dan Murphy 2019-03-15 23:35 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190313123249.17258-2-dmurphy@ti.com \ --to=dmurphy@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=jacek.anaszewski@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.