i386 emu build is broken

i386 emu build is broken

[Daniel Kiper]

Hey,

I am trying to fix various build hiccups before the release.
During that I found the following issue in i386 emu build.
It is configured in the following way:
  ./configure --target=i386 --with-platform=emu --enable-grub-mkfont --prefix=...

Then during build I see this:

  In file included from lib/gnulib/regex.c:71:0:
  lib/gnulib/regcomp.c: In function ‘parse_dup_op’:
  lib/gnulib/regcomp.c:2637:41: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
         postorder (elem, mark_opt_subexp, (void *) subidx);
                                           ^
  lib/gnulib/regcomp.c: In function ‘mark_opt_subexp’:
  lib/gnulib/regcomp.c:3859:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
     Idx idx = (uintptr_t) extra;
               ^
  cc1: all warnings being treated as errors

I do build on Debian 9 (stretch).

How should we fix it? In our Gnulib copy or in original Gnulib?
Latter sounds better but I am not sure it is quickly feasible.
Thoughts?

Daniel

Re: i386 emu build is broken

[Alex Burmashev]

Hi!

Strange, i thought it was fixed long ago:

https://github.com/coreutils/gnulib/commit/3a4836d1fa061adf7b2f96fbda9c2345e6210732

19-Mar-19 12:04 PM, Daniel Kiper пишет:
> Hey,
>
> I am trying to fix various build hiccups before the release.
> During that I found the following issue in i386 emu build.
> It is configured in the following way:
>    ./configure --target=i386 --with-platform=emu --enable-grub-mkfont --prefix=...
>
> Then during build I see this:
>
>    In file included from lib/gnulib/regex.c:71:0:
>    lib/gnulib/regcomp.c: In function ‘parse_dup_op’:
>    lib/gnulib/regcomp.c:2637:41: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>           postorder (elem, mark_opt_subexp, (void *) subidx);
>                                             ^
>    lib/gnulib/regcomp.c: In function ‘mark_opt_subexp’:
>    lib/gnulib/regcomp.c:3859:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>       Idx idx = (uintptr_t) extra;
>                 ^
>    cc1: all warnings being treated as errors
>
> I do build on Debian 9 (stretch).
>
> How should we fix it? In our Gnulib copy or in original Gnulib?
> Latter sounds better but I am not sure it is quickly feasible.
> Thoughts?
>
> Daniel

Re: i386 emu build is broken

[Daniel Kiper]

On Tue, Mar 19, 2019 at 12:04:11PM +0100, Daniel Kiper wrote:
> Hey,
>
> I am trying to fix various build hiccups before the release.
> During that I found the following issue in i386 emu build.
> It is configured in the following way:
>   ./configure --target=i386 --with-platform=emu --enable-grub-mkfont --prefix=...
>
> Then during build I see this:
>
>   In file included from lib/gnulib/regex.c:71:0:
>   lib/gnulib/regcomp.c: In function ‘parse_dup_op’:
>   lib/gnulib/regcomp.c:2637:41: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>          postorder (elem, mark_opt_subexp, (void *) subidx);
>                                            ^
>   lib/gnulib/regcomp.c: In function ‘mark_opt_subexp’:
>   lib/gnulib/regcomp.c:3859:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>      Idx idx = (uintptr_t) extra;
>                ^
>   cc1: all warnings being treated as errors
>
> I do build on Debian 9 (stretch).
>
> How should we fix it? In our Gnulib copy or in original Gnulib?
> Latter sounds better but I am not sure it is quickly feasible.
> Thoughts?

The same issue happens when I build riscv32-linux target:
  ./configure --target=riscv32-linux --with-platform=efi --enable-grub-mkfont --prefix=...

I use compiler from here:
  http://mirrors.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-riscv32-linux.tar.xz

Hmmm... Last week it built correctly. Do we use latest Gnulib from master?
Should not we use specific tag/commit which works for us?

Daniel

Re: i386 emu build is broken

[Colin Watson]

On Tue, Mar 19, 2019 at 12:27:20PM +0100, Daniel Kiper wrote:
> Hmmm... Last week it built correctly. Do we use latest Gnulib from master?
> Should not we use specific tag/commit which works for us?

We already pin a particular commit.  See GNULIB_REVISION in
bootstrap.conf.  docs/grub-dev.texi explains what to do when you need to
upgrade that.

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

Re: i386 emu build is broken

[Daniel Kiper]

On Tue, Mar 19, 2019 at 11:49:05AM +0000, Colin Watson wrote:
> On Tue, Mar 19, 2019 at 12:27:20PM +0100, Daniel Kiper wrote:
> > Hmmm... Last week it built correctly. Do we use latest Gnulib from master?
> > Should not we use specific tag/commit which works for us?
>
> We already pin a particular commit.  See GNULIB_REVISION in
> bootstrap.conf.  docs/grub-dev.texi explains what to do when you need to
> upgrade that.

Ahhh... Right, I forgot about it. Sorry. But then why builds sometimes
work and sometimes do not? Anyway, could you try to investigate the
i386/riscv32 build issues? And this one reported by Chen. I will try to
take a look at this intermittent build issues. If I am able to reproduce
them.

Daniel

Re: i386 emu build is broken

[Daniel Kiper]

On Tue, Mar 19, 2019 at 12:04:11PM +0100, Daniel Kiper wrote:
> Hey,
>
> I am trying to fix various build hiccups before the release.
> During that I found the following issue in i386 emu build.
> It is configured in the following way:
>   ./configure --target=i386 --with-platform=emu --enable-grub-mkfont --prefix=...
>
> Then during build I see this:
>
>   In file included from lib/gnulib/regex.c:71:0:
>   lib/gnulib/regcomp.c: In function ‘parse_dup_op’:
>   lib/gnulib/regcomp.c:2637:41: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>          postorder (elem, mark_opt_subexp, (void *) subidx);
>                                            ^
>   lib/gnulib/regcomp.c: In function ‘mark_opt_subexp’:
>   lib/gnulib/regcomp.c:3859:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>      Idx idx = (uintptr_t) extra;
>                ^
>   cc1: all warnings being treated as errors

False alarm. i386 emu on an x86_64 Linux should be configured in the following way:

  ./configure CFLAGS=-m32 --host=i386 --target=i386 --with-platform=emu --prefix=...

If you want build emu platform for other CPUs then --host has to be equal --target.

Sorry for the noise.

Daniel