[PATCH] Staging: rtl8723bs: Remove typedef in struct _Dynamic_Primary_CCA

[PATCH] Staging: rtl8723bs: Remove typedef in struct _Dynamic_Primary_CCA

[Madhumitha Prabakaran]

Remove typedef in struct _Dynamic_Primary_CCA, as a struct that has
elements that can reasonably be directly accessed should never be a
typedef.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 23ab160ac2c8..af68658233e3 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -82,7 +82,7 @@
 
 /* Remove DIG by yuchen */
 
-typedef struct _Dynamic_Primary_CCA {
+struct _Dynamic_Primary_CCA {
 	u8 PriCCA_flag;
 	u8 intf_flag;
 	u8 intf_type;
@@ -90,7 +90,7 @@ typedef struct _Dynamic_Primary_CCA {
 	u8 Monitor_flag;
 	u8 CH_offset;
 	u8 	MF_state;
-} Pri_CCA_T, *pPri_CCA_T;
+};
 
 typedef struct _Rate_Adaptive_Table_ {
 	u8 firstconnect;
@@ -1112,7 +1112,7 @@ typedef  struct DM_Out_Source_Dynamic_Mechanism_Structure {
 	FAT_T DM_FatTable;
 	DIG_T DM_DigTable;
 	PS_T DM_PSTable;
-	Pri_CCA_T DM_PriCCA;
+	struct _Dynamic_Primary_CCA DM_PriCCA;
 	RXHP_T DM_RXHP_Table;
 	RA_T DM_RA_Table;
 	false_ALARM_STATISTICS FalseAlmCnt;
-- 
2.17.1

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct _Dynamic_Primary_CCA

[Greg KH]

On Mon, Apr 01, 2019 at 05:18:54PM -0500, Madhumitha Prabakaran wrote:
> Remove typedef in struct _Dynamic_Primary_CCA, as a struct that has
> elements that can reasonably be directly accessed should never be a
> typedef.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
> index 23ab160ac2c8..af68658233e3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -82,7 +82,7 @@
>  
>  /* Remove DIG by yuchen */
>  
> -typedef struct _Dynamic_Primary_CCA {
> +struct _Dynamic_Primary_CCA {

While this is a good thing, can you also name this to be a sane name at
the same time?  No need to have to write two patches for this.

thanks,

greg k-h