All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 11:50 ` Wei Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2019-04-08 11:50 UTC (permalink / raw)
  To: xen-devel; +Cc: Doug Goldstein, Wei Liu

The build script invoked is designed to run in a pristine checkout.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 automation/gitlab-ci/build-each-commit.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
index 275bc71902..879028b5a7 100755
--- a/automation/gitlab-ci/build-each-commit.sh
+++ b/automation/gitlab-ci/build-each-commit.sh
@@ -15,4 +15,4 @@ fi
 echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
 
 NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
-    bash -c "make -j4 distclean && ./automation/scripts/build"
+    bash -c "git clean -ffdx && ./automation/scripts/build"
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Xen-devel] [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 11:50 ` Wei Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2019-04-08 11:50 UTC (permalink / raw)
  To: xen-devel; +Cc: Doug Goldstein, Wei Liu

The build script invoked is designed to run in a pristine checkout.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 automation/gitlab-ci/build-each-commit.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
index 275bc71902..879028b5a7 100755
--- a/automation/gitlab-ci/build-each-commit.sh
+++ b/automation/gitlab-ci/build-each-commit.sh
@@ -15,4 +15,4 @@ fi
 echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
 
 NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
-    bash -c "make -j4 distclean && ./automation/scripts/build"
+    bash -c "git clean -ffdx && ./automation/scripts/build"
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:24   ` Doug Goldstein
  0 siblings, 0 replies; 10+ messages in thread
From: Doug Goldstein @ 2019-04-08 12:24 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel


> On Apr 8, 2019, at 6:50 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> The build script invoked is designed to run in a pristine checkout.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Xen-devel] [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:24   ` Doug Goldstein
  0 siblings, 0 replies; 10+ messages in thread
From: Doug Goldstein @ 2019-04-08 12:24 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel


> On Apr 8, 2019, at 6:50 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> The build script invoked is designed to run in a pristine checkout.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:43   ` Anthony PERARD
  0 siblings, 0 replies; 10+ messages in thread
From: Anthony PERARD @ 2019-04-08 12:43 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel, Doug Goldstein

On Mon, Apr 08, 2019 at 12:50:31PM +0100, Wei Liu wrote:
> The build script invoked is designed to run in a pristine checkout.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  automation/gitlab-ci/build-each-commit.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
> index 275bc71902..879028b5a7 100755
> --- a/automation/gitlab-ci/build-each-commit.sh
> +++ b/automation/gitlab-ci/build-each-commit.sh
> @@ -15,4 +15,4 @@ fi
>  echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
>  
>  NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
> -    bash -c "make -j4 distclean && ./automation/scripts/build"
> +    bash -c "git clean -ffdx && ./automation/scripts/build"

Is this mean that QEMU, OVMF, SeaBIOS, ... are going to be clonned again
and again? But maybe it doesn't matter.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Xen-devel] [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:43   ` Anthony PERARD
  0 siblings, 0 replies; 10+ messages in thread
From: Anthony PERARD @ 2019-04-08 12:43 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel, Doug Goldstein

On Mon, Apr 08, 2019 at 12:50:31PM +0100, Wei Liu wrote:
> The build script invoked is designed to run in a pristine checkout.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  automation/gitlab-ci/build-each-commit.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
> index 275bc71902..879028b5a7 100755
> --- a/automation/gitlab-ci/build-each-commit.sh
> +++ b/automation/gitlab-ci/build-each-commit.sh
> @@ -15,4 +15,4 @@ fi
>  echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
>  
>  NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
> -    bash -c "make -j4 distclean && ./automation/scripts/build"
> +    bash -c "git clean -ffdx && ./automation/scripts/build"

Is this mean that QEMU, OVMF, SeaBIOS, ... are going to be clonned again
and again? But maybe it doesn't matter.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:45     ` Wei Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2019-04-08 12:45 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel, Wei Liu, Doug Goldstein

On Mon, Apr 08, 2019 at 01:43:57PM +0100, Anthony PERARD wrote:
> On Mon, Apr 08, 2019 at 12:50:31PM +0100, Wei Liu wrote:
> > The build script invoked is designed to run in a pristine checkout.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  automation/gitlab-ci/build-each-commit.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
> > index 275bc71902..879028b5a7 100755
> > --- a/automation/gitlab-ci/build-each-commit.sh
> > +++ b/automation/gitlab-ci/build-each-commit.sh
> > @@ -15,4 +15,4 @@ fi
> >  echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
> >  
> >  NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
> > -    bash -c "make -j4 distclean && ./automation/scripts/build"
> > +    bash -c "git clean -ffdx && ./automation/scripts/build"
> 
> Is this mean that QEMU, OVMF, SeaBIOS, ... are going to be clonned again
> and again? But maybe it doesn't matter.

Yes. But I don't think that matters much.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Xen-devel] [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:45     ` Wei Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2019-04-08 12:45 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel, Wei Liu, Doug Goldstein

On Mon, Apr 08, 2019 at 01:43:57PM +0100, Anthony PERARD wrote:
> On Mon, Apr 08, 2019 at 12:50:31PM +0100, Wei Liu wrote:
> > The build script invoked is designed to run in a pristine checkout.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  automation/gitlab-ci/build-each-commit.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
> > index 275bc71902..879028b5a7 100755
> > --- a/automation/gitlab-ci/build-each-commit.sh
> > +++ b/automation/gitlab-ci/build-each-commit.sh
> > @@ -15,4 +15,4 @@ fi
> >  echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
> >  
> >  NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
> > -    bash -c "make -j4 distclean && ./automation/scripts/build"
> > +    bash -c "git clean -ffdx && ./automation/scripts/build"
> 
> Is this mean that QEMU, OVMF, SeaBIOS, ... are going to be clonned again
> and again? But maybe it doesn't matter.

Yes. But I don't think that matters much.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:48       ` Wei Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2019-04-08 12:48 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel, Wei Liu, Doug Goldstein

On Mon, Apr 08, 2019 at 01:45:15PM +0100, Wei Liu wrote:
> On Mon, Apr 08, 2019 at 01:43:57PM +0100, Anthony PERARD wrote:
> > On Mon, Apr 08, 2019 at 12:50:31PM +0100, Wei Liu wrote:
> > > The build script invoked is designed to run in a pristine checkout.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > ---
> > >  automation/gitlab-ci/build-each-commit.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
> > > index 275bc71902..879028b5a7 100755
> > > --- a/automation/gitlab-ci/build-each-commit.sh
> > > +++ b/automation/gitlab-ci/build-each-commit.sh
> > > @@ -15,4 +15,4 @@ fi
> > >  echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
> > >  
> > >  NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
> > > -    bash -c "make -j4 distclean && ./automation/scripts/build"
> > > +    bash -c "git clean -ffdx && ./automation/scripts/build"
> > 
> > Is this mean that QEMU, OVMF, SeaBIOS, ... are going to be clonned again
> > and again? But maybe it doesn't matter.
> 
> Yes. But I don't think that matters much.

BTW, distclean deletes those repositories as well. The nature of this
specific test means it is best to start in a pristine environment,
because we could potentially move the HEAD of all those repositories.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Xen-devel] [PATCH] gitlab-ci: use git clean -ffdx in build each commit test
@ 2019-04-08 12:48       ` Wei Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2019-04-08 12:48 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel, Wei Liu, Doug Goldstein

On Mon, Apr 08, 2019 at 01:45:15PM +0100, Wei Liu wrote:
> On Mon, Apr 08, 2019 at 01:43:57PM +0100, Anthony PERARD wrote:
> > On Mon, Apr 08, 2019 at 12:50:31PM +0100, Wei Liu wrote:
> > > The build script invoked is designed to run in a pristine checkout.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > ---
> > >  automation/gitlab-ci/build-each-commit.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/automation/gitlab-ci/build-each-commit.sh b/automation/gitlab-ci/build-each-commit.sh
> > > index 275bc71902..879028b5a7 100755
> > > --- a/automation/gitlab-ci/build-each-commit.sh
> > > +++ b/automation/gitlab-ci/build-each-commit.sh
> > > @@ -15,4 +15,4 @@ fi
> > >  echo "Building ${CI_COMMIT_BEFORE_SHA}..${CI_COMMIT_SHA}"
> > >  
> > >  NON_SYMBOLIC_REF=1 ./automation/scripts/build-test.sh ${CI_COMMIT_BEFORE_SHA} ${CI_COMMIT_SHA} \
> > > -    bash -c "make -j4 distclean && ./automation/scripts/build"
> > > +    bash -c "git clean -ffdx && ./automation/scripts/build"
> > 
> > Is this mean that QEMU, OVMF, SeaBIOS, ... are going to be clonned again
> > and again? But maybe it doesn't matter.
> 
> Yes. But I don't think that matters much.

BTW, distclean deletes those repositories as well. The nature of this
specific test means it is best to start in a pristine environment,
because we could potentially move the HEAD of all those repositories.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-04-08 12:48 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 11:50 [PATCH] gitlab-ci: use git clean -ffdx in build each commit test Wei Liu
2019-04-08 11:50 ` [Xen-devel] " Wei Liu
2019-04-08 12:24 ` Doug Goldstein
2019-04-08 12:24   ` [Xen-devel] " Doug Goldstein
2019-04-08 12:43 ` Anthony PERARD
2019-04-08 12:43   ` [Xen-devel] " Anthony PERARD
2019-04-08 12:45   ` Wei Liu
2019-04-08 12:45     ` [Xen-devel] " Wei Liu
2019-04-08 12:48     ` Wei Liu
2019-04-08 12:48       ` [Xen-devel] " Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.