[ath6kl:ath11k-bringup 92/93] drivers/net/wireless/ath/ath11k/dp_rx.c:991:29: warning: logical not is only applied to the left hand side of comparison

[ath6kl:ath11k-bringup 92/93] drivers/net/wireless/ath/ath11k/dp_rx.c:991:29: warning: logical not is only applied to the left hand side of comparison

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3750 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: b186001339ca6058afd49d7611647bd766dd555e [92/93] ath11k: add pktlog rxbuf support
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout b186001339ca6058afd49d7611647bd766dd555e
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/ath11k/core.h:17:0,
                    from drivers/net/wireless/ath/ath11k/dp_rx.c:6:
   drivers/net/wireless/ath/ath11k/dp.h: In function 'dp_peer_map_get_mac_addr':
   drivers/net/wireless/ath/ath11k/dp.h:1262:13: error: implicit declaration of function 'swap32'; did you mean 'swab32'? [-Werror=implicit-function-declaration]
     addr_l32 = swap32(addr_l32);
                ^~~~~~
                swab32
   drivers/net/wireless/ath/ath11k/dp.h:1263:13: error: implicit declaration of function 'swap16'; did you mean 'swab16'? [-Werror=implicit-function-declaration]
     addr_h16 = swap16(addr_h16);
                ^~~~~~
                swab16
   drivers/net/wireless/ath/ath11k/dp_rx.c: In function 'ath11k_htt_pull_ppdu_stats':
>> drivers/net/wireless/ath/ath11k/dp_rx.c:991:29: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     if (!ar->debug.pktlog_mode == ATH11K_PKTLOG_MODE_LITE) {
                                ^~
   drivers/net/wireless/ath/ath11k/dp_rx.c:991:6: note: add parentheses around left hand side expression to silence this warning
     if (!ar->debug.pktlog_mode == ATH11K_PKTLOG_MODE_LITE) {
         ^~~~~~~~~~~~~~~~~~~~~~
         (                     )
   drivers/net/wireless/ath/ath11k/dp_rx.c: In function 'ath11k_dp_rx_process_mon_status':
   drivers/net/wireless/ath/ath11k/dp_rx.c:2278:17: error: 'struct ath11k_debug' has no member named 'pktlog_peer_valid'
      if (!ar->debug.pktlog_peer_valid) {
                    ^
   cc1: some warnings being treated as errors

vim +991 drivers/net/wireless/ath/ath11k/dp_rx.c

   975	
   976	static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab,
   977						 struct sk_buff *skb) {
   978		u8 *data = (u8 *)skb->data;
   979		struct htt_ppdu_stats_info *ppdu_info;
   980		struct ath11k *ar;
   981		int ret;
   982		u8 pdev_id;
   983		u32 ppdu_id, len;
   984	
   985		len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data);
   986		pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data);
   987		pdev_id = DP_HW2SW_MACID(pdev_id);
   988		ppdu_id = *((u32 *)data + 1);
   989		ar = ab->pdevs[pdev_id].ar;
   990	
 > 991		if (!ar->debug.pktlog_mode == ATH11K_PKTLOG_MODE_LITE) {
   992			/* TODO update the pktlog tracing */
   993		}
   994	
   995		/* TLV info starts after 16bytes of header */
   996		data = (u8 *)data + 16;
   997	
   998		ppdu_info = ath11k_dp_htt_get_ppdu_desc(ar, ppdu_id);
   999		if (!ppdu_info)
  1000			return 0;
  1001	
  1002		ppdu_info->ppdu_id = ppdu_id;
  1003		ret = ath11k_dp_htt_tlv_iter(ab, data, len,
  1004					     ath11k_htt_tlv_ppdu_stats_parse,
  1005					     (void *)ppdu_info);
  1006		if (ret) {
  1007			ath11k_warn(ab, "Failed to parse tlv %d\n", ret);
  1008			return ret;
  1009		}
  1010	
  1011		return 0;
  1012	}
  1013	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55530 bytes --]

[-- Attachment #3: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k