* [Buildroot] [PATCH 1/1] package/lynx: fix build with latomic
@ 2019-04-22 10:48 Fabrice Fontaine
2019-04-22 20:24 ` Thomas Petazzoni
2019-04-26 12:46 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-04-22 10:48 UTC (permalink / raw)
To: buildroot
Help lynx finding openssl dependencies by giving it a path in --with-ssl
and using pkg-config to directly pass the correct libraries in LIBS.
This will disable the call to pkg-config and CF_ADD_LIBS which has the
sad behavior of removing duplicates ...
As a result, build fails because, the following correct dependencies:
configure:14170: testing adding -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic to LIBS ...
is replaced by:
-L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -lz -pthread -latomic -lcrypto
As a result, static linking fails on crypto because the second -latomic
has been removed ...
Fixes:
- http://autobuild.buildroot.org/results/2c28426253014d93e86e3ba6ed578e84317a9f19
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/lynx/lynx.mk | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/lynx/lynx.mk b/package/lynx/lynx.mk
index 174d741dd9..3ac5b4cabf 100644
--- a/package/lynx/lynx.mk
+++ b/package/lynx/lynx.mk
@@ -21,8 +21,9 @@ LYNX_CONF_OPTS += --with-screen=slang
endif
ifeq ($(BR2_PACKAGE_OPENSSL),y)
-LYNX_DEPENDENCIES += openssl
-LYNX_CONF_OPTS += --with-ssl
+LYNX_DEPENDENCIES += host-pkgconf openssl
+LYNX_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
+LYNX_CONF_ENV = LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
else ifeq ($(BR2_PACKAGE_GNUTLS),y)
LYNX_DEPENDENCIES += gnutls
LYNX_CONF_OPTS += --with-gnutls
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/lynx: fix build with latomic
2019-04-22 10:48 [Buildroot] [PATCH 1/1] package/lynx: fix build with latomic Fabrice Fontaine
@ 2019-04-22 20:24 ` Thomas Petazzoni
2019-04-26 12:46 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:24 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Mon, 22 Apr 2019 12:48:21 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Help lynx finding openssl dependencies by giving it a path in --with-ssl
> and using pkg-config to directly pass the correct libraries in LIBS.
>
> This will disable the call to pkg-config and CF_ADD_LIBS which has the
> sad behavior of removing duplicates ...
Could this issue be reported upstream ?
> As a result, build fails because, the following correct dependencies:
>
> configure:14170: testing adding -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic to LIBS ...
>
> is replaced by:
>
> -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -lz -pthread -latomic -lcrypto
>
> As a result, static linking fails on crypto because the second -latomic
> has been removed ...
>
> Fixes:
> - http://autobuild.buildroot.org/results/2c28426253014d93e86e3ba6ed578e84317a9f19
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/lynx/lynx.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/lynx: fix build with latomic
2019-04-22 10:48 [Buildroot] [PATCH 1/1] package/lynx: fix build with latomic Fabrice Fontaine
2019-04-22 20:24 ` Thomas Petazzoni
@ 2019-04-26 12:46 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-04-26 12:46 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Help lynx finding openssl dependencies by giving it a path in --with-ssl
> and using pkg-config to directly pass the correct libraries in LIBS.
> This will disable the call to pkg-config and CF_ADD_LIBS which has the
> sad behavior of removing duplicates ...
> As a result, build fails because, the following correct dependencies:
> configure:14170: testing adding
> -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib
> -lssl
> -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib
> -lz -pthread -latomic -lcrypto -lz -pthread -latomic to LIBS ...
> is replaced by:
> -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib
> -lssl -lz -pthread -latomic -lcrypto
> As a result, static linking fails on crypto because the second -latomic
> has been removed ...
> Fixes:
> - http://autobuild.buildroot.org/results/2c28426253014d93e86e3ba6ed578e84317a9f19
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-26 12:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 10:48 [Buildroot] [PATCH 1/1] package/lynx: fix build with latomic Fabrice Fontaine
2019-04-22 20:24 ` Thomas Petazzoni
2019-04-26 12:46 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.