* [PATCH] mips: vdso: drop unnecessary cc-ldoption
@ 2019-04-23 20:55 Nick Desaulniers
2019-04-23 21:55 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Nick Desaulniers @ 2019-04-23 20:55 UTC (permalink / raw)
To: ralf, paul.burton, jhogan
Cc: Nick Desaulniers, clang-built-linux, Masahiro Yamada,
Matt Redfearn, Joel Stanley, Hassan Naveed, linux-mips,
linux-kernel
Towards the goal of removing cc-ldoption, it seems that --hash-style=
was added to binutils 2.17.50.0.2 in 2006. The minimal required version
of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.
--build-id was added in 2.18 according to binutils-gdb/ld/NEWS.
Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
Cc: clang-built-linux@googlegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/mips/vdso/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index 0ede4deb8181..7221df24cb23 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -46,9 +46,7 @@ endif
VDSO_LDFLAGS := \
-Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 \
$(addprefix -Wl$(comma),$(filter -E%,$(KBUILD_CFLAGS))) \
- -nostdlib -shared \
- $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) \
- $(call cc-ldoption, -Wl$(comma)--build-id)
+ -nostdlib -shared -Wl,--hash-style=sysv -Wl,--build-id
GCOV_PROFILE := n
UBSAN_SANITIZE := n
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mips: vdso: drop unnecessary cc-ldoption
2019-04-23 20:55 [PATCH] mips: vdso: drop unnecessary cc-ldoption Nick Desaulniers
@ 2019-04-23 21:55 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-04-23 21:55 UTC (permalink / raw)
To: Nick Desaulniers
Cc: ralf, Paul Burton, jhogan, Nick Desaulniers, clang-built-linux,
Masahiro Yamada, Matt Redfearn, Joel Stanley, Hassan Naveed,
linux-mips, linux-kernel, linux-mips
Hello,
Nick Desaulniers wrote:
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
>
> --build-id was added in 2.18 according to binutils-gdb/ld/NEWS.
>
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Applied to mips-next.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-23 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 20:55 [PATCH] mips: vdso: drop unnecessary cc-ldoption Nick Desaulniers
2019-04-23 21:55 ` Paul Burton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.