All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node
Date: Mon, 20 May 2019 09:36:52 +0200	[thread overview]
Message-ID: <20190520073652.itk452vrpnicta5v@flea> (raw)
In-Reply-To: <20190518152355.11134-3-peron.clem@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote:
> Allwinner H6 has a watchog node which seems broken
> on some boards.
>
> Test has been performed on several boards.
>
> Chen-Yu Tsai boards:
> Pine H64 - H6448BA 7782 => OK
> OrangePi Lite 2 - H8068BA 61C2 => KO
>
> Martin Ayotte boards:
> Pine H64 - H8069BA 6892 => OK
> OrangePi 3 - HA047BA 69W2 => KO
> OrangePi One Plus - H7310BA 6842 => KO
> OrangePi Lite2 - H6448BA 6662 => KO
>
> Clément Péron board:
> Beelink GS1 - H7309BA 6842 => KO
>
> As it seems not fixable for now, declare the node
> but leave it disable with a comment.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

If it doesn't work most boards, then why do we need to merge that
patch in the first place?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node
Date: Mon, 20 May 2019 09:36:52 +0200	[thread overview]
Message-ID: <20190520073652.itk452vrpnicta5v@flea> (raw)
In-Reply-To: <20190518152355.11134-3-peron.clem@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 876 bytes --]

On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote:
> Allwinner H6 has a watchog node which seems broken
> on some boards.
>
> Test has been performed on several boards.
>
> Chen-Yu Tsai boards:
> Pine H64 - H6448BA 7782 => OK
> OrangePi Lite 2 - H8068BA 61C2 => KO
>
> Martin Ayotte boards:
> Pine H64 - H8069BA 6892 => OK
> OrangePi 3 - HA047BA 69W2 => KO
> OrangePi One Plus - H7310BA 6842 => KO
> OrangePi Lite2 - H6448BA 6662 => KO
>
> Clément Péron board:
> Beelink GS1 - H7309BA 6842 => KO
>
> As it seems not fixable for now, declare the node
> but leave it disable with a comment.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

If it doesn't work most boards, then why do we need to merge that
patch in the first place?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-20  7:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18 15:23 [PATCH v3 0/4] Allwinner H6 watchdog support Clément Péron
2019-05-18 15:23 ` Clément Péron
2019-05-18 15:23 ` [PATCH v3 1/4] dt-bindings: watchdog: add Allwinner H6 watchdog Clément Péron
2019-05-18 15:23   ` Clément Péron
2019-05-20  7:35   ` Maxime Ripard
2019-05-20  7:35     ` Maxime Ripard
2019-05-20  8:14     ` Clément Péron
2019-05-20  8:14       ` Clément Péron
2019-05-20 14:42       ` Maxime Ripard
2019-05-20 14:42         ` Maxime Ripard
2019-05-20 15:16         ` Clément Péron
2019-05-20 15:16           ` Clément Péron
2019-05-18 15:23 ` [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node Clément Péron
2019-05-18 15:23   ` Clément Péron
2019-05-20  7:36   ` Maxime Ripard [this message]
2019-05-20  7:36     ` Maxime Ripard
2019-05-20  8:21     ` Clément Péron
2019-05-20  8:21       ` Clément Péron
2019-05-20 14:44       ` Maxime Ripard
2019-05-20 14:44         ` Maxime Ripard
2019-05-20 14:57         ` Chen-Yu Tsai
2019-05-20 14:57           ` Chen-Yu Tsai
2019-05-18 15:23 ` [PATCH v3 3/4] arm64: dts: allwinner: h6: add r_watchog node Clément Péron
2019-05-18 15:23   ` Clément Péron
2019-05-20 15:19   ` Clément Péron
2019-05-20 15:19     ` Clément Péron
2019-05-18 15:23 ` [PATCH v3 4/4] arm64: defconfig: enable sunxi watchdog Clément Péron
2019-05-18 15:23   ` Clément Péron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520073652.itk452vrpnicta5v@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=peron.clem@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.