From: Andrew Lunn <andrew@lunn.ch>
To: Yash Shah <yash.shah@sifive.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, nicolas.ferre@microchip.com,
palmer@sifive.com, aou@eecs.berkeley.edu, ynezz@true.cz,
paul.walmsley@sifive.com, sachin.ghadi@sifive.com
Subject: Re: [PATCH 2/2] net: macb: Add support for SiFive FU540-C000
Date: Thu, 23 May 2019 16:54:17 +0200 [thread overview]
Message-ID: <20190523145417.GD19369@lunn.ch> (raw)
In-Reply-To: <1558611952-13295-3-git-send-email-yash.shah@sifive.com>
> +static int fu540_macb_tx_set_rate(struct clk_hw *hw, unsigned long rate,
> + unsigned long parent_rate)
> +{
> + rate = fu540_macb_tx_round_rate(hw, rate, &parent_rate);
> + iowrite32(rate != 125000000, mgmt->reg);
That looks odd. Writing the result of a comparison to a register?
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Yash Shah <yash.shah@sifive.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
aou@eecs.berkeley.edu, netdev@vger.kernel.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com,
sachin.ghadi@sifive.com, robh+dt@kernel.org,
paul.walmsley@sifive.com, ynezz@true.cz,
linux-riscv@lists.infradead.org, davem@davemloft.net
Subject: Re: [PATCH 2/2] net: macb: Add support for SiFive FU540-C000
Date: Thu, 23 May 2019 16:54:17 +0200 [thread overview]
Message-ID: <20190523145417.GD19369@lunn.ch> (raw)
In-Reply-To: <1558611952-13295-3-git-send-email-yash.shah@sifive.com>
> +static int fu540_macb_tx_set_rate(struct clk_hw *hw, unsigned long rate,
> + unsigned long parent_rate)
> +{
> + rate = fu540_macb_tx_round_rate(hw, rate, &parent_rate);
> + iowrite32(rate != 125000000, mgmt->reg);
That looks odd. Writing the result of a comparison to a register?
Andrew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-23 14:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 11:45 [PATCH 0/2] net: macb: Add support for SiFive FU540-C000 Yash Shah
2019-05-23 11:45 ` Yash Shah
2019-05-23 11:45 ` [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding Yash Shah
2019-05-23 11:45 ` Yash Shah
2019-05-23 20:50 ` Rob Herring
2019-05-23 20:50 ` Rob Herring
2019-05-23 20:50 ` Rob Herring
2019-05-24 4:56 ` Yash Shah
2019-05-24 4:56 ` Yash Shah
2019-06-24 15:38 ` Nicolas.Ferre
2019-06-24 15:38 ` Nicolas.Ferre
2019-06-24 15:38 ` Nicolas.Ferre
2019-07-17 9:07 ` Yash Shah
2019-07-17 9:07 ` Yash Shah
2019-05-23 11:45 ` [PATCH 2/2] net: macb: Add support for SiFive FU540-C000 Yash Shah
2019-05-23 11:45 ` Yash Shah
2019-05-23 14:54 ` Andrew Lunn [this message]
2019-05-23 14:54 ` Andrew Lunn
2019-05-24 4:52 ` Yash Shah
2019-05-24 4:52 ` Yash Shah
2019-05-24 4:52 ` Yash Shah
2019-05-24 13:48 ` Andrew Lunn
2019-05-24 13:48 ` Andrew Lunn
2019-05-30 2:42 ` Palmer Dabbelt
2019-05-30 2:42 ` Palmer Dabbelt
2019-05-23 12:49 ` [PATCH 0/2] " Andreas Schwab
2019-05-23 12:49 ` Andreas Schwab
2019-05-24 4:39 ` Yash Shah
2019-05-24 4:39 ` Yash Shah
2019-05-27 8:04 ` Andreas Schwab
2019-05-27 8:04 ` Andreas Schwab
2019-05-27 11:52 ` Yash Shah
2019-05-27 11:52 ` Yash Shah
2019-05-27 11:52 ` Yash Shah
2019-05-23 16:28 ` David Miller
2019-05-23 16:28 ` David Miller
2019-05-24 4:54 ` Yash Shah
2019-05-24 4:54 ` Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523145417.GD19369@lunn.ch \
--to=andrew@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.