All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Horia Geanta <horia.geanta@nxp.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v1 00/15] Fixing selftests failure on Talitos driver
Date: Tue, 28 May 2019 18:48:10 +0200	[thread overview]
Message-ID: <20190528184810.Horde.kzboSxOzA1nukNNnhCIE7g1@messagerie.si.c-s.fr> (raw)
In-Reply-To: <VI1PR0402MB34850975FDD8F5F1CE366A9C981E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>

Horia Geanta <horia.geanta@nxp.com> a écrit :

> On 5/21/2019 4:34 PM, Christophe Leroy wrote:
>> Several test failures have popped up following recent changes to crypto
>> selftests.
>>
>> This series fixes (most of) them.
>>
>> The last three patches are trivial cleanups.
>>
> Thanks Christophe.
>
> For the series:
> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
>
> Have you validated the changes also on SEC 2.x+?
> Asking since IIRC you mentioned having only HW with SEC 1 and  
> changes in patch
> "crypto: talitos - fix AEAD processing." look quite complex.

When I ported the driver to SEC1 some years ago I only had a SEC 1.2  
(mpc885) but I now have also a board with a mpc8321E which embeds a  
SEC 2.2 so I also tested the changes on it.

Christophe

>
> Thanks,
> Horia



WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Horia Geanta <horia.geanta@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v1 00/15] Fixing selftests failure on Talitos driver
Date: Tue, 28 May 2019 18:48:10 +0200	[thread overview]
Message-ID: <20190528184810.Horde.kzboSxOzA1nukNNnhCIE7g1@messagerie.si.c-s.fr> (raw)
In-Reply-To: <VI1PR0402MB34850975FDD8F5F1CE366A9C981E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>

Horia Geanta <horia.geanta@nxp.com> a écrit :

> On 5/21/2019 4:34 PM, Christophe Leroy wrote:
>> Several test failures have popped up following recent changes to crypto
>> selftests.
>>
>> This series fixes (most of) them.
>>
>> The last three patches are trivial cleanups.
>>
> Thanks Christophe.
>
> For the series:
> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
>
> Have you validated the changes also on SEC 2.x+?
> Asking since IIRC you mentioned having only HW with SEC 1 and  
> changes in patch
> "crypto: talitos - fix AEAD processing." look quite complex.

When I ported the driver to SEC1 some years ago I only had a SEC 1.2  
(mpc885) but I now have also a board with a mpc8321E which embeds a  
SEC 2.2 so I also tested the changes on it.

Christophe

>
> Thanks,
> Horia



  reply	other threads:[~2019-05-28 16:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 13:34 [PATCH v1 00/15] Fixing selftests failure on Talitos driver Christophe Leroy
2019-05-21 13:34 ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 01/15] crypto: talitos - fix skcipher failure due to wrong output IV Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 17:54   ` Christophe Leroy
2019-05-21 18:10     ` Joe Perches
2019-05-21 13:34 ` [PATCH v1 03/15] crypto: talitos - reduce max key size for SEC1 Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 04/15] crypto: talitos - check AES key size Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 05/15] crypto: talitos - fix CTR alg blocksize Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 06/15] crypto: talitos - check data blocksize in ablkcipher Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 07/15] crypto: talitos - fix ECB algs ivsize Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 08/15] crypto: talitos - Do not modify req->cryptlen on decryption Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-28  8:20   ` Horia Geanta
2019-05-28  8:20     ` Horia Geanta
2019-05-21 13:34 ` [PATCH v1 09/15] crypto: talitos - HMAC SNOOP NO AFEU mode requires SW icv checking Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 10/15] crypto: talitos - properly handle split ICV Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 11/15] crypto: talitos - Align SEC1 accesses to 32 bits boundaries Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 12/15] crypto: talitos - fix AEAD processing Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 13/15] Revert "crypto: talitos - export the talitos_submit function" Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 14/15] crypto: talitos - use IS_ENABLED() in has_ftr_sec1() Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 15/15] crypto: talitos - use SPDX-License-Identifier Christophe Leroy
2019-05-21 13:34   ` Christophe Leroy
2019-05-28  9:17 ` [PATCH v1 00/15] Fixing selftests failure on Talitos driver Horia Geanta
2019-05-28  9:17   ` Horia Geanta
2019-05-28 16:48   ` Christophe Leroy [this message]
2019-05-28 16:48     ` Christophe Leroy
2019-05-30 13:42 ` Herbert Xu
2019-05-30 13:42   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528184810.Horde.kzboSxOzA1nukNNnhCIE7g1@messagerie.si.c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.