From: Christoph Hellwig <hch@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()
Date: Wed, 29 May 2019 23:34:59 -0700 [thread overview]
Message-ID: <20190530063459.GA2181@infradead.org> (raw)
In-Reply-To: <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com>
On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote:
> __do_page_fault() is over complicated with multiple goto statements. This
> cleans up code flow and while there drops the vm_fault_t argument.
There is no argument dropped anywhere, just a local variable.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Andrey Konovalov <andreyknvl@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()
Date: Wed, 29 May 2019 23:34:59 -0700 [thread overview]
Message-ID: <20190530063459.GA2181@infradead.org> (raw)
In-Reply-To: <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com>
On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote:
> __do_page_fault() is over complicated with multiple goto statements. This
> cleans up code flow and while there drops the vm_fault_t argument.
There is no argument dropped anywhere, just a local variable.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 6:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:34 [PATCH 0/4] arm64/mm: Fixes and cleanups for do_page_fault() Anshuman Khandual
2019-05-29 12:34 ` Anshuman Khandual
2019-05-29 12:34 ` [PATCH 1/4] arm64/mm: Drop mmap_sem before calling __do_kernel_fault() Anshuman Khandual
2019-05-29 12:34 ` Anshuman Khandual
2019-05-29 12:34 ` [PATCH 2/4] arm64/mm: Drop task_struct argument from __do_page_fault() Anshuman Khandual
2019-05-29 12:34 ` Anshuman Khandual
2019-05-29 12:34 ` [PATCH 3/4] arm64/mm: Consolidate page fault information capture Anshuman Khandual
2019-05-29 12:34 ` Anshuman Khandual
2019-05-29 14:53 ` Mark Rutland
2019-05-29 14:53 ` Mark Rutland
2019-05-31 9:10 ` Anshuman Khandual
2019-05-31 9:10 ` Anshuman Khandual
2019-05-29 12:34 ` [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault() Anshuman Khandual
2019-05-29 12:34 ` Anshuman Khandual
2019-05-29 15:11 ` Mark Rutland
2019-05-29 15:11 ` Mark Rutland
2019-05-31 9:05 ` Anshuman Khandual
2019-05-31 9:05 ` Anshuman Khandual
2019-05-30 6:34 ` Christoph Hellwig [this message]
2019-05-30 6:34 ` Christoph Hellwig
2019-05-31 8:55 ` Anshuman Khandual
2019-05-31 8:55 ` Anshuman Khandual
2019-05-29 12:41 ` [PATCH 0/4] arm64/mm: Fixes and cleanups for do_page_fault() Will Deacon
2019-05-29 12:41 ` Will Deacon
2019-05-29 12:59 ` Anshuman Khandual
2019-05-29 12:59 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530063459.GA2181@infradead.org \
--to=hch@infradead.org \
--cc=andreyknvl@google.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.