From: David Miller <davem@davemloft.net>
To: biao.huang@mediatek.com
Cc: joabreu@synopsys.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, mcoquelin.stm32@gmail.com,
matthias.bgg@gmail.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
yt.shen@mediatek.com, jianguo.zhang@mediatek.com,
boon.leong.ong@intel.com, andrew@lunn.ch
Subject: Re: [RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain
Date: Sun, 02 Jun 2019 13:01:18 -0700 (PDT) [thread overview]
Message-ID: <20190602.130118.1624703340305098863.davem@davemloft.net> (raw)
In-Reply-To: <1559209398-3607-2-git-send-email-biao.huang@mediatek.com>
From: Biao Huang <biao.huang@mediatek.com>
Date: Thu, 30 May 2019 17:43:15 +0800
> @@ -364,6 +371,15 @@ static int mediatek_dwmac_probe(struct platform_device *pdev)
> return 0;
> }
>
> +static int mediatek_dwmac_remove(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = stmmac_pltfr_remove(pdev);
> +
> + return ret;
> +}
> +
> static const struct of_device_id mediatek_dwmac_match[] = {
> { .compatible = "mediatek,mt2712-gmac",
> .data = &mt2712_gmac_variant },
> @@ -374,7 +390,7 @@ static int mediatek_dwmac_probe(struct platform_device *pdev)
>
> static struct platform_driver mediatek_dwmac_driver = {
> .probe = mediatek_dwmac_probe,
> - .remove = stmmac_pltfr_remove,
> + .remove = mediatek_dwmac_remove,
> .driver = {
> .name = "dwmac-mediatek",
> .pm = &stmmac_pltfr_pm_ops,
This half of your patch has no effect and seems completely unnecessary.
Please remove it.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: biao.huang@mediatek.com
Cc: andrew@lunn.ch, jianguo.zhang@mediatek.com,
alexandre.torgue@st.com, boon.leong.ong@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yt.shen@mediatek.com, joabreu@synopsys.com,
linux-mediatek@lists.infradead.org, mcoquelin.stm32@gmail.com,
matthias.bgg@gmail.com, peppe.cavallaro@st.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain
Date: Sun, 02 Jun 2019 13:01:18 -0700 (PDT) [thread overview]
Message-ID: <20190602.130118.1624703340305098863.davem@davemloft.net> (raw)
In-Reply-To: <1559209398-3607-2-git-send-email-biao.huang@mediatek.com>
From: Biao Huang <biao.huang@mediatek.com>
Date: Thu, 30 May 2019 17:43:15 +0800
> @@ -364,6 +371,15 @@ static int mediatek_dwmac_probe(struct platform_device *pdev)
> return 0;
> }
>
> +static int mediatek_dwmac_remove(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = stmmac_pltfr_remove(pdev);
> +
> + return ret;
> +}
> +
> static const struct of_device_id mediatek_dwmac_match[] = {
> { .compatible = "mediatek,mt2712-gmac",
> .data = &mt2712_gmac_variant },
> @@ -374,7 +390,7 @@ static int mediatek_dwmac_probe(struct platform_device *pdev)
>
> static struct platform_driver mediatek_dwmac_driver = {
> .probe = mediatek_dwmac_probe,
> - .remove = stmmac_pltfr_remove,
> + .remove = mediatek_dwmac_remove,
> .driver = {
> .name = "dwmac-mediatek",
> .pm = &stmmac_pltfr_pm_ops,
This half of your patch has no effect and seems completely unnecessary.
Please remove it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-02 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 9:43 [RESEND, PATCH 0/4] complete dwmac-mediatek driver and fix flow control issue Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` [RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-06-02 20:01 ` David Miller [this message]
2019-06-02 20:01 ` David Miller
2019-05-30 9:43 ` [RESEND, PATCH 2/4] net: stmmac: dwmac-mediatek: disable rx watchdog Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` [RESEND, PATCH 3/4] net: stmmac: modify default value of tx-frames Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` [RESEND, PATCH 4/4] net: stmmac: dwmac4: fix flow control issue Biao Huang
2019-05-30 9:43 ` Biao Huang
2019-05-30 9:43 ` Biao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190602.130118.1624703340305098863.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=biao.huang@mediatek.com \
--cc=boon.leong.ong@intel.com \
--cc=jianguo.zhang@mediatek.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.