* [meta-oe][PATCH] gpsd: Don't build without optimization
@ 2019-07-09 17:26 Adrian Bunk
2019-07-09 18:54 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2019-07-09 17:26 UTC (permalink / raw)
To: openembedded-devel
The upstream build system adds -O0 when debug is enabled.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
index 6716f402a..43bf25a93 100644
--- a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
+++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
@@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
EXTRA_OESCONS = " \
sysroot=${STAGING_DIR_TARGET} \
libQgpsmm='false' \
- debug='true' \
- strip='false' \
+ debug='false' \
+ nostrip='true' \
chrpath='yes' \
systemd='${SYSTEMD_OESCONS}' \
libdir='${libdir}' \
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH] gpsd: Don't build without optimization
2019-07-09 17:26 [meta-oe][PATCH] gpsd: Don't build without optimization Adrian Bunk
@ 2019-07-09 18:54 ` Khem Raj
2019-07-09 19:17 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2019-07-09 18:54 UTC (permalink / raw)
To: Adrian Bunk; +Cc: openembeded-devel
On Tue, Jul 9, 2019 at 10:26 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> The upstream build system adds -O0 when debug is enabled.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
> meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> index 6716f402a..43bf25a93 100644
> --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> @@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
> EXTRA_OESCONS = " \
> sysroot=${STAGING_DIR_TARGET} \
> libQgpsmm='false' \
> - debug='true' \
> - strip='false' \
> + debug='false' \
> + nostrip='true' \
I think this change is improvement over what we have, however it will
be nicer if it was knobbed with
DEBUG_BUILD flag, then we can get proper debug info when doing a debug
build as user will expect.
> chrpath='yes' \
> systemd='${SYSTEMD_OESCONS}' \
> libdir='${libdir}' \
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH] gpsd: Don't build without optimization
2019-07-09 18:54 ` Khem Raj
@ 2019-07-09 19:17 ` Adrian Bunk
2019-07-09 19:23 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2019-07-09 19:17 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
On Tue, Jul 09, 2019 at 11:54:19AM -0700, Khem Raj wrote:
> On Tue, Jul 9, 2019 at 10:26 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > The upstream build system adds -O0 when debug is enabled.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> > meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > index 6716f402a..43bf25a93 100644
> > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > @@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
> > EXTRA_OESCONS = " \
> > sysroot=${STAGING_DIR_TARGET} \
> > libQgpsmm='false' \
> > - debug='true' \
> > - strip='false' \
> > + debug='false' \
> > + nostrip='true' \
>
> I think this change is improvement over what we have, however it will
> be nicer if it was knobbed with
> DEBUG_BUILD flag, then we can get proper debug info when doing a debug
> build as user will expect.
>...
Sorry for being terse in the description.
For gpsd "debug" means adding -g here, and this is already additionally
inserted through the normal OE CFLAGS.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH] gpsd: Don't build without optimization
2019-07-09 19:17 ` Adrian Bunk
@ 2019-07-09 19:23 ` Khem Raj
2019-07-09 20:52 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2019-07-09 19:23 UTC (permalink / raw)
To: Adrian Bunk; +Cc: openembeded-devel
On Tue, Jul 9, 2019 at 12:17 PM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Tue, Jul 09, 2019 at 11:54:19AM -0700, Khem Raj wrote:
> > On Tue, Jul 9, 2019 at 10:26 AM Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > The upstream build system adds -O0 when debug is enabled.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > > ---
> > > meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > > index 6716f402a..43bf25a93 100644
> > > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > > @@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
> > > EXTRA_OESCONS = " \
> > > sysroot=${STAGING_DIR_TARGET} \
> > > libQgpsmm='false' \
> > > - debug='true' \
> > > - strip='false' \
> > > + debug='false' \
> > > + nostrip='true' \
> >
> > I think this change is improvement over what we have, however it will
> > be nicer if it was knobbed with
> > DEBUG_BUILD flag, then we can get proper debug info when doing a debug
> > build as user will expect.
> >...
>
> Sorry for being terse in the description.
>
> For gpsd "debug" means adding -g here, and this is already additionally
> inserted through the normal OE CFLAGS.
I see, then the patch subject and commit msg should be updated, thanks
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH] gpsd: Don't build without optimization
2019-07-09 19:23 ` Khem Raj
@ 2019-07-09 20:52 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2019-07-09 20:52 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
On Tue, Jul 09, 2019 at 12:23:35PM -0700, Khem Raj wrote:
> On Tue, Jul 9, 2019 at 12:17 PM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Tue, Jul 09, 2019 at 11:54:19AM -0700, Khem Raj wrote:
> > > On Tue, Jul 9, 2019 at 10:26 AM Adrian Bunk <bunk@stusta.de> wrote:
> > > >
> > > > The upstream build system adds -O0 when debug is enabled.
> > > >
> > > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > > > ---
> > > > meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > > > index 6716f402a..43bf25a93 100644
> > > > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > > > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb
> > > > @@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
> > > > EXTRA_OESCONS = " \
> > > > sysroot=${STAGING_DIR_TARGET} \
> > > > libQgpsmm='false' \
> > > > - debug='true' \
> > > > - strip='false' \
> > > > + debug='false' \
> > > > + nostrip='true' \
> > >
> > > I think this change is improvement over what we have, however it will
> > > be nicer if it was knobbed with
> > > DEBUG_BUILD flag, then we can get proper debug info when doing a debug
> > > build as user will expect.
> > >...
> >
> > Sorry for being terse in the description.
> >
> > For gpsd "debug" means adding -g here, and this is already additionally
> > inserted through the normal OE CFLAGS.
>
> I see, then the patch subject and commit msg should be updated, thanks
v2 sent with updated commit msg, subject looks OK to me.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-09 20:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 17:26 [meta-oe][PATCH] gpsd: Don't build without optimization Adrian Bunk
2019-07-09 18:54 ` Khem Raj
2019-07-09 19:17 ` Adrian Bunk
2019-07-09 19:23 ` Khem Raj
2019-07-09 20:52 ` Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.