From: Stephen Boyd <swboyd@chromium.org> To: linux-kernel@vger.kernel.org Cc: Russell King <linux@armlinux.org.uk>, Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>, Maxime Ripard <maxime.ripard@bootlin.com>, Simon Horman <horms+renesas@verge.net.au>, Chen-Yu Tsai <wens@csie.org>, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: [PATCH v6 07/57] ARM: Remove dev_err() usage after platform_get_irq() Date: Tue, 30 Jul 2019 11:15:07 -0700 [thread overview] Message-ID: <20190730181557.90391-8-swboyd@chromium.org> (raw) In-Reply-To: <20190730181557.90391-1-swboyd@chromium.org> We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Russell King <linux@armlinux.org.uk> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Tony Lindgren <tony@atomide.com> Cc: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Chen-Yu Tsai <wens@csie.org> Cc: linux-arm-kernel@lists.infradead.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Please apply directly to subsystem trees arch/arm/plat-omap/dma.c | 1 - arch/arm/plat-pxa/ssp.c | 5 ++--- arch/arm/plat-samsung/adc.c | 4 +--- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 79f43acf9acb..9386b2e9b332 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -1371,7 +1371,6 @@ static int omap_system_dma_probe(struct platform_device *pdev) strcpy(irq_name, "0"); dma_irq = platform_get_irq_byname(pdev, irq_name); if (dma_irq < 0) { - dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq); ret = dma_irq; goto exit_dma_lch_fail; } diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index 9a6e4923bd69..88b5dd99f6bc 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -146,10 +146,9 @@ static int pxa_ssp_probe(struct platform_device *pdev) } ssp->irq = platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - } + if (dev->of_node) { const struct of_device_id *id = diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c index ee3d5c989a76..4bbeca3cbd9e 100644 --- a/arch/arm/plat-samsung/adc.c +++ b/arch/arm/plat-samsung/adc.c @@ -354,10 +354,8 @@ static int s3c_adc_probe(struct platform_device *pdev) } adc->irq = platform_get_irq(pdev, 1); - if (adc->irq <= 0) { - dev_err(dev, "failed to get adc irq\n"); + if (adc->irq <= 0) return -ENOENT; - } ret = devm_request_irq(dev, adc->irq, s3c_adc_irq, 0, dev_name(dev), adc); -- Sent by a computer through tubes
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: linux-kernel@vger.kernel.org Cc: Tony Lindgren <tony@atomide.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Russell King <linux@armlinux.org.uk>, Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Simon Horman <horms+renesas@verge.net.au>, Shawn Guo <shawnguo@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 07/57] ARM: Remove dev_err() usage after platform_get_irq() Date: Tue, 30 Jul 2019 11:15:07 -0700 [thread overview] Message-ID: <20190730181557.90391-8-swboyd@chromium.org> (raw) In-Reply-To: <20190730181557.90391-1-swboyd@chromium.org> We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Russell King <linux@armlinux.org.uk> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Tony Lindgren <tony@atomide.com> Cc: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Chen-Yu Tsai <wens@csie.org> Cc: linux-arm-kernel@lists.infradead.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Please apply directly to subsystem trees arch/arm/plat-omap/dma.c | 1 - arch/arm/plat-pxa/ssp.c | 5 ++--- arch/arm/plat-samsung/adc.c | 4 +--- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 79f43acf9acb..9386b2e9b332 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -1371,7 +1371,6 @@ static int omap_system_dma_probe(struct platform_device *pdev) strcpy(irq_name, "0"); dma_irq = platform_get_irq_byname(pdev, irq_name); if (dma_irq < 0) { - dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq); ret = dma_irq; goto exit_dma_lch_fail; } diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index 9a6e4923bd69..88b5dd99f6bc 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -146,10 +146,9 @@ static int pxa_ssp_probe(struct platform_device *pdev) } ssp->irq = platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - } + if (dev->of_node) { const struct of_device_id *id = diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c index ee3d5c989a76..4bbeca3cbd9e 100644 --- a/arch/arm/plat-samsung/adc.c +++ b/arch/arm/plat-samsung/adc.c @@ -354,10 +354,8 @@ static int s3c_adc_probe(struct platform_device *pdev) } adc->irq = platform_get_irq(pdev, 1); - if (adc->irq <= 0) { - dev_err(dev, "failed to get adc irq\n"); + if (adc->irq <= 0) return -ENOENT; - } ret = devm_request_irq(dev, adc->irq, s3c_adc_irq, 0, dev_name(dev), adc); -- Sent by a computer through tubes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-30 18:16 UTC|newest] Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-30 18:15 [PATCH v6 00/57] Add error message to platform_get_irq*() Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 01/57] ata: Remove dev_err() usage after platform_get_irq() Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 02/57] bus: sunxi-rsb: " Stephen Boyd 2019-08-05 3:35 ` Chen-Yu Tsai 2019-08-05 20:44 ` Stephen Boyd 2019-08-06 6:20 ` Chen-Yu Tsai 2019-07-30 18:15 ` [PATCH v6 03/57] hwrng: " Stephen Boyd 2019-08-09 6:17 ` Herbert Xu 2019-07-30 18:15 ` [PATCH v6 04/57] clocksource: " Stephen Boyd 2019-08-08 7:47 ` Geert Uytterhoeven 2019-08-09 6:56 ` Daniel Lezcano 2019-07-30 18:15 ` [PATCH v6 05/57] crypto: " Stephen Boyd 2019-08-09 6:17 ` Herbert Xu 2019-07-30 18:15 ` [PATCH v6 06/57] cpufreq: " Stephen Boyd 2019-07-30 18:15 ` Stephen Boyd [this message] 2019-07-30 18:15 ` [PATCH v6 07/57] ARM: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 08/57] MIPS: " Stephen Boyd 2019-08-26 11:05 ` Paul Burton 2019-07-30 18:15 ` [PATCH v6 09/57] devfreq: " Stephen Boyd 2019-07-31 0:21 ` Chanwoo Choi 2019-07-30 18:15 ` [PATCH v6 10/57] dmaengine: " Stephen Boyd 2019-07-31 15:28 ` Vinod Koul 2019-07-30 18:15 ` [PATCH v6 11/57] edac: " Stephen Boyd 2019-08-02 17:04 ` James Morse 2019-07-30 18:15 ` [PATCH v6 12/57] extcon: " Stephen Boyd 2019-07-31 0:20 ` Chanwoo Choi 2019-07-30 18:15 ` [PATCH v6 13/57] firmware: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 14/57] fpga: " Stephen Boyd 2019-08-31 20:55 ` Moritz Fischer 2019-08-31 20:55 ` Moritz Fischer 2019-07-30 18:15 ` [PATCH v6 15/57] gpio: " Stephen Boyd 2019-07-31 7:28 ` Bartosz Golaszewski 2019-08-05 11:26 ` Linus Walleij 2019-07-30 18:15 ` [PATCH v6 16/57] HSI: " Stephen Boyd 2019-07-30 20:44 ` Sebastian Reichel 2019-07-30 18:15 ` [PATCH v6 17/57] hwmon: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 18/57] i2c: " Stephen Boyd 2019-07-31 14:30 ` Wolfram Sang 2019-07-31 14:46 ` Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 19/57] iio: " Stephen Boyd 2019-07-31 6:42 ` Phil Reid 2019-07-31 14:32 ` Stephen Boyd 2019-08-01 2:37 ` Phil Reid 2019-08-05 15:01 ` Jonathan Cameron 2019-08-05 15:00 ` Jonathan Cameron 2019-07-30 18:15 ` [PATCH v6 20/57] infiniband: " Stephen Boyd 2019-07-31 15:53 ` Doug Ledford 2019-07-30 18:15 ` [PATCH v6 21/57] Input: " Stephen Boyd 2019-08-14 17:48 ` Dmitry Torokhov 2019-07-30 18:15 ` [PATCH v6 22/57] iommu: " Stephen Boyd 2019-07-30 18:15 ` Stephen Boyd 2019-08-09 15:33 ` Joerg Roedel 2019-08-09 15:33 ` Joerg Roedel 2019-07-30 18:15 ` [PATCH v6 23/57] irqchip: " Stephen Boyd 2019-08-07 14:23 ` Marc Zyngier 2019-07-30 18:15 ` [PATCH v6 24/57] mailbox: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 25/57] media: " Stephen Boyd 2019-08-08 7:56 ` Geert Uytterhoeven 2019-07-30 18:15 ` [PATCH v6 26/57] memory: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 27/57] mfd: " Stephen Boyd 2019-08-12 9:39 ` Lee Jones 2019-07-30 18:15 ` [PATCH v6 28/57] pcie-gadget-spear: " Stephen Boyd 2019-07-30 18:29 ` Arnd Bergmann 2019-07-31 14:16 ` Stephen Boyd 2019-08-05 16:05 ` Greg Kroah-Hartman 2019-07-30 18:15 ` [PATCH v6 29/57] mmc: " Stephen Boyd 2019-08-02 15:16 ` Ulf Hansson 2019-08-08 7:58 ` Geert Uytterhoeven 2019-07-30 18:15 ` [PATCH v6 30/57] mtd: " Stephen Boyd 2019-07-30 18:15 ` Stephen Boyd 2019-10-08 17:25 ` Miquel Raynal 2019-10-08 17:25 ` Miquel Raynal 2019-07-30 18:15 ` [PATCH v6 31/57] pci: " Stephen Boyd 2019-07-30 21:56 ` Bjorn Helgaas 2019-08-07 14:09 ` Marc Gonzalez 2019-08-07 22:08 ` Bjorn Helgaas 2019-08-08 8:02 ` Geert Uytterhoeven 2019-08-10 8:20 ` Linus Walleij 2019-07-30 18:15 ` [PATCH v6 32/57] perf: " Stephen Boyd 2019-07-30 18:15 ` Stephen Boyd 2019-07-31 8:40 ` Will Deacon 2019-07-31 8:40 ` Will Deacon 2019-07-31 14:07 ` Stephen Boyd 2019-07-31 14:07 ` Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 33/57] pinctrl: " Stephen Boyd 2019-08-05 11:24 ` Linus Walleij 2019-07-30 18:15 ` [PATCH v6 34/57] pinctrl: intel: " Stephen Boyd 2019-07-30 18:32 ` Andy Shevchenko 2019-08-01 13:57 ` Andy Shevchenko 2019-07-30 18:15 ` [PATCH v6 35/57] power: supply: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 36/57] pwm: " Stephen Boyd 2019-07-31 6:58 ` Uwe Kleine-König 2019-07-31 7:13 ` Greg Kroah-Hartman 2019-07-31 7:39 ` Uwe Kleine-König 2019-07-30 18:15 ` [PATCH v6 37/57] regulator: " Stephen Boyd 2019-08-02 11:22 ` Applied "regulator: Remove dev_err() usage after platform_get_irq()" to the regulator tree Mark Brown 2019-07-30 18:15 ` [PATCH v6 38/57] remoteproc: Remove dev_err() usage after platform_get_irq() Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 39/57] rtc: " Stephen Boyd 2019-08-08 8:05 ` Geert Uytterhoeven 2019-08-13 8:53 ` Alexandre Belloni 2019-07-30 18:15 ` [PATCH v6 40/57] soc: " Stephen Boyd 2019-07-30 18:35 ` Bjorn Andersson 2019-07-30 21:26 ` Leo Li 2019-07-30 21:36 ` Stephen Boyd 2019-07-31 18:50 ` Li Yang 2019-07-30 21:36 ` [PATCH v7 1/2] soc: fsl: qbman: " Stephen Boyd 2019-07-30 21:36 ` [PATCH v7 2/2] soc: qcom: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 41/57] spi: " Stephen Boyd 2019-08-02 11:22 ` Applied "spi: Remove dev_err() usage after platform_get_irq()" to the spi tree Mark Brown 2019-08-02 11:22 ` Mark Brown 2019-08-08 8:09 ` [PATCH v6 41/57] spi: Remove dev_err() usage after platform_get_irq() Geert Uytterhoeven 2019-07-30 18:15 ` [PATCH v6 42/57] staging: " Stephen Boyd 2019-07-30 18:15 ` Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 43/57] thermal: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 44/57] tty: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 45/57] uio: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 46/57] usb: " Stephen Boyd 2019-08-08 12:40 ` Felipe Balbi 2019-07-30 18:15 ` [PATCH v6 47/57] video: " Stephen Boyd 2019-07-30 18:15 ` Stephen Boyd 2020-01-03 11:29 ` Bartlomiej Zolnierkiewicz 2020-01-03 11:29 ` Bartlomiej Zolnierkiewicz 2020-01-03 11:29 ` Bartlomiej Zolnierkiewicz 2019-07-30 18:15 ` [PATCH v6 48/57] watchdog: " Stephen Boyd 2019-07-30 18:41 ` Guenter Roeck 2019-07-30 18:15 ` [PATCH v6 49/57] ASoC: " Stephen Boyd 2019-08-02 11:21 ` Applied "ASoC: Remove dev_err() usage after platform_get_irq()" to the asoc tree Mark Brown 2019-08-02 11:21 ` Mark Brown 2019-07-30 18:15 ` [PATCH v6 50/57] gpu: Remove dev_err() usage after platform_get_irq() Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 51/57] net: " Stephen Boyd 2019-07-30 21:25 ` David Miller 2019-07-30 18:15 ` [PATCH v6 52/57] platform/x86: intel_pmc_ipc: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 53/57] platform/mellanox: mlxreg-hotplug: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 54/57] platform/x86: intel_bxtwc_tmu: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 55/57] platform/x86: intel_int0002_vgpio: " Stephen Boyd 2019-08-01 15:11 ` Andy Shevchenko 2019-07-30 18:15 ` [PATCH v6 56/57] scsi: " Stephen Boyd 2019-07-30 18:15 ` [PATCH v6 57/57] ALSA: x86: " Stephen Boyd 2019-07-31 8:23 ` [PATCH v6 00/57] Add error message to platform_get_irq*() Markus Elfring 2019-07-31 8:23 ` [Cocci] " Markus Elfring 2019-07-31 8:23 ` Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190730181557.90391-8-swboyd@chromium.org \ --to=swboyd@chromium.org \ --cc=gregkh@linuxfoundation.org \ --cc=horms+renesas@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=maxime.ripard@bootlin.com \ --cc=shawnguo@kernel.org \ --cc=tony@atomide.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.