* [PATCH] multipath-tools: reorder NVDISK devices
@ 2019-08-01 17:21 Xose Vazquez Perez
2019-08-14 15:41 ` Benjamin Marzinski
0 siblings, 1 reply; 3+ messages in thread
From: Xose Vazquez Perez @ 2019-08-01 17:21 UTC (permalink / raw)
Cc: Brian King, DM-DEVEL ML, Xose Vazquez Perez
Otherwise "3303[ ]+NVDISK" is never reached, because "NVDISK" regex takes
priority over it.
Cc: Brian King <brking@linux.vnet.ibm.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index a06872e..8209554 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -696,12 +696,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.no_path_retry = (300 / DEFAULT_CHECKINT),
},
- {
- /* 3303 NVDISK */
- .vendor = "IBM",
- .product = "3303[ ]+NVDISK",
- .no_path_retry = (300 / DEFAULT_CHECKINT),
- },
{
/* AIX NVDISK */
.vendor = "AIX",
@@ -712,6 +706,12 @@ static struct hwentry default_hw[] = {
.no_path_retry = (300 / DEFAULT_CHECKINT),
.prio_name = PRIO_ALUA,
},
+ {
+ /* 3303 NVDISK */
+ .vendor = "IBM",
+ .product = "3303[ ]+NVDISK",
+ .no_path_retry = (300 / DEFAULT_CHECKINT),
+ },
/*
* Lenovo
*/
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] multipath-tools: reorder NVDISK devices
2019-08-01 17:21 [PATCH] multipath-tools: reorder NVDISK devices Xose Vazquez Perez
@ 2019-08-14 15:41 ` Benjamin Marzinski
2019-08-19 15:45 ` Xose Vazquez Perez
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Marzinski @ 2019-08-14 15:41 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: Brian King, DM-DEVEL ML
On Thu, Aug 01, 2019 at 07:21:38PM +0200, Xose Vazquez Perez wrote:
> Otherwise "3303[ ]+NVDISK" is never reached, because "NVDISK" regex takes
> priority over it.
Huh? I don't understand why this is necessary. First off, with Martin's
hwentry code, all matching hardware entries are used, not just the
latest. But second, and more importantly, the AIX NVDISK entry won't
ever match the same disks as the IBM 3303[ ]+NVDISK, since they have
different vendors. Right?
-Ben
>
> Cc: Brian King <brking@linux.vnet.ibm.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/hwtable.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index a06872e..8209554 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -696,12 +696,6 @@ static struct hwentry default_hw[] = {
> .pgpolicy = MULTIBUS,
> .no_path_retry = (300 / DEFAULT_CHECKINT),
> },
> - {
> - /* 3303 NVDISK */
> - .vendor = "IBM",
> - .product = "3303[ ]+NVDISK",
> - .no_path_retry = (300 / DEFAULT_CHECKINT),
> - },
> {
> /* AIX NVDISK */
> .vendor = "AIX",
> @@ -712,6 +706,12 @@ static struct hwentry default_hw[] = {
> .no_path_retry = (300 / DEFAULT_CHECKINT),
> .prio_name = PRIO_ALUA,
> },
> + {
> + /* 3303 NVDISK */
> + .vendor = "IBM",
> + .product = "3303[ ]+NVDISK",
> + .no_path_retry = (300 / DEFAULT_CHECKINT),
> + },
> /*
> * Lenovo
> */
> --
> 2.21.0
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] multipath-tools: reorder NVDISK devices
2019-08-14 15:41 ` Benjamin Marzinski
@ 2019-08-19 15:45 ` Xose Vazquez Perez
0 siblings, 0 replies; 3+ messages in thread
From: Xose Vazquez Perez @ 2019-08-19 15:45 UTC (permalink / raw)
To: Benjamin Marzinski, Brian King, DM-DEVEL ML, Christophe Varoqui
On 8/14/19 5:41 PM, Benjamin Marzinski wrote:
> On Thu, Aug 01, 2019 at 07:21:38PM +0200, Xose Vazquez Perez wrote:
>> Otherwise "3303[ ]+NVDISK" is never reached, because "NVDISK" regex takes
>> priority over it.
>
> Huh? I don't understand why this is necessary. First off, with Martin's
> hwentry code, all matching hardware entries are used, not just the
> latest. But second, and more importantly, the AIX NVDISK entry won't
> ever match the same disks as the IBM 3303[ ]+NVDISK, since they have
> different vendors. Right?
Yes, you are right. I mixed badly IBM-AIX in my head.
I'm sorry for the noise.
Christophe, remove this patch from your queue.
Thanks.
>> Cc: Brian King <brking@linux.vnet.ibm.com>
>> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
>> Cc: DM-DEVEL ML <dm-devel@redhat.com>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>> ---
>> libmultipath/hwtable.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
>> index a06872e..8209554 100644
>> --- a/libmultipath/hwtable.c
>> +++ b/libmultipath/hwtable.c
>> @@ -696,12 +696,6 @@ static struct hwentry default_hw[] = {
>> .pgpolicy = MULTIBUS,
>> .no_path_retry = (300 / DEFAULT_CHECKINT),
>> },
>> - {
>> - /* 3303 NVDISK */
>> - .vendor = "IBM",
>> - .product = "3303[ ]+NVDISK",
>> - .no_path_retry = (300 / DEFAULT_CHECKINT),
>> - },
>> {
>> /* AIX NVDISK */
>> .vendor = "AIX",
>> @@ -712,6 +706,12 @@ static struct hwentry default_hw[] = {
>> .no_path_retry = (300 / DEFAULT_CHECKINT),
>> .prio_name = PRIO_ALUA,
>> },
>> + {
>> + /* 3303 NVDISK */
>> + .vendor = "IBM",
>> + .product = "3303[ ]+NVDISK",
>> + .no_path_retry = (300 / DEFAULT_CHECKINT),
>> + },
>> /*
>> * Lenovo
>> */
>> --
>> 2.21.0
>>
>> --
>> dm-devel mailing list
>> dm-devel@redhat.com
>> https://www.redhat.com/mailman/listinfo/dm-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-19 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-01 17:21 [PATCH] multipath-tools: reorder NVDISK devices Xose Vazquez Perez
2019-08-14 15:41 ` Benjamin Marzinski
2019-08-19 15:45 ` Xose Vazquez Perez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.