All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Gao Xiang <hsiangkao@aol.com>
Cc: Chao Yu <yuchao0@huawei.com>, Richard Weinberger <richard@nod.at>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-erofs@lists.ozlabs.org, Chao Yu <chao@kernel.org>,
	Miao Xie <miaoxie@huawei.com>, Fang Wei <fangwei1@huawei.com>,
	Gao Xiang <gaoxiang25@huawei.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()
Date: Sun, 18 Aug 2019 05:33:14 -0700	[thread overview]
Message-ID: <20190818123314.GA29733@bombadil.infradead.org> (raw)
In-Reply-To: <20190818032111.9862-1-hsiangkao@aol.com>

On Sun, Aug 18, 2019 at 11:21:11AM +0800, Gao Xiang wrote:
> +		if (dentry_page == ERR_PTR(-ENOMEM)) {
> +			errln("no memory to readdir of logical block %u of nid %llu",
> +			      i, EROFS_V(dir)->nid);

I don't think you need the error message.  If we get a memory allocation
failure, there's already going to be a lot of spew in the logs from the
mm system.  And if we do fail to allocate memory, we don't need to know
the logical block number or the nid -- it has nothiing to do with those;
the system simply ran out of memory.

> +			err = -ENOMEM;
> +			break;
> +		} else if (IS_ERR(dentry_page)) {
> +			errln("fail to readdir of logical block %u of nid %llu",
> +			      i, EROFS_V(dir)->nid);
> +			err = -EFSCORRUPTED;
> +			break;
> +		}
>  
>  		de = (struct erofs_dirent *)kmap(dentry_page);
>  
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: willy@infradead.org (Matthew Wilcox)
Subject: [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()
Date: Sun, 18 Aug 2019 05:33:14 -0700	[thread overview]
Message-ID: <20190818123314.GA29733@bombadil.infradead.org> (raw)
In-Reply-To: <20190818032111.9862-1-hsiangkao@aol.com>

On Sun, Aug 18, 2019@11:21:11AM +0800, Gao Xiang wrote:
> +		if (dentry_page == ERR_PTR(-ENOMEM)) {
> +			errln("no memory to readdir of logical block %u of nid %llu",
> +			      i, EROFS_V(dir)->nid);

I don't think you need the error message.  If we get a memory allocation
failure, there's already going to be a lot of spew in the logs from the
mm system.  And if we do fail to allocate memory, we don't need to know
the logical block number or the nid -- it has nothiing to do with those;
the system simply ran out of memory.

> +			err = -ENOMEM;
> +			break;
> +		} else if (IS_ERR(dentry_page)) {
> +			errln("fail to readdir of logical block %u of nid %llu",
> +			      i, EROFS_V(dir)->nid);
> +			err = -EFSCORRUPTED;
> +			break;
> +		}
>  
>  		de = (struct erofs_dirent *)kmap(dentry_page);
>  
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2019-08-18 12:33 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18  1:48 [PATCH] staging: erofs: fix an error handling in erofs_readdir() Gao Xiang
2019-08-18  1:48 ` Gao Xiang
2019-08-18  1:56 ` [PATCH v2] " Gao Xiang
2019-08-18  1:56   ` Gao Xiang
2019-08-18  2:20   ` Matthew Wilcox
2019-08-18  2:20     ` Matthew Wilcox
2019-08-18  2:32     ` Gao Xiang
2019-08-18  2:32       ` Gao Xiang
2019-08-18  2:53       ` Matthew Wilcox
2019-08-18  2:53         ` Matthew Wilcox
2019-08-18  3:01         ` Gao Xiang
2019-08-18  3:01           ` Gao Xiang
2019-08-18  3:18           ` [PATCH] " Gao Xiang
2019-08-18  3:18             ` Gao Xiang
2019-08-18 12:07             ` kbuild test robot
2019-08-18 12:07               ` kbuild test robot
2019-08-18 12:07               ` kbuild test robot
2019-08-18 13:17             ` kbuild test robot
2019-08-18 13:17               ` kbuild test robot
2019-08-18 13:17               ` kbuild test robot
2019-08-18 13:25               ` Gao Xiang
2019-08-18 13:25                 ` Gao Xiang
2019-08-20  6:50                 ` Philip Li
2019-08-20  6:50                   ` Philip Li
2019-08-20  6:50                   ` Philip Li
2019-08-20  6:50                   ` Gao Xiang
2019-08-20  6:50                     ` Gao Xiang
2019-08-20  6:50                     ` Gao Xiang
2019-08-20  6:58                     ` Li, Philip
2019-08-20  6:58                       ` Li, Philip
2019-08-20  6:58                       ` Li, Philip
2019-08-20  7:16                       ` Gao Xiang
2019-08-20  7:16                         ` Gao Xiang
2019-08-20  7:16                         ` Gao Xiang
2019-08-18  3:21           ` [PATCH v3 RESEND] " Gao Xiang
2019-08-18  3:21             ` Gao Xiang
2019-08-18  8:33             ` Richard Weinberger
2019-08-18  8:33               ` Richard Weinberger
2019-08-18  9:10               ` Gao Xiang
2019-08-18  9:10                 ` Gao Xiang
2019-08-18  9:18                 ` [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()y Gao Xiang
2019-08-18  9:18                   ` Gao Xiang
2019-08-18 11:52             ` [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir() Sasha Levin
2019-08-18 12:29             ` Chao Yu
2019-08-18 12:29               ` Chao Yu
2019-08-18 12:33             ` Matthew Wilcox [this message]
2019-08-18 12:33               ` Matthew Wilcox
2019-08-18 12:38               ` Gao Xiang
2019-08-18 12:38                 ` Gao Xiang
2019-08-18 12:54                 ` [PATCH v4] " Gao Xiang
2019-08-18 12:54                   ` Gao Xiang
2019-08-19  0:08                   ` Sasha Levin
2019-08-18 10:39         ` [PATCH v2] " Chao Yu
2019-08-18 10:39           ` Chao Yu
2019-08-18 10:52           ` Gao Xiang
2019-08-18 10:52             ` Gao Xiang
2019-08-18 12:28             ` Chao Yu
2019-08-18 12:28               ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190818123314.GA29733@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=chao@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=fangwei1@huawei.com \
    --cc=gaoxiang25@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsiangkao@aol.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.