* [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors
@ 2019-08-26 13:02 Simon Ser
2019-08-26 13:15 ` Ville Syrjälä
2019-08-26 14:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Simon Ser @ 2019-08-26 13:02 UTC (permalink / raw)
To: igt-dev
Comments say that a connector can only be forced if it's disconnected. This was
a wrong assumption which has been fixed, but the comments went out of sync.
Fixes: dc3a0934a177 ("tests/kms_hdmi_inject: Accept any HDMI connector")
Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_hdmi_inject.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index 521105062dad..d9ab4095b8c5 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -34,9 +34,9 @@
#define VDISPLAY_4K 2160
IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
- "expected results by forcing a disconnected HDMI "
- "connector with a known EDID and checking that the "
- "metadata exposed to user space matches.");
+ "expected results by forcing a HDMI connector "
+ "with a known EDID and checking that the metadata "
+ "exposed to user space matches.");
/**
* This collection of tests performs EDID and status injection tests. Injection
@@ -49,8 +49,6 @@ IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
* - 4K modes exposed via KMS
* - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
* entries in /proc/asound are verified.
- *
- * Injection is performed on a disconnected connector.
*/
/** get_connector: get the first disconnected HDMI connector */
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors
2019-08-26 13:02 [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors Simon Ser
@ 2019-08-26 13:15 ` Ville Syrjälä
2019-08-26 14:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2019-08-26 13:15 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
On Mon, Aug 26, 2019 at 04:02:38PM +0300, Simon Ser wrote:
> Comments say that a connector can only be forced if it's disconnected. This was
> a wrong assumption which has been fixed, but the comments went out of sync.
>
> Fixes: dc3a0934a177 ("tests/kms_hdmi_inject: Accept any HDMI connector")
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_hdmi_inject.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index 521105062dad..d9ab4095b8c5 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -34,9 +34,9 @@
> #define VDISPLAY_4K 2160
>
> IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
> - "expected results by forcing a disconnected HDMI "
> - "connector with a known EDID and checking that the "
> - "metadata exposed to user space matches.");
> + "expected results by forcing a HDMI connector "
> + "with a known EDID and checking that the metadata "
> + "exposed to user space matches.");
>
> /**
> * This collection of tests performs EDID and status injection tests. Injection
> @@ -49,8 +49,6 @@ IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
> * - 4K modes exposed via KMS
> * - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
> * entries in /proc/asound are verified.
> - *
> - * Injection is performed on a disconnected connector.
> */
>
> /** get_connector: get the first disconnected HDMI connector */
> --
> 2.23.0
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_hdmi_inject: update comments mentionning disconnected connectors
2019-08-26 13:02 [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors Simon Ser
2019-08-26 13:15 ` Ville Syrjälä
@ 2019-08-26 14:17 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-08-26 14:17 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/kms_hdmi_inject: update comments mentionning disconnected connectors
URL : https://patchwork.freedesktop.org/series/65795/
State : failure
== Summary ==
Series 65795 revision 1 was fully merged or fully failed: no git log
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-26 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-26 13:02 [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors Simon Ser
2019-08-26 13:15 ` Ville Syrjälä
2019-08-26 14:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.