All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch net-next] net: devlink: fix reporter dump dumpit
@ 2019-10-07  7:28 Jiri Pirko
  2019-10-07 13:09 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2019-10-07  7:28 UTC (permalink / raw)
  To: netdev; +Cc: davem, mlxsw

From: Jiri Pirko <jiri@mellanox.com>

In order for attrs to be prepared for reporter dump dumpit callback,
set GENL_DONT_VALIDATE_DUMP_STRICT instead of GENL_DONT_VALIDATE_DUMP.

Fixes: ee85da535fe3 ("devlink: have genetlink code to parse the attrs during dumpit"
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 net/core/devlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index 22f59461b0c1..eb0a22f05887 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -6176,7 +6176,8 @@ static const struct genl_ops devlink_nl_ops[] = {
 	},
 	{
 		.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET,
-		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.validate = GENL_DONT_VALIDATE_STRICT |
+			    GENL_DONT_VALIDATE_DUMP_STRICT,
 		.dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,
 		.flags = GENL_ADMIN_PERM,
 		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK |
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch net-next] net: devlink: fix reporter dump dumpit
  2019-10-07  7:28 [patch net-next] net: devlink: fix reporter dump dumpit Jiri Pirko
@ 2019-10-07 13:09 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-07 13:09 UTC (permalink / raw)
  To: jiri; +Cc: netdev, mlxsw

From: Jiri Pirko <jiri@resnulli.us>
Date: Mon,  7 Oct 2019 09:28:31 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> In order for attrs to be prepared for reporter dump dumpit callback,
> set GENL_DONT_VALIDATE_DUMP_STRICT instead of GENL_DONT_VALIDATE_DUMP.
> 
> Fixes: ee85da535fe3 ("devlink: have genetlink code to parse the attrs during dumpit"
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-07 13:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07  7:28 [patch net-next] net: devlink: fix reporter dump dumpit Jiri Pirko
2019-10-07 13:09 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.