[PATCH 0/2] Update adau7118 dt-bindings

[PATCH 0/2] Update adau7118 dt-bindings

[Nuno Sá]

This is a follow-up patch as requested by Rob. The dt-bindings patch for
this device was applied before Rob's review. Here is the link to the review:

https://lore.kernel.org/alsa-devel/20191010210850.GA20184@bogus/

Nuno Sá (2):
  dt-bindings: asoc: adau7118: Cleanup
  ASOC: adau7118: Change regulators id

 .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
 sound/soc/codecs/adau7118.c                   |  4 +--
 2 files changed, 12 insertions(+), 17 deletions(-)

-- 
2.23.0

[alsa-devel] [PATCH 0/2] Update adau7118 dt-bindings

[Nuno Sá]

This is a follow-up patch as requested by Rob. The dt-bindings patch for
this device was applied before Rob's review. Here is the link to the review:

https://lore.kernel.org/alsa-devel/20191010210850.GA20184@bogus/

Nuno Sá (2):
  dt-bindings: asoc: adau7118: Cleanup
  ASOC: adau7118: Change regulators id

 .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
 sound/soc/codecs/adau7118.c                   |  4 +--
 2 files changed, 12 insertions(+), 17 deletions(-)

-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Nuno Sá]

This changes are in accordance with the review done to this bindings.
This is a follow-up patch to 969d49b2cdc8.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
index cfcef602b3d9..c3f10afbdd6f 100644
--- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
+++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
@@ -26,13 +26,11 @@ properties:
   "#sound-dai-cells":
     const: 0
 
-  IOVDD-supply:
+  iovdd-supply:
     description: Digital Input/Output Power Supply.
-    $ref: "/schemas/types.yaml#/definitions/phandle"
 
-  DVDD-supply:
+  dvdd-supply:
     description: Internal Core Digital Power Supply.
-    $ref: "/schemas/types.yaml#/definitions/phandle"
 
   adi,decimation-ratio:
     description: |
@@ -58,23 +56,21 @@ properties:
 required:
   - "#sound-dai-cells"
   - compatible
-  - IOVDD-supply
-  - DVDD-supply
+  - iovdd-supply
+  - dvdd-supply
 
 examples:
   - |
-    i2c0 {
+    i2c {
         /* example with i2c support */
         #address-cells = <1>;
         #size-cells = <0>;
-        status = "okay";
-        adau7118_codec: adau7118-codec@14 {
+        adau7118_codec: audio-codec@14 {
                 compatible = "adi,adau7118";
                 reg = <14>;
                 #sound-dai-cells = <0>;
-                status = "okay";
-                IOVDD-supply = <&supply>;
-                DVDD-supply = <&supply>;
+                iovdd-supply = <&supply>;
+                dvdd-supply = <&supply>;
                 adi,pdm-clk-map = <1 1 0 0>;
                 adi,decimation-ratio = <16>;
         };
@@ -84,7 +80,6 @@ examples:
     adau7118_codec_hw: adau7118-codec-hw {
             compatible = "adi,adau7118";
             #sound-dai-cells = <0>;
-            status = "okay";
-            IOVDD-supply = <&supply>;
-            DVDD-supply = <&supply>;
+            iovdd-supply = <&supply>;
+            dvdd-supply = <&supply>;
     };
-- 
2.23.0

[alsa-devel] [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Nuno Sá]

This changes are in accordance with the review done to this bindings.
This is a follow-up patch to 969d49b2cdc8.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
index cfcef602b3d9..c3f10afbdd6f 100644
--- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
+++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
@@ -26,13 +26,11 @@ properties:
   "#sound-dai-cells":
     const: 0
 
-  IOVDD-supply:
+  iovdd-supply:
     description: Digital Input/Output Power Supply.
-    $ref: "/schemas/types.yaml#/definitions/phandle"
 
-  DVDD-supply:
+  dvdd-supply:
     description: Internal Core Digital Power Supply.
-    $ref: "/schemas/types.yaml#/definitions/phandle"
 
   adi,decimation-ratio:
     description: |
@@ -58,23 +56,21 @@ properties:
 required:
   - "#sound-dai-cells"
   - compatible
-  - IOVDD-supply
-  - DVDD-supply
+  - iovdd-supply
+  - dvdd-supply
 
 examples:
   - |
-    i2c0 {
+    i2c {
         /* example with i2c support */
         #address-cells = <1>;
         #size-cells = <0>;
-        status = "okay";
-        adau7118_codec: adau7118-codec@14 {
+        adau7118_codec: audio-codec@14 {
                 compatible = "adi,adau7118";
                 reg = <14>;
                 #sound-dai-cells = <0>;
-                status = "okay";
-                IOVDD-supply = <&supply>;
-                DVDD-supply = <&supply>;
+                iovdd-supply = <&supply>;
+                dvdd-supply = <&supply>;
                 adi,pdm-clk-map = <1 1 0 0>;
                 adi,decimation-ratio = <16>;
         };
@@ -84,7 +80,6 @@ examples:
     adau7118_codec_hw: adau7118-codec-hw {
             compatible = "adi,adau7118";
             #sound-dai-cells = <0>;
-            status = "okay";
-            IOVDD-supply = <&supply>;
-            DVDD-supply = <&supply>;
+            iovdd-supply = <&supply>;
+            dvdd-supply = <&supply>;
     };
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[PATCH 2/2] ASOC: adau7118: Change regulators id

[Nuno Sá]

Change the regulators id in accordance with b670e44fc3bd.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 sound/soc/codecs/adau7118.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/adau7118.c b/sound/soc/codecs/adau7118.c
index bf5a5d75f81a..841229dcbca1 100644
--- a/sound/soc/codecs/adau7118.c
+++ b/sound/soc/codecs/adau7118.c
@@ -463,14 +463,14 @@ static void adau7118_regulator_disable(void *data)
 
 static int adau7118_regulator_setup(struct adau7118_data *st)
 {
-	st->iovdd = devm_regulator_get(st->dev, "IOVDD");
+	st->iovdd = devm_regulator_get(st->dev, "iovdd");
 	if (IS_ERR(st->iovdd)) {
 		dev_err(st->dev, "Could not get iovdd: %ld\n",
 			PTR_ERR(st->iovdd));
 		return PTR_ERR(st->iovdd);
 	}
 
-	st->dvdd = devm_regulator_get(st->dev, "DVDD");
+	st->dvdd = devm_regulator_get(st->dev, "dvdd");
 	if (IS_ERR(st->dvdd)) {
 		dev_err(st->dev, "Could not get dvdd: %ld\n",
 			PTR_ERR(st->dvdd));
-- 
2.23.0

[alsa-devel] [PATCH 2/2] ASOC: adau7118: Change regulators id

[Nuno Sá]

Change the regulators id in accordance with b670e44fc3bd.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 sound/soc/codecs/adau7118.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/adau7118.c b/sound/soc/codecs/adau7118.c
index bf5a5d75f81a..841229dcbca1 100644
--- a/sound/soc/codecs/adau7118.c
+++ b/sound/soc/codecs/adau7118.c
@@ -463,14 +463,14 @@ static void adau7118_regulator_disable(void *data)
 
 static int adau7118_regulator_setup(struct adau7118_data *st)
 {
-	st->iovdd = devm_regulator_get(st->dev, "IOVDD");
+	st->iovdd = devm_regulator_get(st->dev, "iovdd");
 	if (IS_ERR(st->iovdd)) {
 		dev_err(st->dev, "Could not get iovdd: %ld\n",
 			PTR_ERR(st->iovdd));
 		return PTR_ERR(st->iovdd);
 	}
 
-	st->dvdd = devm_regulator_get(st->dev, "DVDD");
+	st->dvdd = devm_regulator_get(st->dev, "dvdd");
 	if (IS_ERR(st->dvdd)) {
 		dev_err(st->dev, "Could not get dvdd: %ld\n",
 			PTR_ERR(st->dvdd));
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

On Mon, Oct 21, 2019 at 04:08:15PM +0200, Nuno Sá wrote:
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [alsa-devel] [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 568 bytes --]

On Mon, Oct 21, 2019 at 04:08:15PM +0200, Nuno Sá wrote:
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Sa, Nuno]

Hi Mark,

On Mon, 2019-10-21 at 15:52 +0100, Mark Brown wrote:]
> 
> On Mon, Oct 21, 2019 at 04:08:15PM +0200, Nuno Sá wrote:
> > This changes are in accordance with the review done to this
> > bindings.
> > This is a follow-up patch to 969d49b2cdc8.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet
> access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

Noted, I won't use commit hashes like this anymore. Also, I saw that you
applied the patch already and just FYI, the patch:

b2d6ee753126 (origin/for-5.5) ASOC: adau7118: Change regulators id

is pointing to b670e44fc3bd in it's description which does not exist.

I see that descriptions like this can lead to this situations. Sorry about
this...

Regards,
Nuno Sá

Re: [alsa-devel] [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Sa, Nuno]

Hi Mark,

On Mon, 2019-10-21 at 15:52 +0100, Mark Brown wrote:]
> 
> On Mon, Oct 21, 2019 at 04:08:15PM +0200, Nuno Sá wrote:
> > This changes are in accordance with the review done to this
> > bindings.
> > This is a follow-up patch to 969d49b2cdc8.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet
> access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

Noted, I won't use commit hashes like this anymore. Also, I saw that you
applied the patch already and just FYI, the patch:

b2d6ee753126 (origin/for-5.5) ASOC: adau7118: Change regulators id

is pointing to b670e44fc3bd in it's description which does not exist.

I see that descriptions like this can lead to this situations. Sorry about
this...

Regards,
Nuno Sá
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Rob Herring]

On Mon, Oct 21, 2019 at 9:08 AM Nuno Sá <nuno.sa@analog.com> wrote:
>
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
>  1 file changed, 10 insertions(+), 15 deletions(-)

Still some issues here...

>
> diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> index cfcef602b3d9..c3f10afbdd6f 100644
> --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> @@ -26,13 +26,11 @@ properties:
>    "#sound-dai-cells":
>      const: 0
>
> -  IOVDD-supply:
> +  iovdd-supply:
>      description: Digital Input/Output Power Supply.
> -    $ref: "/schemas/types.yaml#/definitions/phandle"
>
> -  DVDD-supply:
> +  dvdd-supply:
>      description: Internal Core Digital Power Supply.
> -    $ref: "/schemas/types.yaml#/definitions/phandle"
>
>    adi,decimation-ratio:
>      description: |
> @@ -58,23 +56,21 @@ properties:
>  required:
>    - "#sound-dai-cells"
>    - compatible
> -  - IOVDD-supply
> -  - DVDD-supply
> +  - iovdd-supply
> +  - dvdd-supply
>
>  examples:
>    - |
> -    i2c0 {
> +    i2c {
>          /* example with i2c support */
>          #address-cells = <1>;
>          #size-cells = <0>;
> -        status = "okay";
> -        adau7118_codec: adau7118-codec@14 {
> +        adau7118_codec: audio-codec@14 {

Documentation/devicetree/bindings/sound/adi,adau7118.example.dts:21.44-29.15:
Warning (i2c_bus_reg): /example-0/i2c/audio-codec@14: I2C bus unit
address format error, expected "e"

Unit-address should be in hex.

>                  compatible = "adi,adau7118";
>                  reg = <14>;
>                  #sound-dai-cells = <0>;
> -                status = "okay";
> -                IOVDD-supply = <&supply>;
> -                DVDD-supply = <&supply>;
> +                iovdd-supply = <&supply>;
> +                dvdd-supply = <&supply>;
>                  adi,pdm-clk-map = <1 1 0 0>;
>                  adi,decimation-ratio = <16>;
>          };
> @@ -84,7 +80,6 @@ examples:
>      adau7118_codec_hw: adau7118-codec-hw {
>              compatible = "adi,adau7118";
>              #sound-dai-cells = <0>;
> -            status = "okay";
> -            IOVDD-supply = <&supply>;
> -            DVDD-supply = <&supply>;
> +            iovdd-supply = <&supply>;
> +            dvdd-supply = <&supply>;
>      };
> --
> 2.23.0
>

Re: [alsa-devel] [PATCH 1/2] dt-bindings: asoc: adau7118: Cleanup

[Rob Herring]

On Mon, Oct 21, 2019 at 9:08 AM Nuno Sá <nuno.sa@analog.com> wrote:
>
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
>  1 file changed, 10 insertions(+), 15 deletions(-)

Still some issues here...

>
> diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> index cfcef602b3d9..c3f10afbdd6f 100644
> --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> @@ -26,13 +26,11 @@ properties:
>    "#sound-dai-cells":
>      const: 0
>
> -  IOVDD-supply:
> +  iovdd-supply:
>      description: Digital Input/Output Power Supply.
> -    $ref: "/schemas/types.yaml#/definitions/phandle"
>
> -  DVDD-supply:
> +  dvdd-supply:
>      description: Internal Core Digital Power Supply.
> -    $ref: "/schemas/types.yaml#/definitions/phandle"
>
>    adi,decimation-ratio:
>      description: |
> @@ -58,23 +56,21 @@ properties:
>  required:
>    - "#sound-dai-cells"
>    - compatible
> -  - IOVDD-supply
> -  - DVDD-supply
> +  - iovdd-supply
> +  - dvdd-supply
>
>  examples:
>    - |
> -    i2c0 {
> +    i2c {
>          /* example with i2c support */
>          #address-cells = <1>;
>          #size-cells = <0>;
> -        status = "okay";
> -        adau7118_codec: adau7118-codec@14 {
> +        adau7118_codec: audio-codec@14 {

Documentation/devicetree/bindings/sound/adi,adau7118.example.dts:21.44-29.15:
Warning (i2c_bus_reg): /example-0/i2c/audio-codec@14: I2C bus unit
address format error, expected "e"

Unit-address should be in hex.

>                  compatible = "adi,adau7118";
>                  reg = <14>;
>                  #sound-dai-cells = <0>;
> -                status = "okay";
> -                IOVDD-supply = <&supply>;
> -                DVDD-supply = <&supply>;
> +                iovdd-supply = <&supply>;
> +                dvdd-supply = <&supply>;
>                  adi,pdm-clk-map = <1 1 0 0>;
>                  adi,decimation-ratio = <16>;
>          };
> @@ -84,7 +80,6 @@ examples:
>      adau7118_codec_hw: adau7118-codec-hw {
>              compatible = "adi,adau7118";
>              #sound-dai-cells = <0>;
> -            status = "okay";
> -            IOVDD-supply = <&supply>;
> -            DVDD-supply = <&supply>;
> +            iovdd-supply = <&supply>;
> +            dvdd-supply = <&supply>;
>      };
> --
> 2.23.0
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel