All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable
@ 2019-10-23 21:50 José Roberto de Souza
  2019-10-23 21:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function José Roberto de Souza
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: José Roberto de Souza @ 2019-10-23 21:50 UTC (permalink / raw)
  To: igt-dev; +Cc: Ap Kamal, Dhinakaran Pandiyan, Rodrigo Vivi

Right now if sink reported any PSR error or if it fails to
acknowledge the PSR wakeup it sets a flag and do not attempt to
enable PSR anymore. That is the safest approach to avoid repetitive
glitches and allowed us to have PSR enabled by default.

But from time to time even good PSR panels have a PSR error, causing
tests to fail. And for now we are not yet to the point were we could
try to recover from PSR errors, so lets check for this information in
debugfs and skip PSR tests because of sink errors and eliminate this
noise from CI runs.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Ap Kamal <kamal.ap@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 lib/igt_psr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index b92ea73f..0e79dcd9 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -33,6 +33,8 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
 	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
 				sizeof(buf));
 
+	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
+
 	return strstr(buf, state);
 }
 
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function
  2019-10-23 21:50 [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable José Roberto de Souza
@ 2019-10-23 21:50 ` José Roberto de Souza
  2019-10-23 22:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: José Roberto de Souza @ 2019-10-23 21:50 UTC (permalink / raw)
  To: igt-dev

This function is a left-over from some versions of the patches
preparing igt_psr for PSR2 tests and it is not needed.

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 lib/igt_psr.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index 0e79dcd9..6d192689 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -38,11 +38,6 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
 	return strstr(buf, state);
 }
 
-static inline const char *psr_active_state_get(enum psr_mode mode)
-{
-	return mode == PSR_MODE_1 ? "SRDENT" : "DEEP_SLEEP";
-}
-
 /*
  * For PSR1, we wait until PSR is active. We wait until DEEP_SLEEP for PSR2.
  */
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable
  2019-10-23 21:50 [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable José Roberto de Souza
  2019-10-23 21:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function José Roberto de Souza
@ 2019-10-23 22:33 ` Patchwork
  2019-10-24 15:00 ` [igt-dev] [PATCH i-g-t 1/2] " Matt Roper
  2019-10-24 18:05 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-23 22:33 UTC (permalink / raw)
  To: José Roberto de Souza; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable
URL   : https://patchwork.freedesktop.org/series/68483/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7165 -> IGTPW_3601
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/index.html

Known issues
------------

  Here are the changes found in IGTPW_3601 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-8109u:       [PASS][1] -> [DMESG-FAIL][2] ([fdo#112050 ])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-icl-u3:          [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html

  
#### Possible fixes ####

  * igt@gem_busy@busy-all:
    - fi-icl-u3:          [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-icl-u3/igt@gem_busy@busy-all.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-icl-u3/igt@gem_busy@busy-all.html

  * igt@gem_ctx_create@basic-files:
    - fi-bxt-dsi:         [INCOMPLETE][7] ([fdo#103927]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
    - {fi-tgl-u2}:        [INCOMPLETE][9] ([fdo#111735]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-tgl-u2/igt@gem_ctx_create@basic-files.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-tgl-u2/igt@gem_ctx_create@basic-files.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-icl-u2:          [FAIL][11] ([fdo#109483]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-kbl-7500u:       [FAIL][13] ([fdo#103375]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-kbl-7500u/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-kbl-7500u/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
#### Warnings ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][15] ([fdo#111407]) -> [FAIL][16] ([fdo#111045] / [fdo#111096])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#112050 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112050 


Participating hosts (51 -> 43)
------------------------------

  Additional (1): fi-bwr-2160 
  Missing    (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5236 -> IGTPW_3601

  CI-20190529: 20190529
  CI_DRM_7165: b50cc0bc0f669a3c3ead36573496596b8b8ed8f4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3601: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/index.html
  IGT_5236: 8153b95b53bdef26d2c3e318197d174e982b4265 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable
  2019-10-23 21:50 [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable José Roberto de Souza
  2019-10-23 21:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function José Roberto de Souza
  2019-10-23 22:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable Patchwork
@ 2019-10-24 15:00 ` Matt Roper
  2019-10-24 23:15   ` Souza, Jose
  2019-10-24 18:05 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
  3 siblings, 1 reply; 6+ messages in thread
From: Matt Roper @ 2019-10-24 15:00 UTC (permalink / raw)
  To: José Roberto de Souza
  Cc: igt-dev, Ap Kamal, Dhinakaran Pandiyan, Rodrigo Vivi

On Wed, Oct 23, 2019 at 02:50:30PM -0700, José Roberto de Souza wrote:
> Right now if sink reported any PSR error or if it fails to
> acknowledge the PSR wakeup it sets a flag and do not attempt to
> enable PSR anymore. That is the safest approach to avoid repetitive
> glitches and allowed us to have PSR enabled by default.
> 
> But from time to time even good PSR panels have a PSR error, causing
> tests to fail. And for now we are not yet to the point were we could
> try to recover from PSR errors, so lets check for this information in
> debugfs and skip PSR tests because of sink errors and eliminate this
> noise from CI runs.
> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Ap Kamal <kamal.ap@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109454
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

and r-b for the i915 patch as well.


> ---
>  lib/igt_psr.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index b92ea73f..0e79dcd9 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -33,6 +33,8 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
>  	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
>  				sizeof(buf));
>  
> +	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
> +
>  	return strstr(buf, state);
>  }
>  
> -- 
> 2.23.0
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable
  2019-10-23 21:50 [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable José Roberto de Souza
                   ` (2 preceding siblings ...)
  2019-10-24 15:00 ` [igt-dev] [PATCH i-g-t 1/2] " Matt Roper
@ 2019-10-24 18:05 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-24 18:05 UTC (permalink / raw)
  To: José Roberto de Souza; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable
URL   : https://patchwork.freedesktop.org/series/68483/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7165_full -> IGTPW_3601_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3601_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3601_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3601_full:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rps@reset:
    - shard-iclb:         [PASS][1] -> [SKIP][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb7/igt@i915_pm_rps@reset.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb8/igt@i915_pm_rps@reset.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_pm_rps@reset:
    - {shard-tglb}:       [FAIL][3] ([fdo#102250]) -> [SKIP][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-tglb1/igt@i915_pm_rps@reset.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-tglb2/igt@i915_pm_rps@reset.html

  * {igt@i915_selftest@live_gt_heartbeat}:
    - shard-glk:          [PASS][5] -> [DMESG-FAIL][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-glk2/igt@i915_selftest@live_gt_heartbeat.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-glk8/igt@i915_selftest@live_gt_heartbeat.html

  
Known issues
------------

  Here are the changes found in IGTPW_3601_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#110841])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_ctx_switch@vcs1-heavy-queue:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#112080]) +6 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb2/igt@gem_ctx_switch@vcs1-heavy-queue.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb5/igt@gem_ctx_switch@vcs1-heavy-queue.html

  * igt@gem_eio@in-flight-internal-10ms:
    - shard-hsw:          [PASS][11] -> [SKIP][12] ([fdo#109271]) +8 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-hsw2/igt@gem_eio@in-flight-internal-10ms.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-hsw1/igt@gem_eio@in-flight-internal-10ms.html

  * igt@gem_exec_schedule@fifo-bsd1:
    - shard-iclb:         [PASS][13] -> [SKIP][14] ([fdo#109276]) +14 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb6/igt@gem_exec_schedule@fifo-bsd1.html

  * igt@gem_exec_schedule@preempt-hang-bsd:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#111325])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb8/igt@gem_exec_schedule@preempt-hang-bsd.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb1/igt@gem_exec_schedule@preempt-hang-bsd.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-hsw:          [PASS][17] -> [DMESG-WARN][18] ([fdo#111870]) +4 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-hsw4/igt@gem_userptr_blits@sync-unmap-after-close.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [PASS][19] -> [DMESG-WARN][20] ([fdo#111870]) +4 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_hangman@error-state-capture-vcs0:
    - shard-snb:          [PASS][21] -> [SKIP][22] ([fdo#109271]) +4 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-snb2/igt@i915_hangman@error-state-capture-vcs0.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-snb1/igt@i915_hangman@error-state-capture-vcs0.html

  * igt@i915_pm_rps@reset:
    - shard-apl:          [PASS][23] -> [SKIP][24] ([fdo#109271]) +3 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl2/igt@i915_pm_rps@reset.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl3/igt@i915_pm_rps@reset.html

  * igt@i915_selftest@live_hangcheck:
    - shard-hsw:          [PASS][25] -> [DMESG-FAIL][26] ([fdo#111991])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-hsw5/igt@i915_selftest@live_hangcheck.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-hsw8/igt@i915_selftest@live_hangcheck.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-apl:          [PASS][27] -> [DMESG-WARN][28] ([fdo#108566])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt:
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103167]) +2 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][31] -> [FAIL][32] ([fdo#108341])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb8/igt@kms_psr@no_drrs.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109441])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-glk:          [PASS][35] -> [FAIL][36] ([fdo#99912])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-glk3/igt@kms_setmode@basic.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-glk4/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-query-idle-hang:
    - shard-kbl:          [PASS][37] -> [SKIP][38] ([fdo#109271]) +6 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl1/igt@kms_vblank@pipe-a-query-idle-hang.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl3/igt@kms_vblank@pipe-a-query-idle-hang.html
    - shard-glk:          [PASS][39] -> [SKIP][40] ([fdo#109271]) +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-glk8/igt@kms_vblank@pipe-a-query-idle-hang.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-glk5/igt@kms_vblank@pipe-a-query-idle-hang.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +6 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vcs1-clean:
    - shard-iclb:         [SKIP][43] ([fdo#109276] / [fdo#112080]) -> [PASS][44] +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb7/igt@gem_ctx_isolation@vcs1-clean.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html

  * igt@gem_exec_schedule@preempt-hang-blt:
    - {shard-tglb}:       [SKIP][45] ([fdo#111602]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-tglb8/igt@gem_exec_schedule@preempt-hang-blt.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-tglb6/igt@gem_exec_schedule@preempt-hang-blt.html
    - shard-iclb:         [SKIP][47] ([fdo#112118]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb1/igt@gem_exec_schedule@preempt-hang-blt.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb3/igt@gem_exec_schedule@preempt-hang-blt.html
    - shard-glk:          [SKIP][49] ([fdo#109271]) -> [PASS][50] +2 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-glk6/igt@gem_exec_schedule@preempt-hang-blt.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-glk4/igt@gem_exec_schedule@preempt-hang-blt.html
    - shard-apl:          [SKIP][51] ([fdo#109271]) -> [PASS][52] +2 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl6/igt@gem_exec_schedule@preempt-hang-blt.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl7/igt@gem_exec_schedule@preempt-hang-blt.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][53] ([fdo#111325]) -> [PASS][54] +7 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_linear_blits@interruptible:
    - shard-apl:          [INCOMPLETE][55] ([fdo#103927] / [fdo#112067]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl8/igt@gem_linear_blits@interruptible.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl3/igt@gem_linear_blits@interruptible.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-kbl:          [FAIL][57] ([fdo#112037]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-hsw:          [DMESG-WARN][59] ([fdo#111870]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-snb:          [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62] +2 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@i915_hangman@error-state-basic:
    - shard-hsw:          [SKIP][63] ([fdo#109271]) -> [PASS][64] +5 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-hsw6/igt@i915_hangman@error-state-basic.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-hsw2/igt@i915_hangman@error-state-basic.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - {shard-tglb}:       [INCOMPLETE][65] ([fdo#111832] / [fdo#111850]) -> [PASS][66] +2 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-tglb8/igt@i915_suspend@fence-restore-tiled2untiled.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
    - shard-snb:          [SKIP][67] ([fdo#109271]) -> [PASS][68] +2 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-snb5/igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-snb5/igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b.html
    - shard-iclb:         [SKIP][69] ([fdo#109278]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb1/igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb1/igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b.html

  * igt@kms_color@pipe-b-degamma:
    - shard-kbl:          [FAIL][71] ([fdo#104782]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl6/igt@kms_color@pipe-b-degamma.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl1/igt@kms_color@pipe-b-degamma.html
    - shard-apl:          [FAIL][73] ([fdo#104782]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl1/igt@kms_color@pipe-b-degamma.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl3/igt@kms_color@pipe-b-degamma.html

  * igt@kms_cursor_crc@pipe-a-cursor-dpms:
    - shard-snb:          [DMESG-WARN][75] ([fdo#111891]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-dpms.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][77] ([fdo#108566]) -> [PASS][78] +6 similar issues
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding:
    - shard-apl:          [FAIL][79] ([fdo#103232]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html
    - shard-kbl:          [FAIL][81] ([fdo#103232]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - shard-apl:          [INCOMPLETE][83] ([fdo#103927]) -> [PASS][84] +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_flip@2x-plain-flip-interruptible:
    - shard-hsw:          [DMESG-WARN][85] ([fdo#111891]) -> [PASS][86]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-hsw6/igt@kms_flip@2x-plain-flip-interruptible.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-hsw5/igt@kms_flip@2x-plain-flip-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - {shard-tglb}:       [FAIL][87] ([fdo#103167]) -> [PASS][88] +6 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
    - shard-iclb:         [FAIL][89] ([fdo#103167]) -> [PASS][90] +2 similar issues
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-apl:          [DMESG-WARN][91] ([fdo#108566]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [SKIP][93] ([fdo#109642] / [fdo#111068]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb2/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][95] ([fdo#109441]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
    - shard-kbl:          [SKIP][97] ([fdo#109271]) -> [PASS][98] +4 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
    - {shard-tglb}:       [SKIP][99] ([fdo#112015]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-tglb8/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-tglb1/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html

  * igt@perf_pmu@busy-accuracy-2-vcs1:
    - shard-iclb:         [SKIP][101] ([fdo#112080]) -> [PASS][102] +8 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb8/igt@perf_pmu@busy-accuracy-2-vcs1.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb2/igt@perf_pmu@busy-accuracy-2-vcs1.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [SKIP][103] ([fdo#109276]) -> [PASS][104] +8 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb8/igt@prime_busy@hang-bsd2.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb4/igt@prime_busy@hang-bsd2.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [FAIL][105] ([fdo#111329]) -> [SKIP][106] ([fdo#109276] / [fdo#112080])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_mocs_settings@mocs-isolation-bsd2:
    - shard-iclb:         [FAIL][107] ([fdo#111330]) -> [SKIP][108] ([fdo#109276])
   [107]: https://intel-gfx-ci.01

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3601/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable
  2019-10-24 15:00 ` [igt-dev] [PATCH i-g-t 1/2] " Matt Roper
@ 2019-10-24 23:15   ` Souza, Jose
  0 siblings, 0 replies; 6+ messages in thread
From: Souza, Jose @ 2019-10-24 23:15 UTC (permalink / raw)
  To: Roper, Matthew D; +Cc: igt-dev, Ap, Kamal, Pandiyan, Dhinakaran, Vivi, Rodrigo

On Thu, 2019-10-24 at 08:00 -0700, Matt Roper wrote:
> On Wed, Oct 23, 2019 at 02:50:30PM -0700, José Roberto de Souza
> wrote:
> > Right now if sink reported any PSR error or if it fails to
> > acknowledge the PSR wakeup it sets a flag and do not attempt to
> > enable PSR anymore. That is the safest approach to avoid repetitive
> > glitches and allowed us to have PSR enabled by default.
> > 
> > But from time to time even good PSR panels have a PSR error,
> > causing
> > tests to fail. And for now we are not yet to the point were we
> > could
> > try to recover from PSR errors, so lets check for this information
> > in
> > debugfs and skip PSR tests because of sink errors and eliminate
> > this
> > noise from CI runs.
> > 
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Ap Kamal <kamal.ap@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109454
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

Added and pushed

Thanks

> 
> and r-b for the i915 patch as well.
> 
> 
> > ---
> >  lib/igt_psr.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> > index b92ea73f..0e79dcd9 100644
> > --- a/lib/igt_psr.c
> > +++ b/lib/igt_psr.c
> > @@ -33,6 +33,8 @@ static bool psr_active_check(int debugfs_fd, enum
> > psr_mode mode)
> >  	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
> >  				sizeof(buf));
> >  
> > +	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
> > +
> >  	return strstr(buf, state);
> >  }
> >  
> > -- 
> > 2.23.0
> > 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-24 23:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 21:50 [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable José Roberto de Souza
2019-10-23 21:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function José Roberto de Souza
2019-10-23 22:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable Patchwork
2019-10-24 15:00 ` [igt-dev] [PATCH i-g-t 1/2] " Matt Roper
2019-10-24 23:15   ` Souza, Jose
2019-10-24 18:05 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.