* [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
@ 2019-10-28 16:12 Michael S. Tsirkin
2019-11-24 12:29 ` Michael S. Tsirkin
2019-11-25 6:41 ` Jan Kiszka
0 siblings, 2 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-10-28 16:12 UTC (permalink / raw)
To: virtio, virtio-dev
If a hardware implementation of virtio does not have
the correct subsystem id, then drivers can't report
ir properly, or detect and work around bugs.
Change the requirement from MAY to SHOULD.
We can't make it a MUST since we did not require this
historically.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
content.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/content.tex b/content.tex
index 4bcb728..8f1518c 100644
--- a/content.tex
+++ b/content.tex
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
For example, the network card device with the Virtio Device ID 1
has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
Non-transitional devices SHOULD have a PCI Device ID in the range
--
MST
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
2019-10-28 16:12 [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id Michael S. Tsirkin
@ 2019-11-24 12:29 ` Michael S. Tsirkin
2019-11-25 6:41 ` Jan Kiszka
1 sibling, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-11-24 12:29 UTC (permalink / raw)
To: virtio-comment, virtio-dev; +Cc: virtio
On Mon, Oct 28, 2019 at 12:12:49PM -0400, Michael S. Tsirkin wrote:
> If a hardware implementation of virtio does not have
> the correct subsystem id, then drivers can't report
> ir properly, or detect and work around bugs.
> Change the requirement from MAY to SHOULD.
>
> We can't make it a MUST since we did not require this
> historically.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/61
> ---
> content.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/content.tex b/content.tex
> index 4bcb728..8f1518c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
> For example, the network card device with the Virtio Device ID 1
> has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
>
> -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
> the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
>
> Non-transitional devices SHOULD have a PCI Device ID in the range
> --
> MST
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this mail list, you must leave the OASIS TC that
> generates this mail. Follow this link to all your TCs in OASIS at:
> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
2019-10-28 16:12 [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id Michael S. Tsirkin
2019-11-24 12:29 ` Michael S. Tsirkin
@ 2019-11-25 6:41 ` Jan Kiszka
2019-11-25 8:22 ` Michael S. Tsirkin
1 sibling, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2019-11-25 6:41 UTC (permalink / raw)
To: Michael S. Tsirkin, virtio, virtio-dev
On 28.10.19 17:12, Michael S. Tsirkin wrote:
> If a hardware implementation of virtio does not have
> the correct subsystem id, then drivers can't report
> ir properly, or detect and work around bugs.
s/ir/it.
Jan
> Change the requirement from MAY to SHOULD.
>
> We can't make it a MUST since we did not require this
> historically.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> content.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/content.tex b/content.tex
> index 4bcb728..8f1518c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
> For example, the network card device with the Virtio Device ID 1
> has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
>
> -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
> the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
>
> Non-transitional devices SHOULD have a PCI Device ID in the range
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
2019-11-25 6:41 ` Jan Kiszka
@ 2019-11-25 8:22 ` Michael S. Tsirkin
2019-11-25 10:14 ` Cornelia Huck
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-11-25 8:22 UTC (permalink / raw)
To: Jan Kiszka; +Cc: virtio, virtio-dev
On Mon, Nov 25, 2019 at 07:41:09AM +0100, Jan Kiszka wrote:
> On 28.10.19 17:12, Michael S. Tsirkin wrote:
> > If a hardware implementation of virtio does not have
> > the correct subsystem id, then drivers can't report
> > ir properly, or detect and work around bugs.
>
> s/ir/it.
>
> Jan
>
> > Change the requirement from MAY to SHOULD.
> >
> > We can't make it a MUST since we did not require this
> > historically.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
One thing I noticed is that for transitional devices, windows drivers
bind to a specific vendor id. I guess we need to make this
SHOULD for non-transitional only?
> > ---
> > content.tex | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/content.tex b/content.tex
> > index 4bcb728..8f1518c 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
> > For example, the network card device with the Virtio Device ID 1
> > has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
> > -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> > +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
> > the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
> > Non-transitional devices SHOULD have a PCI Device ID in the range
> >
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
2019-11-25 8:22 ` Michael S. Tsirkin
@ 2019-11-25 10:14 ` Cornelia Huck
2019-11-27 13:02 ` [virtio] Re: [virtio-dev] " Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Cornelia Huck @ 2019-11-25 10:14 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Jan Kiszka, virtio, virtio-dev
On Mon, 25 Nov 2019 03:22:13 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Nov 25, 2019 at 07:41:09AM +0100, Jan Kiszka wrote:
> > On 28.10.19 17:12, Michael S. Tsirkin wrote:
> > > If a hardware implementation of virtio does not have
> > > the correct subsystem id, then drivers can't report
> > > ir properly, or detect and work around bugs.
> >
> > s/ir/it.
> >
> > Jan
> >
> > > Change the requirement from MAY to SHOULD.
> > >
> > > We can't make it a MUST since we did not require this
> > > historically.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> One thing I noticed is that for transitional devices, windows drivers
> bind to a specific vendor id. I guess we need to make this
> SHOULD for non-transitional only?
So, they have different binding behaviour for transitional vs
non-transitional devices? Or transitional vs non-transitional drivers?
>
>
> > > ---
> > > content.tex | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/content.tex b/content.tex
> > > index 4bcb728..8f1518c 100644
> > > --- a/content.tex
> > > +++ b/content.tex
> > > @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
> > > For example, the network card device with the Virtio Device ID 1
> > > has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
> > > -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> > > +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
> > > the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
> > > Non-transitional devices SHOULD have a PCI Device ID in the range
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply [flat|nested] 6+ messages in thread
* [virtio] Re: [virtio-dev] Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
2019-11-25 10:14 ` Cornelia Huck
@ 2019-11-27 13:02 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-11-27 13:02 UTC (permalink / raw)
To: Cornelia Huck; +Cc: Jan Kiszka, virtio, virtio-dev
On Mon, Nov 25, 2019 at 11:14:20AM +0100, Cornelia Huck wrote:
> On Mon, 25 Nov 2019 03:22:13 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Mon, Nov 25, 2019 at 07:41:09AM +0100, Jan Kiszka wrote:
> > > On 28.10.19 17:12, Michael S. Tsirkin wrote:
> > > > If a hardware implementation of virtio does not have
> > > > the correct subsystem id, then drivers can't report
> > > > ir properly, or detect and work around bugs.
> > >
> > > s/ir/it.
> > >
> > > Jan
> > >
> > > > Change the requirement from MAY to SHOULD.
> > > >
> > > > We can't make it a MUST since we did not require this
> > > > historically.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> >
> > One thing I noticed is that for transitional devices, windows drivers
> > bind to a specific vendor id. I guess we need to make this
> > SHOULD for non-transitional only?
>
> So, they have different binding behaviour for transitional vs
> non-transitional devices? Or transitional vs non-transitional drivers?
Transitional vs non-transitional have different IDs, sure.
That's in the spec.
> >
> >
> > > > ---
> > > > content.tex | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/content.tex b/content.tex
> > > > index 4bcb728..8f1518c 100644
> > > > --- a/content.tex
> > > > +++ b/content.tex
> > > > @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
> > > > For example, the network card device with the Virtio Device ID 1
> > > > has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
> > > > -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> > > > +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
> > > > the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
> > > > Non-transitional devices SHOULD have a PCI Device ID in the range
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-27 13:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 16:12 [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id Michael S. Tsirkin
2019-11-24 12:29 ` Michael S. Tsirkin
2019-11-25 6:41 ` Jan Kiszka
2019-11-25 8:22 ` Michael S. Tsirkin
2019-11-25 10:14 ` Cornelia Huck
2019-11-27 13:02 ` [virtio] Re: [virtio-dev] " Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.