* [PATCH] netlink: fix double drop dev reference
@ 2019-11-06 12:05 Pan Bian
2019-11-07 5:19 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2019-11-06 12:05 UTC (permalink / raw)
To: David S. Miller, Johannes Berg, Andrey Konovalov,
Jilayne Lovejoy, Steve Winslow, Michal Kubecek, Thomas Gleixner,
Young Xiao
Cc: netdev, linux-kernel, Pan Bian
The function nfc_put_device(dev) is called twice to drop the reference
to dev when there is no associated local llcp. Remove one of them to fix
the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
net/nfc/netlink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 17e6ca62f1be..afde0d763039 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1099,7 +1099,6 @@ static int nfc_genl_llc_set_params(struct sk_buff *skb, struct genl_info *info)
local = nfc_llcp_find_local(dev);
if (!local) {
- nfc_put_device(dev);
rc = -ENODEV;
goto exit;
}
@@ -1159,7 +1158,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
local = nfc_llcp_find_local(dev);
if (!local) {
- nfc_put_device(dev);
rc = -ENODEV;
goto exit;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netlink: fix double drop dev reference
2019-11-06 12:05 [PATCH] netlink: fix double drop dev reference Pan Bian
@ 2019-11-07 5:19 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-07 5:19 UTC (permalink / raw)
To: bianpan2016
Cc: johannes.berg, andreyknvl, opensource, swinslow, mkubecek, tglx,
92siuyang, netdev, linux-kernel
From: Pan Bian <bianpan2016@163.com>
Date: Wed, 6 Nov 2019 20:05:43 +0800
> The function nfc_put_device(dev) is called twice to drop the reference
> to dev when there is no associated local llcp. Remove one of them to fix
> the bug.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
This is a change to the nfc subsystem not to the netlink subsystem,
therefore the appropriate subsystem prefix is "nfc: " and probably
therefore:
Subject: [PATCH] nfc: Fix double device reference drop in netlink code.
or something like that.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-07 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 12:05 [PATCH] netlink: fix double drop dev reference Pan Bian
2019-11-07 5:19 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.