Re: s390/pkey: Use memdup_user() rather than duplicating its implementation

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
	Joe Perches <joe@perches.com>,
	linux-s390@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Harald Freudenberger <freude@linux.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Ingo Franzki <ifranzki@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: s390/pkey: Use memdup_user() rather than duplicating its implementation
Date: Thu, 7 Nov 2019 09:48:54 +0300	[thread overview]
Message-ID: <20191107064854.GM10409@kadam> (raw)
In-Reply-To: <a4eaf80e-a5dd-4da3-75ca-8231f01af193@de.ibm.com>

On Wed, Nov 06, 2019 at 07:30:19PM +0100, Christian Borntraeger wrote:
> 
> 
> On 06.11.19 14:00, Markus Elfring wrote:
> >>> Reuse existing functionality from memdup_user() instead of keeping
> >>> duplicate source code.
> >>>
> >>> Generated by: scripts/coccinelle/api/memdup_user.cocci
> > …
> >>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
> >>
> >> This doesn't fix anything
> > 
> > How would you categorise the proposed source code reduction and software reuse?
> 
> Cleanup.
> 
> Can you please stop arguing about review feedback that is clearly right? This is not fixing 
> anything. The Fixes tag is used to decide if something needs a backport.

Fixes tags are independent from backports.  If you want a backport you
should CC stable.

Fixes tags are useful for a bunch of things like when you're reviewing a
patch you can look at the original commit to see what was intended.
Also we can do automated analysis to see what sort of commits introduce
bugs (did they spend time in linux-next etc).

regards,
dan carpenter