From: Tony Lindgren <tony@atomide.com> To: "H. Nikolaus Schaller" <hns@goldelico.com> Cc: "Rob Herring" <robh+dt@kernel.org>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel@ffwll.ch>, "Mark Rutland" <mark.rutland@arm.com>, "Benoît Cousson" <bcousson@baylibre.com>, "Paul Cercueil" <paul@crapouillou.net>, "Ralf Baechle" <ralf@linux-mips.org>, "Paul Burton" <paulburton@kernel.org>, "James Hogan" <jhogan@kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, devicetree <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-omap <linux-omap@vger.kernel.org>, "OpenPVRSGX Linux Driver Group" <openpvrsgx-devgroup@letux.org>, "Discussions about the Letux Kernel" <letux-kernel@openphoenux.org>, kernel@pyra-handheld.com, "open list:MIPS" <linux-mips@vger.kernel.org> Subject: Re: [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml for Imagination GPUs Date: Fri, 8 Nov 2019 08:45:43 -0800 [thread overview] Message-ID: <20191108164543.GD5610@atomide.com> (raw) In-Reply-To: <52549A4C-F49D-4FE9-9CD2-B331FB486BA9@goldelico.com> * H. Nikolaus Schaller <hns@goldelico.com> [191107 16:56]: > > Am 07.11.2019 um 15:35 schrieb Rob Herring <robh+dt@kernel.org>: > > On Thu, Nov 7, 2019 at 5:06 AM H. Nikolaus Schaller <hns@goldelico.com> wrote: > >> Clock, Reset and power management should be handled > >> by a parent node or elsewhere. > > > > That's probably TI specific... > > Yes and no. > > For example the img4780 seems to need a clock reference in the > gpu node. But it could maybe connected in a parent node like recent > TI SoC do with the target-module approach. The clocks are implemented at the SoC glue layer and/or the interconnect layer, and then the device probably has it's own clock gate controls. > And our goal is to end up with a common driver for all SoC and architectures > in far future. Then, probably clock, reset and power management should > be handled in the same way. Yeah so that's standard Linux features such as PM runtime and genpd basically :) So you can just leave out the clocks paragraph from the binding. Then if clocks are really needed beyond PM runtime and genpd, those can always be added later. We just need a super minimal binding to start with that only uses standard properties, then more can be added later if needed. Regards, Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com> To: "H. Nikolaus Schaller" <hns@goldelico.com> Cc: "Mark Rutland" <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, "Discussions about the Letux Kernel" <letux-kernel@openphoenux.org>, "Paul Burton" <paulburton@kernel.org>, "David Airlie" <airlied@linux.ie>, "James Hogan" <jhogan@kernel.org>, "OpenPVRSGX Linux Driver Group" <openpvrsgx-devgroup@letux.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Ralf Baechle" <ralf@linux-mips.org>, "open list:MIPS" <linux-mips@vger.kernel.org>, "Paul Cercueil" <paul@crapouillou.net>, "Rob Herring" <robh+dt@kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Benoît Cousson" <bcousson@baylibre.com>, kernel@pyra-handheld.com, linux-omap <linux-omap@vger.kernel.org> Subject: Re: [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml for Imagination GPUs Date: Fri, 8 Nov 2019 08:45:43 -0800 [thread overview] Message-ID: <20191108164543.GD5610@atomide.com> (raw) Message-ID: <20191108164543.-yhTBOOnBZtW7xPPY3Fng2RHUQiyhBaYZIYolZYsUaw@z> (raw) In-Reply-To: <52549A4C-F49D-4FE9-9CD2-B331FB486BA9@goldelico.com> * H. Nikolaus Schaller <hns@goldelico.com> [191107 16:56]: > > Am 07.11.2019 um 15:35 schrieb Rob Herring <robh+dt@kernel.org>: > > On Thu, Nov 7, 2019 at 5:06 AM H. Nikolaus Schaller <hns@goldelico.com> wrote: > >> Clock, Reset and power management should be handled > >> by a parent node or elsewhere. > > > > That's probably TI specific... > > Yes and no. > > For example the img4780 seems to need a clock reference in the > gpu node. But it could maybe connected in a parent node like recent > TI SoC do with the target-module approach. The clocks are implemented at the SoC glue layer and/or the interconnect layer, and then the device probably has it's own clock gate controls. > And our goal is to end up with a common driver for all SoC and architectures > in far future. Then, probably clock, reset and power management should > be handled in the same way. Yeah so that's standard Linux features such as PM runtime and genpd basically :) So you can just leave out the clocks paragraph from the binding. Then if clocks are really needed beyond PM runtime and genpd, those can always be added later. We just need a super minimal binding to start with that only uses standard properties, then more can be added later if needed. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-08 16:45 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 11:06 [PATCH v2 0/8] ARM/MIPS: DTS: add child nodes describing the PVRSGX present in some OMAP SoC and JZ4780 H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml for Imagination GPUs H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 1/8] RFC: dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller 2019-11-07 14:35 ` [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml " Rob Herring 2019-11-07 14:35 ` Rob Herring 2019-11-07 16:55 ` H. Nikolaus Schaller 2019-11-07 16:55 ` [PATCH v2 1/8] RFC: dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller 2019-11-08 16:45 ` Tony Lindgren [this message] 2019-11-08 16:45 ` [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml " Tony Lindgren 2019-11-24 11:40 ` [PATCH v2 1/8] RFC: dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller 2019-11-07 15:54 ` [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml " Tony Lindgren 2019-11-07 15:54 ` Tony Lindgren 2019-11-07 16:37 ` H. Nikolaus Schaller 2019-11-07 16:37 ` [PATCH v2 1/8] RFC: dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller 2019-11-08 16:49 ` [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml " Tony Lindgren 2019-11-08 16:49 ` Tony Lindgren 2019-11-07 11:06 ` [PATCH v2 2/8] ARM: DTS: am33xx: add sgx gpu child node H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 3/8] ARM: DTS: am3517: " H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 4/8] ARM: DTS: omap3: " H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 5/8] ARM: DTS: omap36xx: " H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 6/8] ARM: DTS: omap4: " H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 7/8] ARM: DTS: omap5: " H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller 2019-11-07 11:06 ` [PATCH v2 8/8] MIPS: DTS: jz4780: add sgx gpu node H. Nikolaus Schaller 2019-11-07 11:06 ` H. Nikolaus Schaller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108164543.GD5610@atomide.com \ --to=tony@atomide.com \ --cc=airlied@linux.ie \ --cc=bcousson@baylibre.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=hns@goldelico.com \ --cc=jhogan@kernel.org \ --cc=kernel@pyra-handheld.com \ --cc=letux-kernel@openphoenux.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=openpvrsgx-devgroup@letux.org \ --cc=paul@crapouillou.net \ --cc=paulburton@kernel.org \ --cc=ralf@linux-mips.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.