From: Borislav Petkov <bp@alien8.de>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
linux-arch@vger.kernel.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/10] Improvements for random.h/archrandom.h
Date: Mon, 11 Nov 2019 18:20:06 +0100 [thread overview]
Message-ID: <20191111172006.GC2799@zn.tnic> (raw)
In-Reply-To: <20191106141308.30535-1-rth@twiddle.net>
On Wed, Nov 06, 2019 at 03:12:58PM +0100, Richard Henderson wrote:
> During patch review for an addition of archrandom.h for arm64, it was
> suggeted that the arch_random_get_* functions should be marked __must_check.
> Which does sound like a good idea, since the by-reference integer output
> may be uninitialized when the boolean result is false.
>
> In addition, it turns out that arch_has_random() and arch_has_random_seed()
> are not used, and not easy to support for arm64. Rather than cobble
> something together that would not be testable, remove the interfaces
> against some future accidental use.
>
> In addition, I noticed a few other minor inconsistencies between the
> different architectures, e.g. powerpc isn't using bool.
>
> Change since v1:
> * Remove arch_has_random, arch_has_random_seed.
>
>
> r~
>
>
> Richard Henderson (10):
> x86: Remove arch_has_random, arch_has_random_seed
> powerpc: Remove arch_has_random, arch_has_random_seed
> s390: Remove arch_has_random, arch_has_random_seed
> linux/random.h: Remove arch_has_random, arch_has_random_seed
> linux/random.h: Use false with bool
> linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
> x86: Mark archrandom.h functions __must_check
> powerpc: Use bool in archrandom.h
> powerpc: Mark archrandom.h functions __must_check
> s390x: Mark archrandom.h functions __must_check
>
> arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
> arch/s390/include/asm/archrandom.h | 20 ++++---------------
> arch/x86/include/asm/archrandom.h | 28 ++++++++++++---------------
> include/linux/random.h | 24 ++++++++---------------
> 4 files changed, 33 insertions(+), 66 deletions(-)
>
> --
They look good to me.
Is anyone going to take them or should I though the tip tree?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
herbert@gondor.apana.org.au, x86@kernel.org,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/10] Improvements for random.h/archrandom.h
Date: Mon, 11 Nov 2019 18:20:06 +0100 [thread overview]
Message-ID: <20191111172006.GC2799@zn.tnic> (raw)
In-Reply-To: <20191106141308.30535-1-rth@twiddle.net>
On Wed, Nov 06, 2019 at 03:12:58PM +0100, Richard Henderson wrote:
> During patch review for an addition of archrandom.h for arm64, it was
> suggeted that the arch_random_get_* functions should be marked __must_check.
> Which does sound like a good idea, since the by-reference integer output
> may be uninitialized when the boolean result is false.
>
> In addition, it turns out that arch_has_random() and arch_has_random_seed()
> are not used, and not easy to support for arm64. Rather than cobble
> something together that would not be testable, remove the interfaces
> against some future accidental use.
>
> In addition, I noticed a few other minor inconsistencies between the
> different architectures, e.g. powerpc isn't using bool.
>
> Change since v1:
> * Remove arch_has_random, arch_has_random_seed.
>
>
> r~
>
>
> Richard Henderson (10):
> x86: Remove arch_has_random, arch_has_random_seed
> powerpc: Remove arch_has_random, arch_has_random_seed
> s390: Remove arch_has_random, arch_has_random_seed
> linux/random.h: Remove arch_has_random, arch_has_random_seed
> linux/random.h: Use false with bool
> linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
> x86: Mark archrandom.h functions __must_check
> powerpc: Use bool in archrandom.h
> powerpc: Mark archrandom.h functions __must_check
> s390x: Mark archrandom.h functions __must_check
>
> arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
> arch/s390/include/asm/archrandom.h | 20 ++++---------------
> arch/x86/include/asm/archrandom.h | 28 ++++++++++++---------------
> include/linux/random.h | 24 ++++++++---------------
> 4 files changed, 33 insertions(+), 66 deletions(-)
>
> --
They look good to me.
Is anyone going to take them or should I though the tip tree?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
herbert@gondor.apana.org.au, x86@kernel.org,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/10] Improvements for random.h/archrandom.h
Date: Mon, 11 Nov 2019 18:20:06 +0100 [thread overview]
Message-ID: <20191111172006.GC2799@zn.tnic> (raw)
In-Reply-To: <20191106141308.30535-1-rth@twiddle.net>
On Wed, Nov 06, 2019 at 03:12:58PM +0100, Richard Henderson wrote:
> During patch review for an addition of archrandom.h for arm64, it was
> suggeted that the arch_random_get_* functions should be marked __must_check.
> Which does sound like a good idea, since the by-reference integer output
> may be uninitialized when the boolean result is false.
>
> In addition, it turns out that arch_has_random() and arch_has_random_seed()
> are not used, and not easy to support for arm64. Rather than cobble
> something together that would not be testable, remove the interfaces
> against some future accidental use.
>
> In addition, I noticed a few other minor inconsistencies between the
> different architectures, e.g. powerpc isn't using bool.
>
> Change since v1:
> * Remove arch_has_random, arch_has_random_seed.
>
>
> r~
>
>
> Richard Henderson (10):
> x86: Remove arch_has_random, arch_has_random_seed
> powerpc: Remove arch_has_random, arch_has_random_seed
> s390: Remove arch_has_random, arch_has_random_seed
> linux/random.h: Remove arch_has_random, arch_has_random_seed
> linux/random.h: Use false with bool
> linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
> x86: Mark archrandom.h functions __must_check
> powerpc: Use bool in archrandom.h
> powerpc: Mark archrandom.h functions __must_check
> s390x: Mark archrandom.h functions __must_check
>
> arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
> arch/s390/include/asm/archrandom.h | 20 ++++---------------
> arch/x86/include/asm/archrandom.h | 28 ++++++++++++---------------
> include/linux/random.h | 24 ++++++++---------------
> 4 files changed, 33 insertions(+), 66 deletions(-)
>
> --
They look good to me.
Is anyone going to take them or should I though the tip tree?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 17:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:12 [PATCH v2 00/10] Improvements for random.h/archrandom.h Richard Henderson
2019-11-06 14:12 ` Richard Henderson
2019-11-06 14:12 ` Richard Henderson
2019-11-06 14:12 ` [PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed Richard Henderson
2019-11-06 14:12 ` Richard Henderson
2019-11-06 14:12 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 02/10] powerpc: " Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 03/10] s390: " Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 04/10] linux/random.h: " Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 05/10] linux/random.h: Use false with bool Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 07/10] x86: Mark archrandom.h " Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 08/10] powerpc: Use bool in archrandom.h Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` [PATCH v2 10/10] s390x: " Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-06 14:13 ` Richard Henderson
2019-11-11 17:20 ` Borislav Petkov [this message]
2019-11-11 17:20 ` [PATCH v2 00/10] Improvements for random.h/archrandom.h Borislav Petkov
2019-11-11 17:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111172006.GC2799@zn.tnic \
--to=bp@alien8.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=richard.henderson@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.