From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH v4.14] tcp: exit if nothing to retransmit on RTO timeout
Date: Sat, 7 Dec 2019 12:55:01 +0100 [thread overview]
Message-ID: <20191207115501.GA325082@kroah.com> (raw)
In-Reply-To: <20191206182016.137529-1-edumazet@google.com>
On Fri, Dec 06, 2019 at 10:20:16AM -0800, Eric Dumazet wrote:
> Two upstream commits squashed together for v4.14 stable :
>
> commit 88f8598d0a302a08380eadefd09b9f5cb1c4c428 upstream.
>
> Previously TCP only warns if its RTO timer fires and the
> retransmission queue is empty, but it'll cause null pointer
> reference later on. It's better to avoid such catastrophic failure
> and simply exit with a warning.
>
> Squashed with "tcp: refactor tcp_retransmit_timer()" :
>
> commit 0d580fbd2db084a5c96ee9c00492236a279d5e0f upstream.
Note, this commit is only in Dave's tree, not stable just yet. I'll
queue this up now, but I'm expecting that commit will come in to the
stable trees through the "normal" stable networking process.
thanks,
greg k-h
prev parent reply other threads:[~2019-12-07 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 18:20 [PATCH v4.14] tcp: exit if nothing to retransmit on RTO timeout Eric Dumazet
2019-12-07 11:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207115501.GA325082@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.