From: Sasha Levin <sashal@kernel.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Ellerman <mpe@ellerman.id.au>, Sasha Levin <sashal@kernel.org>, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 15/79] powerpc/tools: Don't quote $objdump in scripts Date: Wed, 11 Dec 2019 10:25:39 -0500 [thread overview] Message-ID: <20191211152643.23056-15-sashal@kernel.org> (raw) In-Reply-To: <20191211152643.23056-1-sashal@kernel.org> From: Michael Ellerman <mpe@ellerman.id.au> [ Upstream commit e44ff9ea8f4c8a90c82f7b85bd4f5e497c841960 ] Some of our scripts are passed $objdump and then call it as "$objdump". This doesn't work if it contains spaces because we're using ccache, for example you get errors such as: ./arch/powerpc/tools/relocs_check.sh: line 48: ccache ppc64le-objdump: No such file or directory ./arch/powerpc/tools/unrel_branch_check.sh: line 26: ccache ppc64le-objdump: No such file or directory Fix it by not quoting the string when we expand it, allowing the shell to do the right thing for us. Fixes: a71aa05e1416 ("powerpc: Convert relocs_check to a shell script using grep") Fixes: 4ea80652dc75 ("powerpc/64s: Tool to flag direct branches from unrelocated interrupt vectors") Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20191024004730.32135-1-mpe@ellerman.id.au Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/powerpc/tools/relocs_check.sh | 2 +- arch/powerpc/tools/unrel_branch_check.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/tools/relocs_check.sh b/arch/powerpc/tools/relocs_check.sh index ec2d5c835170a..d6c16e7faa387 100755 --- a/arch/powerpc/tools/relocs_check.sh +++ b/arch/powerpc/tools/relocs_check.sh @@ -23,7 +23,7 @@ objdump="$1" vmlinux="$2" bad_relocs=$( -"$objdump" -R "$vmlinux" | +$objdump -R "$vmlinux" | # Only look at relocation lines. grep -E '\<R_' | # These relocations are okay diff --git a/arch/powerpc/tools/unrel_branch_check.sh b/arch/powerpc/tools/unrel_branch_check.sh index 1e972df3107ee..77114755dc6f2 100755 --- a/arch/powerpc/tools/unrel_branch_check.sh +++ b/arch/powerpc/tools/unrel_branch_check.sh @@ -18,14 +18,14 @@ vmlinux="$2" #__end_interrupts should be located within the first 64K end_intr=0x$( -"$objdump" -R "$vmlinux" -d --start-address=0xc000000000000000 \ +$objdump -R "$vmlinux" -d --start-address=0xc000000000000000 \ --stop-address=0xc000000000010000 | grep '\<__end_interrupts>:' | awk '{print $1}' ) BRANCHES=$( -"$objdump" -R "$vmlinux" -D --start-address=0xc000000000000000 \ +$objdump -R "$vmlinux" -D --start-address=0xc000000000000000 \ --stop-address=${end_intr} | grep -e "^c[0-9a-f]*:[[:space:]]*\([0-9a-f][0-9a-f][[:space:]]\)\{4\}[[:space:]]*b" | grep -v '\<__start_initialization_multiplatform>' | -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sasha Levin <sashal@kernel.org>, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 15/79] powerpc/tools: Don't quote $objdump in scripts Date: Wed, 11 Dec 2019 10:25:39 -0500 [thread overview] Message-ID: <20191211152643.23056-15-sashal@kernel.org> (raw) In-Reply-To: <20191211152643.23056-1-sashal@kernel.org> From: Michael Ellerman <mpe@ellerman.id.au> [ Upstream commit e44ff9ea8f4c8a90c82f7b85bd4f5e497c841960 ] Some of our scripts are passed $objdump and then call it as "$objdump". This doesn't work if it contains spaces because we're using ccache, for example you get errors such as: ./arch/powerpc/tools/relocs_check.sh: line 48: ccache ppc64le-objdump: No such file or directory ./arch/powerpc/tools/unrel_branch_check.sh: line 26: ccache ppc64le-objdump: No such file or directory Fix it by not quoting the string when we expand it, allowing the shell to do the right thing for us. Fixes: a71aa05e1416 ("powerpc: Convert relocs_check to a shell script using grep") Fixes: 4ea80652dc75 ("powerpc/64s: Tool to flag direct branches from unrelocated interrupt vectors") Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20191024004730.32135-1-mpe@ellerman.id.au Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/powerpc/tools/relocs_check.sh | 2 +- arch/powerpc/tools/unrel_branch_check.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/tools/relocs_check.sh b/arch/powerpc/tools/relocs_check.sh index ec2d5c835170a..d6c16e7faa387 100755 --- a/arch/powerpc/tools/relocs_check.sh +++ b/arch/powerpc/tools/relocs_check.sh @@ -23,7 +23,7 @@ objdump="$1" vmlinux="$2" bad_relocs=$( -"$objdump" -R "$vmlinux" | +$objdump -R "$vmlinux" | # Only look at relocation lines. grep -E '\<R_' | # These relocations are okay diff --git a/arch/powerpc/tools/unrel_branch_check.sh b/arch/powerpc/tools/unrel_branch_check.sh index 1e972df3107ee..77114755dc6f2 100755 --- a/arch/powerpc/tools/unrel_branch_check.sh +++ b/arch/powerpc/tools/unrel_branch_check.sh @@ -18,14 +18,14 @@ vmlinux="$2" #__end_interrupts should be located within the first 64K end_intr=0x$( -"$objdump" -R "$vmlinux" -d --start-address=0xc000000000000000 \ +$objdump -R "$vmlinux" -d --start-address=0xc000000000000000 \ --stop-address=0xc000000000010000 | grep '\<__end_interrupts>:' | awk '{print $1}' ) BRANCHES=$( -"$objdump" -R "$vmlinux" -D --start-address=0xc000000000000000 \ +$objdump -R "$vmlinux" -D --start-address=0xc000000000000000 \ --stop-address=${end_intr} | grep -e "^c[0-9a-f]*:[[:space:]]*\([0-9a-f][0-9a-f][[:space:]]\)\{4\}[[:space:]]*b" | grep -v '\<__start_initialization_multiplatform>' | -- 2.20.1
next prev parent reply other threads:[~2019-12-11 15:45 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-11 15:25 [PATCH AUTOSEL 4.19 01/79] scsi: lpfc: Fix discovery failures when target device connectivity bounces Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 02/79] scsi: mpt3sas: Fix clear pending bit in ioctl status Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 03/79] scsi: lpfc: Fix locking on mailbox command completion Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 04/79] Input: atmel_mxt_ts - disable IRQ across suspend Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 05/79] f2fs: fix to update time in lazytime mode Sasha Levin 2019-12-11 15:25 ` [f2fs-dev] " Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 06/79] iommu: rockchip: Free domain on .domain_free Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` Sasha Levin [not found] ` <20191211152643.23056-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 07/79] iommu/tegra-smmu: Fix page tables in > 4 GiB memory Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 08/79] dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 09/79] scsi: target: compare full CHAP_A Algorithm strings Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 10/79] scsi: lpfc: Fix SLI3 hba in loop mode not discovering devices Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 11/79] scsi: csiostor: Don't enable IRQs too early Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 12/79] scsi: hisi_sas: Replace in_softirq() check in hisi_sas_task_exec() Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 13/79] powerpc/pseries: Mark accumulate_stolen_time() as notrace Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 14/79] powerpc/pseries: Don't fail hash page table insert for bolted mapping Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` Sasha Levin [this message] 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 15/79] powerpc/tools: Don't quote $objdump in scripts Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 16/79] dma-debug: add a schedule point in debug_dma_dump_mappings() Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 17/79] leds: lm3692x: Handle failure to probe the regulator Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 18/79] leds: trigger: netdev: fix handling on interface rename Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 19/79] clocksource/drivers/asm9260: Add a check for of_clk_get Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 20/79] clocksource/drivers/timer-of: Use unique device name instead of timer Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 21/79] powerpc/security/book3s64: Report L1TF status in sysfs Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 22/79] powerpc/book3s64/hash: Add cond_resched to avoid soft lockup warning Sasha Levin 2019-12-11 15:25 ` Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 23/79] ext4: update direct I/O read lock pattern for IOCB_NOWAIT Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 24/79] ext4: iomap that extends beyond EOF should be marked dirty Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 25/79] jbd2: Fix statistics for the number of logged blocks Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 26/79] scsi: tracing: Fix handling of TRANSFER LENGTH == 0 for READ(6) and WRITE(6) Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 27/79] scsi: lpfc: Fix duplicate unreg_rpi error in port offline flow Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 28/79] f2fs: fix to update dir's i_pino during cross_rename Sasha Levin 2019-12-11 15:25 ` [f2fs-dev] " Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 29/79] clk: qcom: Allow constant ratio freq tables for rcg Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 30/79] clk: clk-gpio: propagate rate change to parent Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 31/79] irqchip/irq-bcm7038-l1: Enable parent IRQ if necessary Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 32/79] irqchip: ingenic: Error out if IRQ domain creation failed Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 33/79] mfd: mfd-core: Honour Device Tree's request to disable a child-device Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 34/79] fs/quota: handle overflows of sysctl fs.quota.* and report as unsigned long Sasha Levin 2019-12-11 15:25 ` [PATCH AUTOSEL 4.19 35/79] scsi: lpfc: fix: Coverity: lpfc_cmpl_els_rsp(): Null pointer dereferences Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 36/79] scsi: zorro_esp: Limit DMA transfers to 65536 bytes (except on Fastlane) Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 37/79] PCI: rpaphp: Fix up pointer to first drc-info entry Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 38/79] scsi: ufs: fix potential bug which ends in system hang Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 39/79] powerpc/pseries/cmm: Implement release() function for sysfs device Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 40/79] PCI: rpaphp: Don't rely on firmware feature to imply drc-info support Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 41/79] PCI: rpaphp: Annotate and correctly byte swap DRC properties Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 42/79] PCI: rpaphp: Correctly match ibm, my-drc-index to drc-name when using drc-info Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 43/79] powerpc/security: Fix wrong message when RFI Flush is disable Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 44/79] scsi: atari_scsi: sun3_scsi: Set sg_tablesize to 1 instead of SG_NONE Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 45/79] clk: pxa: fix one of the pxa RTC clocks Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 46/79] bcache: at least try to shrink 1 node in bch_mca_scan() Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 47/79] HID: quirks: Add quirk for HP MSU1465 PIXART OEM mouse Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 48/79] ext4: fix a bug in ext4_wait_for_tail_page_commit Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 49/79] HID: logitech-hidpp: Silence intermittent get_battery_capacity errors Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 50/79] ARM: 8937/1: spectre-v2: remove Brahma-B53 from hardening Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 51/79] libnvdimm/btt: fix variable 'rc' set but not used Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 52/79] HID: Improve Windows Precision Touchpad detection Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 53/79] HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 54/79] watchdog: aspeed: Fix clock behaviour for ast2600 Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 55/79] watchdog: Fix the race between the release of watchdog_core_data and cdev Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 56/79] ext4: work around deleting a file with i_nlink == 0 safely Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 57/79] scsi: pm80xx: Fix for SATA device discovery Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 58/79] scsi: ufs: Fix error handing during hibern8 enter Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 59/79] scsi: scsi_debug: num_tgts must be >= 0 Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 60/79] scsi: NCR5380: Add disconnect_mask module parameter Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 61/79] scsi: iscsi: Don't send data to unbound connection Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 62/79] scsi: target: iscsi: Wait for all commands to finish before freeing a session Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 62/79] scsi: target: iscsi: Wait for all commands to finish before freeing a ses Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 63/79] gpio: mpc8xxx: Don't overwrite default irq_set_type callback Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 64/79] apparmor: fix unsigned len comparison with less than zero Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 65/79] scripts/kallsyms: fix definitely-lost memory leak Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 66/79] powerpc: Don't add -mabi= flags when building with Clang Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 67/79] f2fs: choose hardlimit when softlimit is larger than hardlimit in f2fs_statfs_project() Sasha Levin 2019-12-11 15:26 ` [f2fs-dev] " Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 68/79] of: unittest: fix memory leak in attach_node_and_children Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 69/79] cdrom: respect device capabilities during opening action Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 70/79] perf script: Fix invalid LBR/binary mismatch error Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 71/79] perf script: Fix brstackinsn for AUXTRACE Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 72/79] perf regs: Make perf_reg_name() return "unknown" instead of NULL Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 73/79] s390/zcrypt: handle new reply code FILTERED_BY_HYPERVISOR Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 74/79] libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 75/79] s390/cpum_sf: Check for SDBT and SDB consistency Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 76/79] ocfs2: fix passing zero to 'PTR_ERR' warning Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 77/79] mailbox: imx: Fix Tx doorbell shutdown path Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 78/79] kernel: sysctl: make drop_caches write-only Sasha Levin 2019-12-11 15:26 ` [PATCH AUTOSEL 4.19 79/79] userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK Sasha Levin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191211152643.23056-15-sashal@kernel.org \ --to=sashal@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.