* [PATCH] blk-cgroup: remove blkcg_drain_queue
@ 2019-12-12 14:08 jgq516
2019-12-12 15:17 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: jgq516 @ 2019-12-12 14:08 UTC (permalink / raw)
To: tj, axboe; +Cc: cgroups, linux-block, Guoqing Jiang
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Since blk_drain_queue had already been removed, so this function
is not needed anymore.
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
block/blk-cgroup.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 708dea92dac8..a229b94d5390 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1061,26 +1061,6 @@ int blkcg_init_queue(struct request_queue *q)
return PTR_ERR(blkg);
}
-/**
- * blkcg_drain_queue - drain blkcg part of request_queue
- * @q: request_queue to drain
- *
- * Called from blk_drain_queue(). Responsible for draining blkcg part.
- */
-void blkcg_drain_queue(struct request_queue *q)
-{
- lockdep_assert_held(&q->queue_lock);
-
- /*
- * @q could be exiting and already have destroyed all blkgs as
- * indicated by NULL root_blkg. If so, don't confuse policies.
- */
- if (!q->root_blkg)
- return;
-
- blk_throtl_drain(q);
-}
-
/**
* blkcg_exit_queue - exit and release blkcg part of request_queue
* @q: request_queue being released
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-cgroup: remove blkcg_drain_queue
2019-12-12 14:08 [PATCH] blk-cgroup: remove blkcg_drain_queue jgq516
@ 2019-12-12 15:17 ` Jens Axboe
2019-12-12 15:45 ` Guoqing Jiang
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2019-12-12 15:17 UTC (permalink / raw)
To: jgq516, tj; +Cc: cgroups, linux-block, Guoqing Jiang
On 12/12/19 7:08 AM, jgq516@gmail.com wrote:
> From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>
> Since blk_drain_queue had already been removed, so this function
> is not needed anymore.
You should remove it from include/linux/blk-cgroup.h as well.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-cgroup: remove blkcg_drain_queue
2019-12-12 15:17 ` Jens Axboe
@ 2019-12-12 15:45 ` Guoqing Jiang
0 siblings, 0 replies; 3+ messages in thread
From: Guoqing Jiang @ 2019-12-12 15:45 UTC (permalink / raw)
To: Jens Axboe, tj; +Cc: cgroups, linux-block
On 12/12/19 4:17 PM, Jens Axboe wrote:
> On 12/12/19 7:08 AM, jgq516@gmail.com wrote:
>> From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>>
>> Since blk_drain_queue had already been removed, so this function
>> is not needed anymore.
> You should remove it from include/linux/blk-cgroup.h as well.
>
Ok, will send a new version.
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-12 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 14:08 [PATCH] blk-cgroup: remove blkcg_drain_queue jgq516
2019-12-12 15:17 ` Jens Axboe
2019-12-12 15:45 ` Guoqing Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.