All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Support Opensource <Support.Opensource@diasemi.com>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation
Date: Thu, 12 Dec 2019 16:10:19 +0000	[thread overview]
Message-ID: <20191212161019.GF4310@sirena.org.uk> (raw)
In-Reply-To: <20191211170918.q7kqkd4lrwwp7jl3@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On Wed, Dec 11, 2019 at 06:09:18PM +0100, Marco Felsch wrote:

> so one argument more for my solution. Also we don't configure the "pad"
> to be a vsel/ena-pin. The hw-pad can only be a gpio or has an alternate
> function (WDKICK for GPIO0, Seq. SYS_EN for GPIO2, Seq. PWR_EN for GPIO4).
> Instead we tell the regulator to use _this_ GPIO e.g. for voltage
> selection so we go the other way around. My last argument why pinctrl
> isn't the correct place is that the GPIO1 can be used for
> regulator-0:vsel-in and for regulator-1:enable-in. So this pad would
> have different states which is invalid IMHO.

Note that there's two bits to my concern - one is if we should be using
gpiolib or pinctrl, the other is what's driving the input (whichever API
it's configured through) which didn't seem to be mentioned.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Support Opensource <Support.Opensource@diasemi.com>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation
Date: Thu, 12 Dec 2019 16:10:19 +0000	[thread overview]
Message-ID: <20191212161019.GF4310@sirena.org.uk> (raw)
In-Reply-To: <20191211170918.q7kqkd4lrwwp7jl3@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 812 bytes --]

On Wed, Dec 11, 2019 at 06:09:18PM +0100, Marco Felsch wrote:

> so one argument more for my solution. Also we don't configure the "pad"
> to be a vsel/ena-pin. The hw-pad can only be a gpio or has an alternate
> function (WDKICK for GPIO0, Seq. SYS_EN for GPIO2, Seq. PWR_EN for GPIO4).
> Instead we tell the regulator to use _this_ GPIO e.g. for voltage
> selection so we go the other way around. My last argument why pinctrl
> isn't the correct place is that the GPIO1 can be used for
> regulator-0:vsel-in and for regulator-1:enable-in. So this pad would
> have different states which is invalid IMHO.

Note that there's two bits to my concern - one is if we should be using
gpiolib or pinctrl, the other is what's driving the input (whichever API
it's configured through) which didn't seem to be mentioned.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-12-12 16:10 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 17:25 [PATCH v3 0/6] DA9062 PMIC features Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-11-29 17:25 ` [PATCH v3 1/6] gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset Marco Felsch
2019-11-29 17:25   ` Marco Felsch
2019-12-02  2:59   ` Andrew Jeffery
2019-12-02  2:59     ` Andrew Jeffery
2019-11-29 17:25 ` [PATCH v3 2/6] gpio: make gpiod_to_offset() available for other users Marco Felsch
2019-11-29 17:25   ` Marco Felsch
2019-12-02  3:00   ` Andrew Jeffery
2019-12-02  3:00     ` Andrew Jeffery
2019-11-29 17:25 ` [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Marco Felsch
2019-11-29 17:25   ` Marco Felsch
2019-12-04 13:46   ` Mark Brown
2019-12-04 13:46     ` Mark Brown
2019-12-10  9:41     ` Marco Felsch
2019-12-10  9:41       ` Marco Felsch
2019-12-11 16:14       ` Adam Thomson
2019-12-11 16:14         ` Adam Thomson
2019-12-11 17:09         ` Marco Felsch
2019-12-11 17:09           ` Marco Felsch
2019-12-12 15:08           ` Linus Walleij
2019-12-12 15:08             ` Linus Walleij
2019-12-12 15:55             ` Marco Felsch
2019-12-12 15:55               ` Marco Felsch
2019-12-12 16:10           ` Mark Brown [this message]
2019-12-12 16:10             ` Mark Brown
2019-12-12 16:21             ` Marco Felsch
2019-12-12 16:21               ` Marco Felsch
2019-12-12 16:51               ` Mark Brown
2019-12-12 16:51                 ` Mark Brown
2019-12-16  8:55                 ` Marco Felsch
2019-12-16  8:55                   ` Marco Felsch
2019-12-16 11:44                   ` Mark Brown
2019-12-16 11:44                     ` Mark Brown
2019-12-17  7:35                     ` Marco Felsch
2019-12-17  7:35                       ` Marco Felsch
2019-12-17 12:58                       ` Mark Brown
2019-12-17 12:58                         ` Mark Brown
2020-01-07  8:36                         ` Marco Felsch
2020-01-07  8:36                           ` Marco Felsch
2020-01-07 13:09                           ` Mark Brown
2020-01-07 13:09                             ` Mark Brown
2020-01-07 13:38                             ` Marco Felsch
2020-01-07 13:38                               ` Marco Felsch
2020-01-14 15:43                               ` Mark Brown
2020-01-14 15:43                                 ` Mark Brown
2019-12-16 16:32                   ` Adam Thomson
2019-12-16 16:32                     ` Adam Thomson
2019-12-17  9:00                     ` Marco Felsch
2019-12-17  9:00                       ` Marco Felsch
2019-12-17  9:12                       ` Marco Felsch
2019-12-17  9:12                         ` Marco Felsch
2019-12-17  9:53                       ` Adam Thomson
2019-12-17  9:53                         ` Adam Thomson
2019-12-17 12:31                         ` Marco Felsch
2019-12-17 12:31                           ` Marco Felsch
2019-12-17 13:13                           ` Adam Thomson
2019-12-17 13:13                             ` Adam Thomson
2019-12-16 16:32                   ` Adam Thomson
2019-12-16 16:32                     ` Adam Thomson
2019-12-16 12:28               ` Linus Walleij
2019-12-16 12:28                 ` Linus Walleij
2019-11-29 17:25 ` [PATCH v3 4/6] regulator: da9062: add voltage selection gpio support Marco Felsch
2019-11-29 17:25   ` Marco Felsch
2019-11-29 17:25 ` [PATCH v3 5/6] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation Marco Felsch
2019-11-29 17:25   ` Marco Felsch
2019-12-13 22:23   ` Rob Herring
2019-12-13 22:23     ` Rob Herring
2019-12-16 16:31   ` Lee Jones
2019-12-16 16:31     ` Lee Jones
2019-11-29 17:25 ` [PATCH v3 6/6] regulator: da9062: add gpio based regulator dis-/enable support Marco Felsch
2019-11-29 17:25   ` Marco Felsch
2019-12-02 11:44 ` [PATCH v3 0/6] DA9062 PMIC features Linus Walleij
2019-12-02 11:44   ` Linus Walleij
2019-12-02 12:04   ` Lee Jones
2019-12-02 12:04     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212161019.GF4310@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=andrew@aj.id.au \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.