From: Suzuki K Poulose <suzuki.poulose@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, will@kernel.org, maz@kernel.org, mark.rutland@arm.com, dave.martin@arm.com, catalin.marinas@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com, Suzuki K Poulose <suzuki.poulose@arm.com> Subject: [PATCH v2 3/7] arm64: cpufeature: Fix the type of no FP/SIMD capability Date: Tue, 17 Dec 2019 18:33:58 +0000 [thread overview] Message-ID: <20191217183402.2259904-4-suzuki.poulose@arm.com> (raw) In-Reply-To: <20191217183402.2259904-1-suzuki.poulose@arm.com> The NO_FPSIMD capability is defined with scope SYSTEM, which implies that the "absence" of FP/SIMD on at least one CPU is detected only after all the SMP CPUs are brought up. However, we use the status of this capability for every context switch. So, let us change the scope to LOCAL_CPU to allow the detection of this capability as and when the first CPU without FP is brought up. Also, the current type allows hotplugged CPU to be brought up without FP/SIMD when all the current CPUs have FP/SIMD and we have the userspace up. Fix both of these issues by changing the capability to BOOT_RESTRICTED_LOCAL_CPU_FEATURE. Fixes: 82e0191a1aa11abf ("arm64: Support systems without FP/ASIMD") Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- arch/arm64/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index d25ad65bfac2..2fc9f18e2d2d 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1369,7 +1369,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = { { /* FP/SIMD is not implemented */ .capability = ARM64_HAS_NO_FPSIMD, - .type = ARM64_CPUCAP_SYSTEM_FEATURE, + .type = ARM64_CPUCAP_BOOT_RESTRICTED_CPU_LOCAL_FEATURE, .min_field_value = 0, .matches = has_no_fpsimd, }, -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: mark.rutland@arm.com, ard.biesheuvel@linaro.org, maz@kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>, linux-kernel@vger.kernel.org, christoffer.dall@arm.com, catalin.marinas@arm.com, will@kernel.org, dave.martin@arm.com Subject: [PATCH v2 3/7] arm64: cpufeature: Fix the type of no FP/SIMD capability Date: Tue, 17 Dec 2019 18:33:58 +0000 [thread overview] Message-ID: <20191217183402.2259904-4-suzuki.poulose@arm.com> (raw) In-Reply-To: <20191217183402.2259904-1-suzuki.poulose@arm.com> The NO_FPSIMD capability is defined with scope SYSTEM, which implies that the "absence" of FP/SIMD on at least one CPU is detected only after all the SMP CPUs are brought up. However, we use the status of this capability for every context switch. So, let us change the scope to LOCAL_CPU to allow the detection of this capability as and when the first CPU without FP is brought up. Also, the current type allows hotplugged CPU to be brought up without FP/SIMD when all the current CPUs have FP/SIMD and we have the userspace up. Fix both of these issues by changing the capability to BOOT_RESTRICTED_LOCAL_CPU_FEATURE. Fixes: 82e0191a1aa11abf ("arm64: Support systems without FP/ASIMD") Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- arch/arm64/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index d25ad65bfac2..2fc9f18e2d2d 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1369,7 +1369,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = { { /* FP/SIMD is not implemented */ .capability = ARM64_HAS_NO_FPSIMD, - .type = ARM64_CPUCAP_SYSTEM_FEATURE, + .type = ARM64_CPUCAP_BOOT_RESTRICTED_CPU_LOCAL_FEATURE, .min_field_value = 0, .matches = has_no_fpsimd, }, -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-17 18:34 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-17 18:33 [PATCH v2 0/7] arm64: Fix support for no FP/SIMD Suzuki K Poulose 2019-12-17 18:33 ` Suzuki K Poulose 2019-12-17 18:33 ` [PATCH v2 1/7] arm64: Introduce system_capabilities_finalized() marker Suzuki K Poulose 2019-12-17 18:33 ` Suzuki K Poulose 2020-01-10 14:50 ` Catalin Marinas 2020-01-10 14:50 ` Catalin Marinas 2019-12-17 18:33 ` [PATCH v2 2/7] arm64: fpsimd: Make sure SVE setup is complete before SIMD is used Suzuki K Poulose 2019-12-17 18:33 ` Suzuki K Poulose 2020-01-10 11:51 ` Catalin Marinas 2020-01-10 11:51 ` Catalin Marinas 2020-01-10 18:41 ` Suzuki Kuruppassery Poulose 2020-01-10 18:41 ` Suzuki Kuruppassery Poulose 2019-12-17 18:33 ` Suzuki K Poulose [this message] 2019-12-17 18:33 ` [PATCH v2 3/7] arm64: cpufeature: Fix the type of no FP/SIMD capability Suzuki K Poulose 2020-01-10 14:50 ` Catalin Marinas 2020-01-10 14:50 ` Catalin Marinas 2019-12-17 18:33 ` [PATCH v2 4/7] arm64: cpufeature: Set the FP/SIMD compat HWCAP bits properly Suzuki K Poulose 2019-12-17 18:33 ` Suzuki K Poulose 2020-01-10 14:51 ` Catalin Marinas 2020-01-10 14:51 ` Catalin Marinas 2019-12-17 18:34 ` [PATCH v2 5/7] arm64: ptrace: nofpsimd: Fail FP/SIMD regset operations Suzuki K Poulose 2019-12-17 18:34 ` Suzuki K Poulose 2020-01-10 15:12 ` Catalin Marinas 2020-01-10 15:12 ` Catalin Marinas 2020-01-10 18:42 ` Suzuki Kuruppassery Poulose 2020-01-10 18:42 ` Suzuki Kuruppassery Poulose 2019-12-17 18:34 ` [PATCH v2 6/7] arm64: signal: nofpsimd: Handle fp/simd context for signal frames Suzuki K Poulose 2019-12-17 18:34 ` Suzuki K Poulose 2020-01-10 12:34 ` Catalin Marinas 2020-01-10 12:34 ` Catalin Marinas 2019-12-17 18:34 ` [PATCH v2 7/7] arm64: nofpsmid: Handle TIF_FOREIGN_FPSTATE flag cleanly Suzuki K Poulose 2019-12-17 18:34 ` Suzuki K Poulose 2019-12-17 19:05 ` Marc Zyngier 2019-12-17 19:05 ` Marc Zyngier 2019-12-18 11:42 ` Suzuki Kuruppassery Poulose 2019-12-18 11:42 ` Suzuki Kuruppassery Poulose 2019-12-18 11:56 ` Marc Zyngier 2019-12-18 11:56 ` Marc Zyngier 2019-12-18 12:00 ` Suzuki Kuruppassery Poulose 2019-12-18 12:00 ` Suzuki Kuruppassery Poulose 2020-01-10 15:21 ` Marc Zyngier 2020-01-10 15:21 ` Marc Zyngier 2020-01-13 10:28 ` Suzuki Kuruppassery Poulose 2020-01-13 10:28 ` Suzuki Kuruppassery Poulose 2020-01-10 14:49 ` Catalin Marinas 2020-01-10 14:49 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191217183402.2259904-4-suzuki.poulose@arm.com \ --to=suzuki.poulose@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@arm.com \ --cc=dave.martin@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.