From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org,
Linux Filesystem Development List
<linux-fsdevel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] memcg: fix a crash in wb_workfn when a device disappears
Date: Fri, 27 Dec 2019 16:19:58 -0500 [thread overview]
Message-ID: <20191227211958.GA154182@mit.edu> (raw)
In-Reply-To: <201912280556.y1lprcKe%lkp@intel.com>
On Sat, Dec 28, 2019 at 05:16:49AM +0800, kbuild test robot wrote:
> Hi Theodore,
>
> I love your patch! Yet something to improve:
>
> In file included from mm/fadvise.c:16:0:
> include/linux/backing-dev.h: In function 'bdi_dev_name':
> >> include/linux/backing-dev.h:513:9: error: implicit declaration of function 'dev_name'; did you mean 'getname'? [-Werror=implicit-function-declaration]
> return dev_name(bdi->dev);
> ^~~~~~~~
> getname
Already fixed in the V2 version of the patch. (Which I also forgot to label as V2, sigh...)
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Y. Ts'o <tytso@mit.edu>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] memcg: fix a crash in wb_workfn when a device disappears
Date: Fri, 27 Dec 2019 16:19:58 -0500 [thread overview]
Message-ID: <20191227211958.GA154182@mit.edu> (raw)
In-Reply-To: <201912280556.y1lprcKe%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Sat, Dec 28, 2019 at 05:16:49AM +0800, kbuild test robot wrote:
> Hi Theodore,
>
> I love your patch! Yet something to improve:
>
> In file included from mm/fadvise.c:16:0:
> include/linux/backing-dev.h: In function 'bdi_dev_name':
> >> include/linux/backing-dev.h:513:9: error: implicit declaration of function 'dev_name'; did you mean 'getname'? [-Werror=implicit-function-declaration]
> return dev_name(bdi->dev);
> ^~~~~~~~
> getname
Already fixed in the V2 version of the patch. (Which I also forgot to label as V2, sigh...)
next prev parent reply other threads:[~2019-12-27 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 19:48 [PATCH] memcg: fix a crash in wb_workfn when a device disappears Theodore Ts'o
2019-12-27 20:31 ` Theodore Ts'o
2019-12-27 21:16 ` kbuild test robot
2019-12-27 21:16 ` kbuild test robot
2019-12-27 21:16 ` kbuild test robot
2019-12-27 21:19 ` Theodore Y. Ts'o [this message]
2019-12-27 21:19 ` Theodore Y. Ts'o
2019-12-27 21:19 ` Theodore Y. Ts'o
2019-12-27 22:32 ` kbuild test robot
2019-12-27 22:32 ` kbuild test robot
2019-12-27 22:32 ` kbuild test robot
2019-12-28 0:52 ` [PATCH -v2] " Theodore Ts'o
2020-01-03 17:15 ` Theodore Y. Ts'o
2020-01-03 17:46 ` Chris Mason
2020-01-07 23:33 ` Andrew Morton
2020-01-08 2:12 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227211958.GA154182@mit.edu \
--to=tytso@mit.edu \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.