* [PATCH 1/2] usb: host: Enable compile testing for some of drivers
@ 2019-12-30 17:22 Krzysztof Kozlowski
2019-12-30 17:22 ` [PATCH 2/2] usb: phy: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-30 17:22 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi, linux-usb, linux-kernel
Cc: Krzysztof Kozlowski
Some of the USB host drivers can be compile tested to increase build
coverage. Add 'if' conditional to 'default y' so they will not get
enabled by default on all other architectures.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/usb/host/Kconfig | 54 ++++++++++++++++++++--------------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 8d730180db06..da14a3d16b57 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -186,7 +186,7 @@ config USB_EHCI_FSL
config USB_EHCI_MXC
tristate "Support for Freescale i.MX on-chip EHCI USB controller"
- depends on ARCH_MXC
+ depends on ARCH_MXC || COMPILE_TEST
select USB_EHCI_ROOT_HUB_TT
---help---
Variation of ARC USB block used in some Freescale chips.
@@ -210,8 +210,8 @@ config USB_EHCI_HCD_OMAP
config USB_EHCI_HCD_ORION
tristate "Support for Marvell EBU on-chip EHCI USB controller"
- depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)
- default y
+ depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU || COMPILE_TEST)
+ default y if (PLAT_ORION || ARCH_MVEBU)
---help---
Enables support for the on-chip EHCI controller on Marvell's
embedded ARM SoCs, including Orion, Kirkwood, Dove, Armada XP,
@@ -221,15 +221,15 @@ config USB_EHCI_HCD_ORION
config USB_EHCI_HCD_SPEAR
tristate "Support for ST SPEAr on-chip EHCI USB controller"
- depends on USB_EHCI_HCD && PLAT_SPEAR
- default y
+ depends on USB_EHCI_HCD && (PLAT_SPEAR || COMPILE_TEST)
+ default y if PLAT_SPEAR
---help---
Enables support for the on-chip EHCI controller on
ST SPEAr chips.
config USB_EHCI_HCD_STI
tristate "Support for ST STiHxxx on-chip EHCI USB controller"
- depends on ARCH_STI && OF
+ depends on (ARCH_STI || COMPILE_TEST) && OF
select GENERIC_PHY
select USB_EHCI_HCD_PLATFORM
help
@@ -238,8 +238,8 @@ config USB_EHCI_HCD_STI
config USB_EHCI_HCD_AT91
tristate "Support for Atmel on-chip EHCI USB controller"
- depends on USB_EHCI_HCD && ARCH_AT91
- default y
+ depends on USB_EHCI_HCD && (ARCH_AT91 || COMPILE_TEST)
+ default y if ARCH_AT91
---help---
Enables support for the on-chip EHCI controller on
Atmel chips.
@@ -263,20 +263,20 @@ config USB_EHCI_HCD_PPC_OF
config USB_EHCI_SH
bool "EHCI support for SuperH USB controller"
- depends on SUPERH
+ depends on SUPERH || COMPILE_TEST
---help---
Enables support for the on-chip EHCI controller on the SuperH.
If you use the PCI EHCI controller, this option is not necessary.
config USB_EHCI_EXYNOS
tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
- depends on ARCH_S5PV210 || ARCH_EXYNOS
+ depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
help
Enable support for the Samsung Exynos SOC's on-chip EHCI controller.
config USB_EHCI_MV
tristate "EHCI support for Marvell PXA/MMP USB controller"
- depends on (ARCH_PXA || ARCH_MMP)
+ depends on ARCH_PXA || ARCH_MMP || COMPILE_TEST
select USB_EHCI_ROOT_HUB_TT
---help---
Enables support for Marvell (including PXA and MMP series) on-chip
@@ -289,7 +289,7 @@ config USB_EHCI_MV
config USB_CNS3XXX_EHCI
bool "Cavium CNS3XXX EHCI Module (DEPRECATED)"
- depends on ARCH_CNS3XXX
+ depends on ARCH_CNS3XXX || COMPILE_TEST
select USB_EHCI_HCD_PLATFORM
---help---
This option is deprecated now and the driver was removed, use
@@ -309,7 +309,7 @@ config USB_EHCI_HCD_PLATFORM
config USB_OCTEON_EHCI
bool "Octeon on-chip EHCI support (DEPRECATED)"
- depends on CAVIUM_OCTEON_SOC
+ depends on CAVIUM_OCTEON_SOC || COMPILE_TEST
select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
select USB_EHCI_HCD_PLATFORM
help
@@ -410,15 +410,15 @@ config USB_OHCI_HCD_OMAP1
config USB_OHCI_HCD_SPEAR
tristate "Support for ST SPEAr on-chip OHCI USB controller"
- depends on USB_OHCI_HCD && PLAT_SPEAR
- default y
+ depends on USB_OHCI_HCD && (PLAT_SPEAR || COMPILE_TEST)
+ default y if PLAT_SPEAR
---help---
Enables support for the on-chip OHCI controller on
ST SPEAr chips.
config USB_OHCI_HCD_STI
tristate "Support for ST STiHxxx on-chip OHCI USB controller"
- depends on ARCH_STI && OF
+ depends on (ARCH_STI || COMPILE_TEST) && OF
select GENERIC_PHY
select USB_OHCI_HCD_PLATFORM
help
@@ -427,8 +427,8 @@ config USB_OHCI_HCD_STI
config USB_OHCI_HCD_S3C2410
tristate "OHCI support for Samsung S3C24xx/S3C64xx SoC series"
- depends on USB_OHCI_HCD && (ARCH_S3C24XX || ARCH_S3C64XX)
- default y
+ depends on USB_OHCI_HCD && (ARCH_S3C24XX || ARCH_S3C64XX || COMPILE_TEST)
+ default y if (ARCH_S3C24XX || ARCH_S3C64XX)
---help---
Enables support for the on-chip OHCI controller on
S3C24xx/S3C64xx chips.
@@ -453,17 +453,17 @@ config USB_OHCI_HCD_PXA27X
config USB_OHCI_HCD_AT91
tristate "Support for Atmel on-chip OHCI USB controller"
- depends on USB_OHCI_HCD && ARCH_AT91 && OF
- default y
+ depends on USB_OHCI_HCD && (ARCH_AT91 || COMPILE_TEST) && OF
+ default y if ARCH_AT91
---help---
Enables support for the on-chip OHCI controller on
Atmel chips.
config USB_OHCI_HCD_OMAP3
tristate "OHCI support for OMAP3 and later chips"
- depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
+ depends on ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5 || COMPILE_TEST
select USB_OHCI_HCD_PLATFORM
- default y
+ default y if ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5
help
This option is deprecated now and the driver was removed, use
USB_OHCI_HCD_PLATFORM instead.
@@ -473,10 +473,10 @@ config USB_OHCI_HCD_OMAP3
config USB_OHCI_HCD_DAVINCI
tristate "OHCI support for TI DaVinci DA8xx"
- depends on ARCH_DAVINCI_DA8XX
+ depends on ARCH_DAVINCI_DA8XX || COMPILE_TEST
depends on USB_OHCI_HCD
select PHY_DA8XX_USB
- default y
+ default y if ARCH_DAVINCI_DA8XX
help
Enables support for the DaVinci DA8xx integrated OHCI
controller. This driver cannot currently be a loadable
@@ -532,7 +532,7 @@ config USB_OHCI_HCD_SSB
config USB_OHCI_SH
bool "OHCI support for SuperH USB controller (DEPRECATED)"
- depends on SUPERH
+ depends on SUPERH || COMPILE_TEST
select USB_OHCI_HCD_PLATFORM
---help---
This option is deprecated now and the driver was removed, use
@@ -543,13 +543,13 @@ config USB_OHCI_SH
config USB_OHCI_EXYNOS
tristate "OHCI support for Samsung S5P/EXYNOS SoC Series"
- depends on ARCH_S5PV210 || ARCH_EXYNOS
+ depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
help
Enable support for the Samsung Exynos SOC's on-chip OHCI controller.
config USB_CNS3XXX_OHCI
bool "Cavium CNS3XXX OHCI Module (DEPRECATED)"
- depends on ARCH_CNS3XXX
+ depends on ARCH_CNS3XXX || COMPILE_TEST
select USB_OHCI_HCD_PLATFORM
---help---
This option is deprecated now and the driver was removed, use
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] usb: phy: Enable compile testing for some of drivers
2019-12-30 17:22 [PATCH 1/2] usb: host: Enable compile testing for some of drivers Krzysztof Kozlowski
@ 2019-12-30 17:22 ` Krzysztof Kozlowski
2019-12-30 19:29 ` [PATCH 1/2] usb: host: " Greg Kroah-Hartman
2019-12-30 22:43 ` kbuild test robot
2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-30 17:22 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi, linux-usb, linux-kernel
Cc: Krzysztof Kozlowski
Some of the USB phy drivers can be compile tested to increase build
coverage.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/usb/phy/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 24b4f091acb8..ff24fca0a2d9 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -162,7 +162,7 @@ config USB_MXS_PHY
config USB_TEGRA_PHY
tristate "NVIDIA Tegra USB PHY Driver"
- depends on ARCH_TEGRA
+ depends on ARCH_TEGRA || COMPILE_TEST
select USB_COMMON
select USB_PHY
select USB_ULPI
@@ -172,7 +172,7 @@ config USB_TEGRA_PHY
config USB_ULPI
bool "Generic ULPI Transceiver Driver"
- depends on ARM || ARM64
+ depends on ARM || ARM64 || COMPILE_TEST
select USB_ULPI_VIEWPORT
help
Enable this to support ULPI connected USB OTG transceivers which
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] usb: host: Enable compile testing for some of drivers
2019-12-30 17:22 [PATCH 1/2] usb: host: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-30 17:22 ` [PATCH 2/2] usb: phy: " Krzysztof Kozlowski
@ 2019-12-30 19:29 ` Greg Kroah-Hartman
2019-12-30 19:36 ` Greg Kroah-Hartman
2019-12-30 22:43 ` kbuild test robot
2 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-30 19:29 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Felipe Balbi, linux-usb, linux-kernel
On Mon, Dec 30, 2019 at 06:22:14PM +0100, Krzysztof Kozlowski wrote:
> Some of the USB host drivers can be compile tested to increase build
> coverage. Add 'if' conditional to 'default y' so they will not get
> enabled by default on all other architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/usb/host/Kconfig | 54 ++++++++++++++++++++--------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
Nice, thanks for these, they should help out a lot with development.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] usb: host: Enable compile testing for some of drivers
2019-12-30 19:29 ` [PATCH 1/2] usb: host: " Greg Kroah-Hartman
@ 2019-12-30 19:36 ` Greg Kroah-Hartman
2019-12-30 19:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-30 19:36 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Felipe Balbi, linux-usb, linux-kernel
On Mon, Dec 30, 2019 at 08:29:56PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 30, 2019 at 06:22:14PM +0100, Krzysztof Kozlowski wrote:
> > Some of the USB host drivers can be compile tested to increase build
> > coverage. Add 'if' conditional to 'default y' so they will not get
> > enabled by default on all other architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/usb/host/Kconfig | 54 ++++++++++++++++++++--------------------
> > 1 file changed, 27 insertions(+), 27 deletions(-)
>
> Nice, thanks for these, they should help out a lot with development.
And now I get this build warning with this patch:
WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
Depends on [n]: ARCH_DAVINCI_DA8XX
Selected by [m]:
- USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
Care to provide a fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] usb: host: Enable compile testing for some of drivers
2019-12-30 19:36 ` Greg Kroah-Hartman
@ 2019-12-30 19:42 ` Krzysztof Kozlowski
2019-12-30 20:06 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-30 19:42 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Felipe Balbi, linux-usb, linux-kernel
On Mon, Dec 30, 2019 at 08:36:21PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 30, 2019 at 08:29:56PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 30, 2019 at 06:22:14PM +0100, Krzysztof Kozlowski wrote:
> > > Some of the USB host drivers can be compile tested to increase build
> > > coverage. Add 'if' conditional to 'default y' so they will not get
> > > enabled by default on all other architectures.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > > drivers/usb/host/Kconfig | 54 ++++++++++++++++++++--------------------
> > > 1 file changed, 27 insertions(+), 27 deletions(-)
> >
> > Nice, thanks for these, they should help out a lot with development.
>
> And now I get this build warning with this patch:
>
> WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
> Depends on [n]: ARCH_DAVINCI_DA8XX
> Selected by [m]:
> - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
>
>
> Care to provide a fix?
That's my fault. I was testing entire patchset which includes also other
trees. I sent patch for PHY here:
https://lore.kernel.org/lkml/20191230172449.17648-2-krzk@kernel.org/T/#u
Probably they should go together or we could ignore the error as it is
only for build testing.
Best regards,
Krzysztof
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] usb: host: Enable compile testing for some of drivers
2019-12-30 19:42 ` Krzysztof Kozlowski
@ 2019-12-30 20:06 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-30 20:06 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Felipe Balbi, linux-usb, linux-kernel
On Mon, Dec 30, 2019 at 08:42:49PM +0100, Krzysztof Kozlowski wrote:
> On Mon, Dec 30, 2019 at 08:36:21PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 30, 2019 at 08:29:56PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 30, 2019 at 06:22:14PM +0100, Krzysztof Kozlowski wrote:
> > > > Some of the USB host drivers can be compile tested to increase build
> > > > coverage. Add 'if' conditional to 'default y' so they will not get
> > > > enabled by default on all other architectures.
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > > drivers/usb/host/Kconfig | 54 ++++++++++++++++++++--------------------
> > > > 1 file changed, 27 insertions(+), 27 deletions(-)
> > >
> > > Nice, thanks for these, they should help out a lot with development.
> >
> > And now I get this build warning with this patch:
> >
> > WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
> > Depends on [n]: ARCH_DAVINCI_DA8XX
> > Selected by [m]:
> > - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> >
> >
> > Care to provide a fix?
>
> That's my fault. I was testing entire patchset which includes also other
> trees. I sent patch for PHY here:
> https://lore.kernel.org/lkml/20191230172449.17648-2-krzk@kernel.org/T/#u
>
> Probably they should go together or we could ignore the error as it is
> only for build testing.
If that patchset gets merged, all is fine. If not, let me know and I
can take it through my tree :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] usb: host: Enable compile testing for some of drivers
2019-12-30 17:22 [PATCH 1/2] usb: host: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-30 17:22 ` [PATCH 2/2] usb: phy: " Krzysztof Kozlowski
2019-12-30 19:29 ` [PATCH 1/2] usb: host: " Greg Kroah-Hartman
@ 2019-12-30 22:43 ` kbuild test robot
2 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2019-12-30 22:43 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6101 bytes --]
Hi Krzysztof,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on char-misc/char-misc-testing v5.5-rc4 next-20191220]
[cannot apply to balbi-usb/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/usb-host-Enable-compile-testing-for-some-of-drivers/20191231-021714
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/usb/chipidea/host.c:18:0:
drivers/usb/chipidea/../host/ehci.h: In function 'ehci_readl':
>> drivers/usb/chipidea/../host/ehci.h:743:3: error: implicit declaration of function 'readl_be'; did you mean 'readsb'? [-Werror=implicit-function-declaration]
readl_be(regs) :
^~~~~~~~
readsb
drivers/usb/chipidea/../host/ehci.h: In function 'ehci_writel':
>> drivers/usb/chipidea/../host/ehci.h:767:3: error: implicit declaration of function 'writel_be'; did you mean 'writesb'? [-Werror=implicit-function-declaration]
writel_be(val, regs) :
^~~~~~~~~
writesb
cc1: some warnings being treated as errors
--
In file included from drivers/usb/host/ehci-hcd.c:96:0:
drivers/usb/host/ehci.h: In function 'ehci_readl':
>> drivers/usb/host/ehci.h:743:3: error: implicit declaration of function 'readl_be'; did you mean 'readsb'? [-Werror=implicit-function-declaration]
readl_be(regs) :
^~~~~~~~
readsb
drivers/usb/host/ehci.h: In function 'ehci_writel':
>> drivers/usb/host/ehci.h:767:3: error: implicit declaration of function 'writel_be'; did you mean 'writesb'? [-Werror=implicit-function-declaration]
writel_be(val, regs) :
^~~~~~~~~
writesb
cc1: some warnings being treated as errors
vim +743 drivers/usb/chipidea/../host/ehci.h
91bc4d31e81b15 Vladimir Barinov 2007-12-30 737
083522d76662cd Benjamin Herrenschmidt 2006-12-15 738 static inline unsigned int ehci_readl(const struct ehci_hcd *ehci,
083522d76662cd Benjamin Herrenschmidt 2006-12-15 739 __u32 __iomem *regs)
083522d76662cd Benjamin Herrenschmidt 2006-12-15 740 {
d728e327d4f86d Benjamin Herrenschmidt 2006-12-28 741 #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
083522d76662cd Benjamin Herrenschmidt 2006-12-15 742 return ehci_big_endian_mmio(ehci) ?
68f50e52554a0a Al Viro 2007-02-09 @743 readl_be(regs) :
68f50e52554a0a Al Viro 2007-02-09 744 readl(regs);
d728e327d4f86d Benjamin Herrenschmidt 2006-12-28 745 #else
68f50e52554a0a Al Viro 2007-02-09 746 return readl(regs);
d728e327d4f86d Benjamin Herrenschmidt 2006-12-28 747 #endif
083522d76662cd Benjamin Herrenschmidt 2006-12-15 748 }
083522d76662cd Benjamin Herrenschmidt 2006-12-15 749
feffe09f510c47 Peter Chen 2014-01-10 750 #ifdef CONFIG_SOC_IMX28
feffe09f510c47 Peter Chen 2014-01-10 751 static inline void imx28_ehci_writel(const unsigned int val,
feffe09f510c47 Peter Chen 2014-01-10 752 volatile __u32 __iomem *addr)
feffe09f510c47 Peter Chen 2014-01-10 753 {
feffe09f510c47 Peter Chen 2014-01-10 754 __asm__ ("swp %0, %0, [%1]" : : "r"(val), "r"(addr));
feffe09f510c47 Peter Chen 2014-01-10 755 }
feffe09f510c47 Peter Chen 2014-01-10 756 #else
feffe09f510c47 Peter Chen 2014-01-10 757 static inline void imx28_ehci_writel(const unsigned int val,
feffe09f510c47 Peter Chen 2014-01-10 758 volatile __u32 __iomem *addr)
feffe09f510c47 Peter Chen 2014-01-10 759 {
feffe09f510c47 Peter Chen 2014-01-10 760 }
feffe09f510c47 Peter Chen 2014-01-10 761 #endif
083522d76662cd Benjamin Herrenschmidt 2006-12-15 762 static inline void ehci_writel(const struct ehci_hcd *ehci,
083522d76662cd Benjamin Herrenschmidt 2006-12-15 763 const unsigned int val, __u32 __iomem *regs)
083522d76662cd Benjamin Herrenschmidt 2006-12-15 764 {
d728e327d4f86d Benjamin Herrenschmidt 2006-12-28 765 #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
083522d76662cd Benjamin Herrenschmidt 2006-12-15 766 ehci_big_endian_mmio(ehci) ?
68f50e52554a0a Al Viro 2007-02-09 @767 writel_be(val, regs) :
68f50e52554a0a Al Viro 2007-02-09 768 writel(val, regs);
d728e327d4f86d Benjamin Herrenschmidt 2006-12-28 769 #else
feffe09f510c47 Peter Chen 2014-01-10 770 if (ehci->imx28_write_fix)
feffe09f510c47 Peter Chen 2014-01-10 771 imx28_ehci_writel(val, regs);
feffe09f510c47 Peter Chen 2014-01-10 772 else
68f50e52554a0a Al Viro 2007-02-09 773 writel(val, regs);
d728e327d4f86d Benjamin Herrenschmidt 2006-12-28 774 #endif
083522d76662cd Benjamin Herrenschmidt 2006-12-15 775 }
8cd42e97bf451b Kumar Gala 2006-01-20 776
:::::: The code at line 743 was first introduced by commit
:::::: 68f50e52554a0a55dfe2e3fdf659ee0569d73c3f [PATCH] hci_{read,write}l() does force casts to wrong type for no reason
:::::: TO: Al Viro <viro@ftp.linux.org.uk>
:::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 50772 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-30 22:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-30 17:22 [PATCH 1/2] usb: host: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-30 17:22 ` [PATCH 2/2] usb: phy: " Krzysztof Kozlowski
2019-12-30 19:29 ` [PATCH 1/2] usb: host: " Greg Kroah-Hartman
2019-12-30 19:36 ` Greg Kroah-Hartman
2019-12-30 19:42 ` Krzysztof Kozlowski
2019-12-30 20:06 ` Greg Kroah-Hartman
2019-12-30 22:43 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.