From: kbuild test robot <lkp@intel.com> To: sunil.kovvuri@gmail.com Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org, davem@davemloft.net, Sunil Goutham <sgoutham@marvell.com>, Geetha sowjanya <gakula@marvell.com> Subject: Re: [PATCH 07/17] octeontx2-pf: Add packet transmission support Date: Mon, 13 Jan 2020 10:04:10 +0800 [thread overview] Message-ID: <202001131054.2SsRR00M%lkp@intel.com> (raw) In-Reply-To: <1578656521-14189-8-git-send-email-sunil.kovvuri@gmail.com> [-- Attachment #1: Type: text/plain, Size: 4447 bytes --] Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on net-next/master linus/master v5.5-rc5 next-20200110] [cannot apply to ipvs/master sparc-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/sunil-kovvuri-gmail-com/octeontx2-pf-Add-network-driver-for-physical-function/20200111-050500 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e267371dd376d1b3ebc9f01229845a9656734d97 config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:15:0: drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_write64': drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:210:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] writeq(val, addr); ^~~~~~ writel drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_read64': drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:217:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration] return readq(addr); ^~~~~ readl drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_snd_pkt_handler': >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:96:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] skb = (struct sk_buff *)sg->skb; ^ >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:104:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sg->skb = (u64)NULL; ^ drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_sqe_add_sg': drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:392:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sq->sg[sq->head].skb = (u64)skb; ^ drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_cleanup_tx_cqes': drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:534:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] skb = (struct sk_buff *)sg->skb; ^ drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:538:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sg->skb = (u64)NULL; ^ cc1: some warnings being treated as errors vim +96 drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c 75 76 static void otx2_snd_pkt_handler(struct otx2_nic *pfvf, 77 struct otx2_cq_queue *cq, 78 struct otx2_snd_queue *sq, 79 struct nix_cqe_tx_s *cqe, 80 int budget, int *tx_pkts, int *tx_bytes) 81 { 82 struct nix_send_comp_s *snd_comp = &cqe->comp; 83 struct sk_buff *skb = NULL; 84 struct sg_list *sg; 85 86 if (unlikely(snd_comp->status)) { 87 netdev_info(pfvf->netdev, 88 "TX%d: Error in send CQ status:%x\n", 89 cq->cint_idx, snd_comp->status); 90 } 91 92 /* Barrier, so that update to sq by other cpus is visible */ 93 smp_mb(); 94 sg = &sq->sg[snd_comp->sqe_id]; 95 > 96 skb = (struct sk_buff *)sg->skb; 97 if (unlikely(!skb)) 98 return; 99 100 *tx_bytes += skb->len; 101 (*tx_pkts)++; 102 otx2_dma_unmap_skb_frags(pfvf, sg); 103 napi_consume_skb(skb, budget); > 104 sg->skb = (u64)NULL; 105 } 106 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 62953 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 07/17] octeontx2-pf: Add packet transmission support Date: Mon, 13 Jan 2020 10:04:10 +0800 [thread overview] Message-ID: <202001131054.2SsRR00M%lkp@intel.com> (raw) In-Reply-To: <1578656521-14189-8-git-send-email-sunil.kovvuri@gmail.com> [-- Attachment #1: Type: text/plain, Size: 4544 bytes --] Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on net-next/master linus/master v5.5-rc5 next-20200110] [cannot apply to ipvs/master sparc-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/sunil-kovvuri-gmail-com/octeontx2-pf-Add-network-driver-for-physical-function/20200111-050500 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e267371dd376d1b3ebc9f01229845a9656734d97 config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:15:0: drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_write64': drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:210:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] writeq(val, addr); ^~~~~~ writel drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_read64': drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:217:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration] return readq(addr); ^~~~~ readl drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_snd_pkt_handler': >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:96:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] skb = (struct sk_buff *)sg->skb; ^ >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:104:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sg->skb = (u64)NULL; ^ drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_sqe_add_sg': drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:392:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sq->sg[sq->head].skb = (u64)skb; ^ drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_cleanup_tx_cqes': drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:534:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] skb = (struct sk_buff *)sg->skb; ^ drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:538:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sg->skb = (u64)NULL; ^ cc1: some warnings being treated as errors vim +96 drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c 75 76 static void otx2_snd_pkt_handler(struct otx2_nic *pfvf, 77 struct otx2_cq_queue *cq, 78 struct otx2_snd_queue *sq, 79 struct nix_cqe_tx_s *cqe, 80 int budget, int *tx_pkts, int *tx_bytes) 81 { 82 struct nix_send_comp_s *snd_comp = &cqe->comp; 83 struct sk_buff *skb = NULL; 84 struct sg_list *sg; 85 86 if (unlikely(snd_comp->status)) { 87 netdev_info(pfvf->netdev, 88 "TX%d: Error in send CQ status:%x\n", 89 cq->cint_idx, snd_comp->status); 90 } 91 92 /* Barrier, so that update to sq by other cpus is visible */ 93 smp_mb(); 94 sg = &sq->sg[snd_comp->sqe_id]; 95 > 96 skb = (struct sk_buff *)sg->skb; 97 if (unlikely(!skb)) 98 return; 99 100 *tx_bytes += skb->len; 101 (*tx_pkts)++; 102 otx2_dma_unmap_skb_frags(pfvf, sg); 103 napi_consume_skb(skb, budget); > 104 sg->skb = (u64)NULL; 105 } 106 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 62953 bytes --]
next prev parent reply other threads:[~2020-01-13 2:04 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 11:41 [PATCH 00/17] octeontx2-pf: Add network driver for physical function sunil.kovvuri 2020-01-10 11:41 ` [PATCH 01/17] octeontx2-pf: Add Marvell OcteonTX2 NIC driver sunil.kovvuri 2020-01-12 10:01 ` kbuild test robot 2020-01-12 10:01 ` kbuild test robot 2020-01-12 18:52 ` kbuild test robot 2020-01-12 18:52 ` kbuild test robot 2020-01-10 11:41 ` [PATCH 02/17] octeontx2-pf: Mailbox communication with AF sunil.kovvuri 2020-01-10 11:41 ` [PATCH 03/17] octeontx2-pf: Attach NIX and NPA block LFs sunil.kovvuri 2020-01-10 11:41 ` [PATCH 04/17] octeontx2-pf: Initialize and config queues sunil.kovvuri 2020-01-12 17:01 ` kbuild test robot 2020-01-12 17:01 ` kbuild test robot 2020-01-10 11:41 ` [PATCH 05/17] octeontx2-pf: Setup interrupts and NAPI handler sunil.kovvuri 2020-01-10 11:41 ` [PATCH 06/17] octeontx2-pf: Receive packet handling support sunil.kovvuri 2020-01-10 11:41 ` [PATCH 07/17] octeontx2-pf: Add packet transmission support sunil.kovvuri 2020-01-13 2:04 ` kbuild test robot [this message] 2020-01-13 2:04 ` kbuild test robot 2020-01-10 11:41 ` [PATCH 08/17] octeontx2-pf: Register and handle link notifications sunil.kovvuri 2020-01-10 11:41 ` [PATCH 09/17] octeontx2-pf: MTU, MAC and RX mode config support sunil.kovvuri 2020-01-10 11:41 ` [PATCH 10/17] octeontx2-pf: Error handling support sunil.kovvuri 2020-01-10 11:41 ` [PATCH 11/17] octeontx2-pf: Receive side scaling support sunil.kovvuri 2020-01-10 11:41 ` [PATCH 12/17] octeontx2-pf: TCP segmentation offload support sunil.kovvuri 2020-01-10 11:41 ` [PATCH 13/17] octeontx2-pf: Add ndo_get_stats64 sunil.kovvuri 2020-01-10 11:41 ` [PATCH 14/17] octeontx2-pf: Add basic ethtool support sunil.kovvuri 2020-01-10 19:28 ` Jakub Kicinski 2020-01-11 8:47 ` Sunil Kovvuri 2020-01-11 13:27 ` Jakub Kicinski 2020-01-13 11:27 ` Sunil Kovvuri 2020-01-10 11:41 ` [PATCH 15/17] octeontx2-pf: ethtool RSS config support sunil.kovvuri 2020-01-10 11:42 ` [PATCH 16/17] Documentation: net: octeontx2: Add RVU HW and drivers overview sunil.kovvuri 2020-01-10 11:42 ` [PATCH 17/17] MAINTAINERS: Add entry for Marvell OcteonTX2 Physical Function driver sunil.kovvuri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202001131054.2SsRR00M%lkp@intel.com \ --to=lkp@intel.com \ --cc=davem@davemloft.net \ --cc=gakula@marvell.com \ --cc=kbuild-all@lists.01.org \ --cc=netdev@vger.kernel.org \ --cc=sgoutham@marvell.com \ --cc=sunil.kovvuri@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.