From: Nick Desaulniers <ndesaulniers@google.com>
To: caij2003@gmail.com
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
perex@perex.cz, tiwai@suse.com,
clang-built-linux@googlegroups.com
Subject: RE: [PATCH] ASoC: soc-core: fix an uninitialized use
Date: Thu, 6 Feb 2020 15:28:40 -0800 [thread overview]
Message-ID: <20200206232840.227705-1-ndesaulniers@google.com> (raw)
In-Reply-To: <20200206200345.175344-1-caij2003@gmail.com>
> Fixed the uninitialized use of a signed integer variable ret in
> soc_probe_component when all its definitions are not executed. This
> caused -ftrivial-auto-var-init=pattern to initialize the variable to
> repeated 0xAA (i.e. a negative value) and triggered the following code
> unintentionally.
> Signed-off-by: Jian Cai <caij2003@gmail.com>
Hi Jian,
I don't quite follow; it looks like `ret` is assigned to multiple times in
`soc_probe_component`. Are one of the return values of one of the functions
that are called then assigned to `ret` undefined? What control flow path leaves
`ret` unitialized?
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: caij2003@gmail.com
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
clang-built-linux@googlegroups.com, broonie@kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: fix an uninitialized use
Date: Thu, 6 Feb 2020 15:28:40 -0800 [thread overview]
Message-ID: <20200206232840.227705-1-ndesaulniers@google.com> (raw)
In-Reply-To: <20200206200345.175344-1-caij2003@gmail.com>
> Fixed the uninitialized use of a signed integer variable ret in
> soc_probe_component when all its definitions are not executed. This
> caused -ftrivial-auto-var-init=pattern to initialize the variable to
> repeated 0xAA (i.e. a negative value) and triggered the following code
> unintentionally.
> Signed-off-by: Jian Cai <caij2003@gmail.com>
Hi Jian,
I don't quite follow; it looks like `ret` is assigned to multiple times in
`soc_probe_component`. Are one of the return values of one of the functions
that are called then assigned to `ret` undefined? What control flow path leaves
`ret` unitialized?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-06 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 20:03 [PATCH] ASoC: soc-core: fix an uninitialized use Jian Cai
2020-02-06 20:03 ` [alsa-devel] " Jian Cai
2020-02-06 23:28 ` Nick Desaulniers [this message]
2020-02-06 23:28 ` Nick Desaulniers
2020-02-06 23:55 ` Jian Cai
2020-02-07 0:04 ` Nick Desaulniers
2020-02-07 0:04 ` [alsa-devel] " Nick Desaulniers
2020-02-07 0:19 ` Jian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206232840.227705-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=caij2003@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.