Re: [PATCH v3 5/7] ui/gtk: implement show-cursor option

From: Gerd Hoffmann <kraxel@redhat.com>
To: Joshua Watt <jpewhacker@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	jtomko@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org,
	Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 5/7] ui/gtk: implement show-cursor option
Date: Wed, 12 Feb 2020 12:57:33 +0100	[thread overview]
Message-ID: <20200212115733.eha47pyo4wos6fql@sirius.home.kraxel.org> (raw)
In-Reply-To: <b0dca00d-5d35-a139-b5d0-1777c92b23a0@gmail.com>

> > +    if (s->opts->has_show_cursor && s->opts->show_cursor) {
> > +        s->null_cursor = NULL; /* default pointer */
> > +    } else {
> > +        s->null_cursor = gdk_cursor_new_for_display(window_display,
> > +                                                    GDK_BLANK_CURSOR);
> > +    }
> 
> I think it would make more sense to have all the logic related to what
> cursor is used in the same location, instead of split up between here and
> gd_update_cursor().

Note that it isn't that simple.  There are a few more places in
gd_grab_*() which use s->null_cursor and would need adaption.

cheers,
  Gerd