* [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA
@ 2020-03-13 19:53 Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 1/3] include/drm-uapi: Update i915_drm.h for perf OA APIs Umesh Nerlige Ramappa
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-03-13 19:53 UTC (permalink / raw)
To: igt-dev, Lionel G Landwerlin, Ashutosh Dixit
Add tests that verify the configurable poll delay in perf OA.
Lionel Landwerlin (2):
include/drm-uapi: Update i915_drm.h for perf OA APIs
tests/perf: new tests for parameterized OA buffer polling
Umesh Nerlige Ramappa (1):
tools: Allow user to set poll delay in i915 perf recorder
include/drm-uapi/i915_drm.h | 13 +++
tests/perf.c | 136 ++++++++++++++++++++-------
tools/i915-perf/i915_perf_recorder.c | 37 +++++++-
3 files changed, 149 insertions(+), 37 deletions(-)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] include/drm-uapi: Update i915_drm.h for perf OA APIs
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
@ 2020-03-13 19:53 ` Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling Umesh Nerlige Ramappa
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-03-13 19:53 UTC (permalink / raw)
To: igt-dev, Lionel G Landwerlin, Ashutosh Dixit
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Add APIs to configure poll delay in perf OA.
v2: (Umesh)
- Remove interrupt and flush APIs
- Change commit message
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
include/drm-uapi/i915_drm.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
index 3794e768..813175c4 100644
--- a/include/drm-uapi/i915_drm.h
+++ b/include/drm-uapi/i915_drm.h
@@ -1969,6 +1969,19 @@ enum drm_i915_perf_property_id {
*/
DRM_I915_PERF_PROP_HOLD_PREEMPTION,
+ /**
+ * This optional parameter specifies the timer interval in nanoseconds
+ * at which the i915 driver will check the OA buffer for available data.
+ * Minimum allowed value is 100 microseconds. A default value is used by
+ * the driver if this parameter is not specified. Note that a large
+ * value may reduce cpu consumption during OA perf captures, but it
+ * would also potentially result in OA buffer overwrite as the captures
+ * reach end of the OA buffer.
+ *
+ * This property is available in perf revision 4.
+ */
+ DRM_I915_PERF_PROP_POLL_OA_DELAY,
+
DRM_I915_PERF_PROP_MAX /* non-ABI */
};
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 1/3] include/drm-uapi: Update i915_drm.h for perf OA APIs Umesh Nerlige Ramappa
@ 2020-03-13 19:53 ` Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 3/3] tools: Allow user to set poll delay in i915 perf recorder Umesh Nerlige Ramappa
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-03-13 19:53 UTC (permalink / raw)
To: igt-dev, Lionel G Landwerlin, Ashutosh Dixit
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
2 new tests verifying that the OA buffer is properly checked at the
frequency specified by userspace.
v2: (Umesh)
- Capture start_times in test_polling
- Second parameterized test used a 500us hrtimer. Occassionally, this
timing does not fall within the duration/100 requirement for the time
spent in kernel. Change this value to 2ms to accommodate all
platforms.
v3: (Lionel)
- Use NUM_PROPERTIES
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/perf.c | 136 ++++++++++++++++++++++++++++++++++++++-------------
1 file changed, 102 insertions(+), 34 deletions(-)
diff --git a/tests/perf.c b/tests/perf.c
index 5e818030..9dfa6ec5 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -234,6 +234,24 @@ get_oa_format(enum drm_i915_oa_format format)
return gen8_oa_formats[format];
}
+static char *
+pretty_print_oa_period(uint64_t oa_period_ns)
+{
+ static char result[100];
+ static const char *units[4] = { "ns", "us", "ms", "s" };
+ double val = oa_period_ns;
+ int iter = 0;
+
+ while (iter < (ARRAY_SIZE(units) - 1) &&
+ val >= 1000.0f) {
+ val /= 1000.0f;
+ iter++;
+ }
+
+ snprintf(result, sizeof(result), "%.3f%s", val, units[iter]);
+ return result;
+}
+
static void
__perf_close(int fd)
{
@@ -1921,15 +1939,9 @@ get_time(void)
* kernelspace.
*/
static void
-test_blocking(void)
+test_blocking(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t kernel_hrtimer)
{
- /* ~40 milliseconds
- *
- * Having a period somewhat > sysconf(_SC_CLK_TCK) helps to stop
- * scheduling (liable to kick in when we make blocking poll()s/reads)
- * from interfering with the test.
- */
- int oa_exponent = max_oa_exponent_for_period_lte(40000000);
+ int oa_exponent = max_oa_exponent_for_period_lte(requested_oa_period);
uint64_t oa_period = oa_exponent_to_ns(oa_exponent);
uint64_t properties[] = {
/* Include OA reports in samples */
@@ -1939,11 +1951,16 @@ test_blocking(void)
DRM_I915_PERF_PROP_OA_METRICS_SET, test_set->perf_oa_metrics_set,
DRM_I915_PERF_PROP_OA_FORMAT, test_set->perf_oa_format,
DRM_I915_PERF_PROP_OA_EXPONENT, oa_exponent,
+
+ /* Kernel configuration (optional) */
+ DRM_I915_PERF_PROP_POLL_OA_DELAY, kernel_hrtimer,
};
struct drm_i915_perf_open_param param = {
.flags = I915_PERF_FLAG_FD_CLOEXEC |
I915_PERF_FLAG_DISABLED,
- .num_properties = sizeof(properties) / 16,
+ .num_properties = set_kernel_hrtimer ?
+ NUM_PROPERTIES(properties) :
+ NUM_PROPERTIES(properties) - 1,
.properties_ptr = to_user_pointer(properties),
};
uint8_t buf[1024 * 1024];
@@ -1965,7 +1982,7 @@ test_blocking(void)
* the knowledge that that the driver uses a 200Hz hrtimer (5ms period)
* to check for data and giving some time to read().
*/
- int min_iterations = (test_duration_ns / (oa_period + 6000000ull));
+ int min_iterations = (test_duration_ns / (oa_period + kernel_hrtimer + kernel_hrtimer / 5));
int64_t start, end;
int n = 0;
@@ -1975,9 +1992,10 @@ test_blocking(void)
times(&start_times);
igt_debug("tick length = %dns, test duration = %"PRIu64"ns, min iter. = %d,"
- " estimated max iter. = %d, oa_period = %"PRIu64"ns\n",
+ " estimated max iter. = %d, oa_period = %s\n",
(int)tick_ns, test_duration_ns,
- min_iterations, max_iterations, oa_period);
+ min_iterations, max_iterations,
+ pretty_print_oa_period(oa_period));
/* In the loop we perform blocking polls while the HW is sampling at
* ~25Hz, with the expectation that we spend most of our time blocked
@@ -2079,15 +2097,9 @@ test_blocking(void)
}
static void
-test_polling(void)
+test_polling(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t kernel_hrtimer)
{
- /* ~40 milliseconds
- *
- * Having a period somewhat > sysconf(_SC_CLK_TCK) helps to stop
- * scheduling (liable to kick in when we make blocking poll()s/reads)
- * from interfering with the test.
- */
- int oa_exponent = max_oa_exponent_for_period_lte(40000000);
+ int oa_exponent = max_oa_exponent_for_period_lte(requested_oa_period);
uint64_t oa_period = oa_exponent_to_ns(oa_exponent);
uint64_t properties[] = {
/* Include OA reports in samples */
@@ -2097,12 +2109,17 @@ test_polling(void)
DRM_I915_PERF_PROP_OA_METRICS_SET, test_set->perf_oa_metrics_set,
DRM_I915_PERF_PROP_OA_FORMAT, test_set->perf_oa_format,
DRM_I915_PERF_PROP_OA_EXPONENT, oa_exponent,
+
+ /* Kernel configuration (optional) */
+ DRM_I915_PERF_PROP_POLL_OA_DELAY, kernel_hrtimer,
};
struct drm_i915_perf_open_param param = {
.flags = I915_PERF_FLAG_FD_CLOEXEC |
I915_PERF_FLAG_DISABLED |
I915_PERF_FLAG_FD_NONBLOCK,
- .num_properties = sizeof(properties) / 16,
+ .num_properties = set_kernel_hrtimer ?
+ NUM_PROPERTIES(properties) :
+ NUM_PROPERTIES(properties) - 1,
.properties_ptr = to_user_pointer(properties),
};
uint8_t buf[1024 * 1024];
@@ -2116,15 +2133,16 @@ test_polling(void)
int n_extra_iterations = 0;
/* It's a bit tricky to put a lower limit here, but we expect a
- * relatively low latency for seeing reports, while we don't currently
- * give any control over this in the api.
+ * relatively low latency for seeing reports.
*
- * We assume a maximum latency of 6 millisecond to deliver a POLLIN and
- * read() after a new sample is written (46ms per iteration) considering
- * the knowledge that that the driver uses a 200Hz hrtimer (5ms period)
- * to check for data and giving some time to read().
+ * We assume a maximum latency of kernel_hrtimer + some margin
+ * to deliver a POLLIN and read() after a new sample is
+ * written (40ms + hrtimer + margin per iteration) considering
+ * the knowledge that that the driver uses a 200Hz hrtimer
+ * (5ms period) to check for data and giving some time to
+ * read().
*/
- int min_iterations = (test_duration_ns / (oa_period + 6000000ull));
+ int min_iterations = (test_duration_ns / (oa_period + (kernel_hrtimer + kernel_hrtimer / 5)));
int64_t start, end;
int n = 0;
@@ -2132,8 +2150,9 @@ test_polling(void)
times(&start_times);
- igt_debug("tick length = %dns, test duration = %"PRIu64"ns, min iter. = %d, max iter. = %d\n",
- (int)tick_ns, test_duration_ns,
+ igt_debug("tick length = %dns, oa period = %s, "
+ "test duration = %"PRIu64"ns, min iter. = %d, max iter. = %d\n",
+ (int)tick_ns, pretty_print_oa_period(oa_period), test_duration_ns,
min_iterations, max_iterations);
/* In the loop we perform blocking polls while the HW is sampling at
@@ -4502,6 +4521,23 @@ test_sysctl_defaults(void)
igt_assert_eq(max_freq, 100000);
}
+static int i915_perf_revision(int fd)
+{
+ drm_i915_getparam_t gp;
+ int value = 1, ret;
+
+ gp.param = I915_PARAM_PERF_REVISION;
+ gp.value = &value;
+ ret = igt_ioctl(drm_fd, DRM_IOCTL_I915_GETPARAM, &gp);
+ if (ret == -1) {
+ /* If the param is missing, consider version 1. */
+ igt_assert_eq(errno, EINVAL);
+ return 1;
+ }
+
+ return value;
+}
+
igt_main
{
igt_fixture {
@@ -4584,11 +4620,43 @@ igt_main
igt_subtest("enable-disable")
test_enable_disable();
- igt_subtest("blocking")
- test_blocking();
+ igt_describe("Test blocking read with default hrtimer frequency");
+ igt_subtest("blocking") {
+ test_blocking(40 * 1000 * 1000 /* 40ms oa period */,
+ false /* set_kernel_hrtimer */,
+ 5 * 1000 * 1000 /* default 5ms/200Hz hrtimer */);
+ }
+
+ igt_describe("Test blocking read with different hrtimer frequencies");
+ igt_subtest("blocking-parameterized") {
+ igt_require(i915_perf_revision(drm_fd) >= 4);
+
+ test_blocking(10 * 1000 * 1000 /* 10ms oa period */,
+ true /* set_kernel_hrtimer */,
+ 40 * 1000 * 1000 /* default 40ms hrtimer */);
+ test_blocking(500 * 1000 /* 500us oa period */,
+ true /* set_kernel_hrtimer */,
+ 2 * 1000 * 1000 /* default 2ms hrtimer */);
+ }
- igt_subtest("polling")
- test_polling();
+ igt_describe("Test polled read with default hrtimer frequency");
+ igt_subtest("polling") {
+ test_polling(40 * 1000 * 1000 /* 40ms oa period */,
+ false /* set_kernel_hrtimer */,
+ 5 * 1000 * 1000 /* default 5ms/200Hz hrtimer */);
+ }
+
+ igt_describe("Test polled read with different hrtimer frequencies");
+ igt_subtest("polling-parameterized") {
+ igt_require(i915_perf_revision(drm_fd) >= 4);
+
+ test_polling(10 * 1000 * 1000 /* 10ms oa period */,
+ true /* set_kernel_hrtimer */,
+ 40 * 1000 * 1000 /* default 40ms hrtimer */);
+ test_polling(500 * 1000 /* 500us oa period */,
+ true /* set_kernel_hrtimer */,
+ 2 * 1000 * 1000 /* default 2ms hrtimer */);
+ }
igt_subtest("short-reads")
test_short_reads();
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] tools: Allow user to set poll delay in i915 perf recorder
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 1/3] include/drm-uapi: Update i915_drm.h for perf OA APIs Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling Umesh Nerlige Ramappa
@ 2020-03-13 19:53 ` Umesh Nerlige Ramappa
2020-03-16 9:52 ` Lionel Landwerlin
2020-03-16 12:32 ` [igt-dev] ✗ GitLab.Pipeline: warning for Test configurable poll delay in perf OA (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-03-13 19:53 UTC (permalink / raw)
To: igt-dev, Lionel G Landwerlin, Ashutosh Dixit
Add poll delay parameter to the i915-perf-recorder tool so that the user
can set the frequency of the poll timer that checks for available
reports in the OA buffer.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tools/i915-perf/i915_perf_recorder.c | 37 +++++++++++++++++++++++++---
1 file changed, 34 insertions(+), 3 deletions(-)
diff --git a/tools/i915-perf/i915_perf_recorder.c b/tools/i915-perf/i915_perf_recorder.c
index 6bbc451e..60b7b732 100644
--- a/tools/i915-perf/i915_perf_recorder.c
+++ b/tools/i915-perf/i915_perf_recorder.c
@@ -353,14 +353,31 @@ struct recording_context {
const char *command_fifo;
int command_fifo_fd;
+
+ uint32_t poll_delay;
};
+static int
+perf_revision(int drm_fd)
+{
+ drm_i915_getparam_t gp;
+ int value = 1;
+
+ gp.param = I915_PARAM_PERF_REVISION;
+ gp.value = &value;
+ perf_ioctl(drm_fd, DRM_IOCTL_I915_GETPARAM, &gp);
+
+ return value;
+}
+
static int
perf_open(struct recording_context *ctx)
{
uint64_t properties[DRM_I915_PERF_PROP_MAX * 2];
struct drm_i915_perf_open_param param;
- int p = 0, stream_fd;
+ int p = 0, stream_fd, revision;
+
+ revision = perf_revision(ctx->drm_fd);
properties[p++] = DRM_I915_PERF_PROP_SAMPLE_OA;
properties[p++] = true;
@@ -374,6 +391,11 @@ perf_open(struct recording_context *ctx)
properties[p++] = DRM_I915_PERF_PROP_OA_EXPONENT;
properties[p++] = ctx->oa_exponent;
+ if (revision >= 4) {
+ properties[p++] = DRM_I915_PERF_PROP_POLL_OA_DELAY;
+ properties[p++] = ctx->poll_delay;
+ }
+
memset(¶m, 0, sizeof(param));
param.flags = 0;
param.flags |= I915_PERF_FLAG_FD_CLOEXEC | I915_PERF_FLAG_FD_NONBLOCK;
@@ -720,7 +742,10 @@ usage(const char *name)
" (To use with i915-perf-control)\n"
" --output, -o <path> Output file (default = i915_perf.record)\n"
" --cpu-clock, -k <path> Cpu clock to use for correlations\n"
- " Values: boot, mono, mono_raw (default = mono)\n",
+ " Values: boot, mono, mono_raw (default = mono)\n"
+ " --poll-delay -P <value> Polling interval in microseconds used by a timer in the driver to query\n"
+ " for OA reports periodically\n"
+ " (default = 5000), Minimum = 100.\n",
name);
}
@@ -762,6 +787,7 @@ main(int argc, char *argv[])
{"size", required_argument, 0, 's'},
{"command-fifo", required_argument, 0, 'f'},
{"cpu-clock", required_argument, 0, 'k'},
+ {"poll-delay", required_argument, 0, 'P'},
{0, 0, 0, 0}
};
const struct {
@@ -788,9 +814,11 @@ main(int argc, char *argv[])
.command_fifo = I915_PERF_RECORD_FIFO_PATH,
.command_fifo_fd = -1,
+
+ .poll_delay = 5 * 1000 * 1000,
};
- while ((opt = getopt_long(argc, argv, "hc:p:m:Co:s:f:k:", long_options, NULL)) != -1) {
+ while ((opt = getopt_long(argc, argv, "hc:p:m:Co:s:f:k:P:", long_options, NULL)) != -1) {
switch (opt) {
case 'h':
usage(argv[0]);
@@ -832,6 +860,9 @@ main(int argc, char *argv[])
}
break;
}
+ case 'P':
+ ctx.poll_delay = MAX(100, atoi(optarg)) * 1000;
+ break;
default:
fprintf(stderr, "Internal error: "
"unexpected getopt value: %d\n", opt);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tools: Allow user to set poll delay in i915 perf recorder
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 3/3] tools: Allow user to set poll delay in i915 perf recorder Umesh Nerlige Ramappa
@ 2020-03-16 9:52 ` Lionel Landwerlin
0 siblings, 0 replies; 10+ messages in thread
From: Lionel Landwerlin @ 2020-03-16 9:52 UTC (permalink / raw)
To: Umesh Nerlige Ramappa, igt-dev, Ashutosh Dixit
On 13/03/2020 21:53, Umesh Nerlige Ramappa wrote:
> Add poll delay parameter to the i915-perf-recorder tool so that the user
> can set the frequency of the poll timer that checks for available
> reports in the OA buffer.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Couple of nits below.
Either way :
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Thanks!
> ---
> tools/i915-perf/i915_perf_recorder.c | 37 +++++++++++++++++++++++++---
> 1 file changed, 34 insertions(+), 3 deletions(-)
>
> diff --git a/tools/i915-perf/i915_perf_recorder.c b/tools/i915-perf/i915_perf_recorder.c
> index 6bbc451e..60b7b732 100644
> --- a/tools/i915-perf/i915_perf_recorder.c
> +++ b/tools/i915-perf/i915_perf_recorder.c
> @@ -353,14 +353,31 @@ struct recording_context {
>
> const char *command_fifo;
> int command_fifo_fd;
> +
> + uint32_t poll_delay;
Maybe just use a uint64_t as it's the type used by the kernel interface.
> };
>
> +static int
> +perf_revision(int drm_fd)
> +{
> + drm_i915_getparam_t gp;
> + int value = 1;
> +
> + gp.param = I915_PARAM_PERF_REVISION;
> + gp.value = &value;
> + perf_ioctl(drm_fd, DRM_IOCTL_I915_GETPARAM, &gp);
> +
> + return value;
> +}
> +
> static int
> perf_open(struct recording_context *ctx)
> {
> uint64_t properties[DRM_I915_PERF_PROP_MAX * 2];
> struct drm_i915_perf_open_param param;
> - int p = 0, stream_fd;
> + int p = 0, stream_fd, revision;
> +
> + revision = perf_revision(ctx->drm_fd);
>
> properties[p++] = DRM_I915_PERF_PROP_SAMPLE_OA;
> properties[p++] = true;
> @@ -374,6 +391,11 @@ perf_open(struct recording_context *ctx)
> properties[p++] = DRM_I915_PERF_PROP_OA_EXPONENT;
> properties[p++] = ctx->oa_exponent;
>
> + if (revision >= 4) {
> + properties[p++] = DRM_I915_PERF_PROP_POLL_OA_DELAY;
> + properties[p++] = ctx->poll_delay;
> + }
> +
> memset(¶m, 0, sizeof(param));
> param.flags = 0;
> param.flags |= I915_PERF_FLAG_FD_CLOEXEC | I915_PERF_FLAG_FD_NONBLOCK;
> @@ -720,7 +742,10 @@ usage(const char *name)
> " (To use with i915-perf-control)\n"
> " --output, -o <path> Output file (default = i915_perf.record)\n"
> " --cpu-clock, -k <path> Cpu clock to use for correlations\n"
> - " Values: boot, mono, mono_raw (default = mono)\n",
> + " Values: boot, mono, mono_raw (default = mono)\n"
> + " --poll-delay -P <value> Polling interval in microseconds used by a timer in the driver to query\n"
> + " for OA reports periodically\n"
> + " (default = 5000), Minimum = 100.\n",
> name);
> }
>
> @@ -762,6 +787,7 @@ main(int argc, char *argv[])
> {"size", required_argument, 0, 's'},
> {"command-fifo", required_argument, 0, 'f'},
> {"cpu-clock", required_argument, 0, 'k'},
> + {"poll-delay", required_argument, 0, 'P'},
> {0, 0, 0, 0}
> };
> const struct {
> @@ -788,9 +814,11 @@ main(int argc, char *argv[])
>
> .command_fifo = I915_PERF_RECORD_FIFO_PATH,
> .command_fifo_fd = -1,
> +
> + .poll_delay = 5 * 1000 * 1000,
> };
>
> - while ((opt = getopt_long(argc, argv, "hc:p:m:Co:s:f:k:", long_options, NULL)) != -1) {
> + while ((opt = getopt_long(argc, argv, "hc:p:m:Co:s:f:k:P:", long_options, NULL)) != -1) {
> switch (opt) {
> case 'h':
> usage(argv[0]);
> @@ -832,6 +860,9 @@ main(int argc, char *argv[])
> }
> break;
> }
> + case 'P':
> + ctx.poll_delay = MAX(100, atoi(optarg)) * 1000;
atol() just to be sure?
> + break;
> default:
> fprintf(stderr, "Internal error: "
> "unexpected getopt value: %d\n", opt);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for Test configurable poll delay in perf OA (rev2)
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
` (2 preceding siblings ...)
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 3/3] tools: Allow user to set poll delay in i915 perf recorder Umesh Nerlige Ramappa
@ 2020-03-16 12:32 ` Patchwork
2020-03-16 12:49 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-03-16 17:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-03-16 12:32 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
== Series Details ==
Series: Test configurable poll delay in perf OA (rev2)
URL : https://patchwork.freedesktop.org/series/74655/
State : warning
== Summary ==
Did not get list of undocumented tests for this run, something is wrong!
Other than that, pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/120135 for the overview.
build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/1941150):
Running with gitlab-runner 12.5.0 (577f813d)
on gst-gitlab-htz-runner2 sGiTXgBC
section_start:1584361515:prepare_executor
Using Docker executor with image registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian-mips:commit-2c9542abda7cdbd05b695c6287974c8f51cc2a55 ...
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian-mips:commit-2c9542abda7cdbd05b695c6287974c8f51cc2a55 ...
Using docker image sha256:20ce37ce0dd99e42a1a28192a10ddd453c0dc2ae3056621938b8ec4221e3cf3c for registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian-mips:commit-2c9542abda7cdbd05b695c6287974c8f51cc2a55 ...
section_end:1584361518:prepare_executor
section_start:1584361518:prepare_script
Running on runner-sGiTXgBC-project-3185-concurrent-0 via gst-gitlab-htz-runner2...
section_end:1584361520:prepare_script
section_start:1584361520:get_sources
section_end:1584361520:get_sources
section_start:1584361520:upload_artifacts_on_failure
section_end:1584361522:upload_artifacts_on_failure
ERROR: Job failed (system failure): Error response from daemon: error creating overlay mount to /var/lib/docker/overlay2/945d3c854bf186a8f4d3e9c7ec964f6393595815de03e96745c2b99f42134acf/merged: device or resource busy (executor_docker.go:740:0s)
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/120135
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Test configurable poll delay in perf OA (rev2)
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
` (3 preceding siblings ...)
2020-03-16 12:32 ` [igt-dev] ✗ GitLab.Pipeline: warning for Test configurable poll delay in perf OA (rev2) Patchwork
@ 2020-03-16 12:49 ` Patchwork
2020-03-16 17:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-03-16 12:49 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
== Series Details ==
Series: Test configurable poll delay in perf OA (rev2)
URL : https://patchwork.freedesktop.org/series/74655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8137 -> IGTPW_4304
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/index.html
Known issues
------------
Here are the changes found in IGTPW_4304 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gem_contexts:
- fi-cfl-8700k: [PASS][1] -> [INCOMPLETE][2] ([i915#424])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-cfl-8700k/igt@i915_selftest@live@gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/fi-cfl-8700k/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hangcheck:
- fi-icl-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#108569])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-dsi/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/fi-icl-dsi/igt@i915_selftest@live@hangcheck.html
#### Possible fixes ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][5] ([i915#217]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-kbl-7500u: [FAIL][7] ([i915#323]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
Participating hosts (48 -> 44)
------------------------------
Additional (1): fi-tgl-dsi
Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5510 -> IGTPW_4304
CI-20190529: 20190529
CI_DRM_8137: 5786b5e77cc17a1b494b9bdf3c3f29eedc2e2e7d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4304: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/index.html
IGT_5510: e100092d50105463f58db531fa953c70cc58bb10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@perf@blocking-parameterized
+igt@perf@polling-parameterized
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for Test configurable poll delay in perf OA (rev2)
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
` (4 preceding siblings ...)
2020-03-16 12:49 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-03-16 17:56 ` Patchwork
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-03-16 17:56 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
== Series Details ==
Series: Test configurable poll delay in perf OA (rev2)
URL : https://patchwork.freedesktop.org/series/74655/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8137_full -> IGTPW_4304_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4304_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4304_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4304_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_shared@single-timeline:
- shard-snb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb2/igt@gem_ctx_shared@single-timeline.html
- shard-hsw: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw2/igt@gem_ctx_shared@single-timeline.html
* {igt@perf@blocking-parameterized} (NEW):
- shard-iclb: NOTRUN -> [SKIP][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb1/igt@perf@blocking-parameterized.html
* {igt@perf@polling-parameterized} (NEW):
- shard-tglb: NOTRUN -> [SKIP][4] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb7/igt@perf@polling-parameterized.html
* igt@perf_pmu@busy-no-semaphores-vcs0:
- shard-apl: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl4/igt@perf_pmu@busy-no-semaphores-vcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl4/igt@perf_pmu@busy-no-semaphores-vcs0.html
New tests
---------
New tests have been introduced between CI_DRM_8137_full and IGTPW_4304_full:
### New IGT tests (12) ###
* igt@perf@blocking-parameterized:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@perf@polling-parameterized:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@nopreempt:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@off:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@precise:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@duration:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@timeout:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in IGTPW_4304_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@close-replace-race:
- shard-kbl: [PASS][7] -> [INCOMPLETE][8] ([i915#1402])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl6/igt@gem_ctx_persistence@close-replace-race.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl2/igt@gem_ctx_persistence@close-replace-race.html
- shard-glk: [PASS][9] -> [INCOMPLETE][10] ([i915#1402] / [i915#58] / [k.org#198133])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk3/igt@gem_ctx_persistence@close-replace-race.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk5/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#110841])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@implicit-both-bsd1:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109276] / [i915#677])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb6/igt@gem_exec_schedule@implicit-both-bsd1.html
* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [PASS][15] -> [SKIP][16] ([i915#677])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb7/igt@gem_exec_schedule@pi-userfault-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb2/igt@gem_exec_schedule@pi-userfault-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870] / [i915#478])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@gem_userptr_blits@dmabuf-unsync.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb5/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@gem_workarounds@suspend-resume-fd.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl6/igt@gem_workarounds@suspend-resume-fd.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-snb: [PASS][23] -> [SKIP][24] ([fdo#109271]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#49])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#899])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-x.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][33] -> [FAIL][34] ([i915#31])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk2/igt@kms_setmode@basic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk1/igt@kms_setmode@basic.html
- shard-kbl: [PASS][35] -> [FAIL][36] ([i915#31])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl7/igt@kms_setmode@basic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl6/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-rpm:
- shard-tglb: [PASS][37] -> [SKIP][38] ([fdo#112015])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb8/igt@kms_vblank@pipe-d-ts-continuation-dpms-rpm.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-dpms-rpm.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#112080]) +6 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@perf_pmu@init-busy-vcs1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb5/igt@perf_pmu@init-busy-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109276]) +16 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb3/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-snb: [FAIL][43] -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@gem_ctx_isolation@rcs0-s3.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb2/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][45] ([fdo#112080]) -> [PASS][46] +11 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@gem_ctx_isolation@vcs1-dirty-create.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_persistence@close-replace-race:
- shard-tglb: [INCOMPLETE][47] ([i915#1402]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@gem_ctx_persistence@close-replace-race.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb6/igt@gem_ctx_persistence@close-replace-race.html
- shard-apl: [INCOMPLETE][49] ([fdo#103927] / [i915#1402]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl1/igt@gem_ctx_persistence@close-replace-race.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl2/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][51] ([fdo#110854]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@gem_exec_balancer@smoke.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_parallel@bcs0-fds:
- shard-apl: [FAIL][53] -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@gem_exec_parallel@bcs0-fds.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl8/igt@gem_exec_parallel@bcs0-fds.html
- shard-iclb: [FAIL][55] -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@gem_exec_parallel@bcs0-fds.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb1/igt@gem_exec_parallel@bcs0-fds.html
- shard-tglb: [FAIL][57] -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@gem_exec_parallel@bcs0-fds.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb1/igt@gem_exec_parallel@bcs0-fds.html
- shard-glk: [FAIL][59] -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@gem_exec_parallel@bcs0-fds.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk9/igt@gem_exec_parallel@bcs0-fds.html
* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [SKIP][61] ([fdo#109276] / [i915#677]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@gem_exec_schedule@implicit-read-write-bsd1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb2/igt@gem_exec_schedule@implicit-read-write-bsd1.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][63] ([i915#677]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb3/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][65] ([fdo#109276]) -> [PASS][66] +17 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preempt-hang-render:
- shard-apl: [SKIP][67] ([fdo#109271]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@gem_exec_schedule@preempt-hang-render.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl8/igt@gem_exec_schedule@preempt-hang-render.html
- shard-glk: [SKIP][69] ([fdo#109271]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@gem_exec_schedule@preempt-hang-render.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk1/igt@gem_exec_schedule@preempt-hang-render.html
- shard-iclb: [SKIP][71] -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@gem_exec_schedule@preempt-hang-render.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb4/igt@gem_exec_schedule@preempt-hang-render.html
- shard-tglb: [SKIP][73] -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@gem_exec_schedule@preempt-hang-render.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb3/igt@gem_exec_schedule@preempt-hang-render.html
- shard-kbl: [SKIP][75] ([fdo#109271]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl7/igt@gem_exec_schedule@preempt-hang-render.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl3/igt@gem_exec_schedule@preempt-hang-render.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][77] ([fdo#112146]) -> [PASS][78] +4 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb8/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [DMESG-WARN][79] ([fdo#111870] / [i915#478]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@gem_userptr_blits@sync-unmap-after-close.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][81] ([i915#180]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][83] ([i915#447]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb1/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_rpm@system-suspend-devices:
- shard-iclb: [SKIP][85] ([i915#1316]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@i915_pm_rpm@system-suspend-devices.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb6/igt@i915_pm_rpm@system-suspend-devices.html
- shard-hsw: [SKIP][87] ([fdo#109271]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@i915_pm_rpm@system-suspend-devices.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw7/igt@i915_pm_rpm@system-suspend-devices.html
- shard-tglb: [SKIP][89] ([i915#1316]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb6/igt@i915_pm_rpm@system-suspend-devices.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb5/igt@i915_pm_rpm@system-suspend-devices.html
* igt@i915_pm_rps@waitboost:
- shard-tglb: [FAIL][91] ([i915#413]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@i915_pm_rps@waitboost.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb6/igt@i915_pm_rps@waitboost.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][93] ([i915#72]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-kbl: [FAIL][95] ([i915#49]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
- shard-glk: [FAIL][97] ([i915#49]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-glk9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
- shard-apl: [FAIL][99] ([i915#49]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-snb: [DMESG-WARN][101] ([i915#478]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][103] ([fdo#109441]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-d-ts-continuation-modeset-hang:
- shard-tglb: [SKIP][105] ([fdo#112015]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-modeset-hang.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-modeset-hang.html
* igt@perf_pmu@most-busy-idle-check-all-bcs0:
- shard-hsw: [FAIL][107] -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@perf_pmu@most-busy-idle-check-all-bcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw7/igt@perf_pmu@most-busy-idle-check-all-bcs0.html
#### Warnings ####
* igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt:
- shard-hsw: [DMESG-WARN][109] ([fdo#110789] / [i915#478]) -> [DMESG-WARN][110] ([i915#478])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [SKIP][111] ([i915#468]) -> [FAIL][112] ([i915#454])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-tglb1/igt@i915_pm_dc@dc6-dpms.html
* igt@runner@aborted:
- shard-hsw: ([FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120]) ([fdo#111870]) -> ([FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127]) ([fdo#109271] / [fdo#111870])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw6/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw7/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw6/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw2/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw1/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw2/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw6/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw2/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw5/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw2/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw7/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw1/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-hsw4/igt@runner@aborted.html
- shard-kbl: [FAIL][128] ([i915#92]) -> ([FAIL][129], [FAIL][130]) ([i915#1389] / [i915#1402] / [i915#92])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl3/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl7/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-kbl2/igt@runner@aborted.html
- shard-apl: ([FAIL][131], [FAIL][132]) ([fdo#103927] / [i915#1402]) -> [FAIL][133] ([fdo#103927])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl3/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl1/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-apl4/igt@runner@aborted.html
- shard-snb: ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([fdo#111870] / [i915#1077] / [i915#698]) -> ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150]) ([fdo#111870] / [i915#1077])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb2/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb6/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb5/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb4/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb5/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb4/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb2/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb6/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/shard-snb4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112015]: https://bugs.freedesktop.org/show_bug.cgi?id=112015
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1077]: https://gitlab.freedesktop.org/drm/intel/issues/1077
[i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
[i915#1389]: https://gitlab.freedesktop.org/drm/intel/issues/1389
[i915#1402]: https://gitlab.freedesktop.org/drm/intel/issues/1402
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5510 -> IGTPW_4304
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8137: 5786b5e77cc17a1b494b9bdf3c3f29eedc2e2e7d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4304: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/index.html
IGT_5510: e100092d50105463f58db531fa953c70cc58bb10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4304/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling
2020-03-19 22:52 ` [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling Umesh Nerlige Ramappa
@ 2020-03-25 19:37 ` Dixit, Ashutosh
0 siblings, 0 replies; 10+ messages in thread
From: Dixit, Ashutosh @ 2020-03-25 19:37 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
On Thu, 19 Mar 2020 15:52:53 -0700, Umesh Nerlige Ramappa wrote:
>
> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> 2 new tests verifying that the OA buffer is properly checked at the
> frequency specified by userspace.
>
> v2: (Umesh)
> - Capture start_times in test_polling
> - Second parameterized test used a 500us hrtimer. Occassionally, this
> timing does not fall within the duration/100 requirement for the time
> spent in kernel. Change this value to 2ms to accommodate all
> platforms.
>
> v3: (Lionel)
> - Use NUM_PROPERTIES
>
> v4: (Umesh)
> - Update poll parameter name
> - Update perf revision check to 5 in new tests
> - Fix oa sampling rate message in igt_debug prints
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> tests/perf.c | 144 +++++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 106 insertions(+), 38 deletions(-)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling
2020-03-19 22:52 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
@ 2020-03-19 22:52 ` Umesh Nerlige Ramappa
2020-03-25 19:37 ` Dixit, Ashutosh
0 siblings, 1 reply; 10+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-03-19 22:52 UTC (permalink / raw)
To: igt-dev, Lionel G Landwerlin, Ashutosh Dixit
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
2 new tests verifying that the OA buffer is properly checked at the
frequency specified by userspace.
v2: (Umesh)
- Capture start_times in test_polling
- Second parameterized test used a 500us hrtimer. Occassionally, this
timing does not fall within the duration/100 requirement for the time
spent in kernel. Change this value to 2ms to accommodate all
platforms.
v3: (Lionel)
- Use NUM_PROPERTIES
v4: (Umesh)
- Update poll parameter name
- Update perf revision check to 5 in new tests
- Fix oa sampling rate message in igt_debug prints
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/perf.c | 144 +++++++++++++++++++++++++++++++++++++--------------
1 file changed, 106 insertions(+), 38 deletions(-)
diff --git a/tests/perf.c b/tests/perf.c
index 724f6f80..8f6537d6 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -234,6 +234,24 @@ get_oa_format(enum drm_i915_oa_format format)
return gen8_oa_formats[format];
}
+static char *
+pretty_print_oa_period(uint64_t oa_period_ns)
+{
+ static char result[100];
+ static const char *units[4] = { "ns", "us", "ms", "s" };
+ double val = oa_period_ns;
+ int iter = 0;
+
+ while (iter < (ARRAY_SIZE(units) - 1) &&
+ val >= 1000.0f) {
+ val /= 1000.0f;
+ iter++;
+ }
+
+ snprintf(result, sizeof(result), "%.3f%s", val, units[iter]);
+ return result;
+}
+
static void
__perf_close(int fd)
{
@@ -1921,15 +1939,9 @@ get_time(void)
* kernelspace.
*/
static void
-test_blocking(void)
+test_blocking(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t kernel_hrtimer)
{
- /* ~40 milliseconds
- *
- * Having a period somewhat > sysconf(_SC_CLK_TCK) helps to stop
- * scheduling (liable to kick in when we make blocking poll()s/reads)
- * from interfering with the test.
- */
- int oa_exponent = max_oa_exponent_for_period_lte(40000000);
+ int oa_exponent = max_oa_exponent_for_period_lte(requested_oa_period);
uint64_t oa_period = oa_exponent_to_ns(oa_exponent);
uint64_t properties[] = {
/* Include OA reports in samples */
@@ -1939,11 +1951,16 @@ test_blocking(void)
DRM_I915_PERF_PROP_OA_METRICS_SET, test_set->perf_oa_metrics_set,
DRM_I915_PERF_PROP_OA_FORMAT, test_set->perf_oa_format,
DRM_I915_PERF_PROP_OA_EXPONENT, oa_exponent,
+
+ /* Kernel configuration (optional) */
+ DRM_I915_PERF_PROP_POLL_OA_PERIOD, kernel_hrtimer,
};
struct drm_i915_perf_open_param param = {
.flags = I915_PERF_FLAG_FD_CLOEXEC |
I915_PERF_FLAG_DISABLED,
- .num_properties = sizeof(properties) / 16,
+ .num_properties = set_kernel_hrtimer ?
+ NUM_PROPERTIES(properties) :
+ NUM_PROPERTIES(properties) - 1,
.properties_ptr = to_user_pointer(properties),
};
uint8_t buf[1024 * 1024];
@@ -1965,7 +1982,7 @@ test_blocking(void)
* the knowledge that that the driver uses a 200Hz hrtimer (5ms period)
* to check for data and giving some time to read().
*/
- int min_iterations = (test_duration_ns / (oa_period + 6000000ull));
+ int min_iterations = (test_duration_ns / (oa_period + kernel_hrtimer + kernel_hrtimer / 5));
int64_t start, end;
int n = 0;
@@ -1975,9 +1992,10 @@ test_blocking(void)
times(&start_times);
igt_debug("tick length = %dns, test duration = %"PRIu64"ns, min iter. = %d,"
- " estimated max iter. = %d, oa_period = %"PRIu64"ns\n",
+ " estimated max iter. = %d, oa_period = %s\n",
(int)tick_ns, test_duration_ns,
- min_iterations, max_iterations, oa_period);
+ min_iterations, max_iterations,
+ pretty_print_oa_period(oa_period));
/* In the loop we perform blocking polls while the HW is sampling at
* ~25Hz, with the expectation that we spend most of our time blocked
@@ -2052,8 +2070,8 @@ test_blocking(void)
user_ns = (end_times.tms_utime - start_times.tms_utime) * tick_ns;
kernel_ns = (end_times.tms_stime - start_times.tms_stime) * tick_ns;
- igt_debug("%d blocking reads during test with ~25Hz OA sampling (expect no more than %d)\n",
- n, max_iterations);
+ igt_debug("%d blocking reads during test with %lu Hz OA sampling (expect no more than %d)\n",
+ n, NSEC_PER_SEC / oa_period, max_iterations);
igt_debug("%d extra iterations seen, not related to periodic sampling (e.g. context switches)\n",
n_extra_iterations);
igt_debug("time in userspace = %"PRIu64"ns (+-%dns) (start utime = %d, end = %d)\n",
@@ -2079,15 +2097,9 @@ test_blocking(void)
}
static void
-test_polling(void)
+test_polling(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t kernel_hrtimer)
{
- /* ~40 milliseconds
- *
- * Having a period somewhat > sysconf(_SC_CLK_TCK) helps to stop
- * scheduling (liable to kick in when we make blocking poll()s/reads)
- * from interfering with the test.
- */
- int oa_exponent = max_oa_exponent_for_period_lte(40000000);
+ int oa_exponent = max_oa_exponent_for_period_lte(requested_oa_period);
uint64_t oa_period = oa_exponent_to_ns(oa_exponent);
uint64_t properties[] = {
/* Include OA reports in samples */
@@ -2097,12 +2109,17 @@ test_polling(void)
DRM_I915_PERF_PROP_OA_METRICS_SET, test_set->perf_oa_metrics_set,
DRM_I915_PERF_PROP_OA_FORMAT, test_set->perf_oa_format,
DRM_I915_PERF_PROP_OA_EXPONENT, oa_exponent,
+
+ /* Kernel configuration (optional) */
+ DRM_I915_PERF_PROP_POLL_OA_PERIOD, kernel_hrtimer,
};
struct drm_i915_perf_open_param param = {
.flags = I915_PERF_FLAG_FD_CLOEXEC |
I915_PERF_FLAG_DISABLED |
I915_PERF_FLAG_FD_NONBLOCK,
- .num_properties = sizeof(properties) / 16,
+ .num_properties = set_kernel_hrtimer ?
+ NUM_PROPERTIES(properties) :
+ NUM_PROPERTIES(properties) - 1,
.properties_ptr = to_user_pointer(properties),
};
uint8_t buf[1024 * 1024];
@@ -2116,15 +2133,16 @@ test_polling(void)
int n_extra_iterations = 0;
/* It's a bit tricky to put a lower limit here, but we expect a
- * relatively low latency for seeing reports, while we don't currently
- * give any control over this in the api.
+ * relatively low latency for seeing reports.
*
- * We assume a maximum latency of 6 millisecond to deliver a POLLIN and
- * read() after a new sample is written (46ms per iteration) considering
- * the knowledge that that the driver uses a 200Hz hrtimer (5ms period)
- * to check for data and giving some time to read().
+ * We assume a maximum latency of kernel_hrtimer + some margin
+ * to deliver a POLLIN and read() after a new sample is
+ * written (40ms + hrtimer + margin per iteration) considering
+ * the knowledge that that the driver uses a 200Hz hrtimer
+ * (5ms period) to check for data and giving some time to
+ * read().
*/
- int min_iterations = (test_duration_ns / (oa_period + 6000000ull));
+ int min_iterations = (test_duration_ns / (oa_period + (kernel_hrtimer + kernel_hrtimer / 5)));
int64_t start, end;
int n = 0;
@@ -2132,8 +2150,9 @@ test_polling(void)
times(&start_times);
- igt_debug("tick length = %dns, test duration = %"PRIu64"ns, min iter. = %d, max iter. = %d\n",
- (int)tick_ns, test_duration_ns,
+ igt_debug("tick length = %dns, oa period = %s, "
+ "test duration = %"PRIu64"ns, min iter. = %d, max iter. = %d\n",
+ (int)tick_ns, pretty_print_oa_period(oa_period), test_duration_ns,
min_iterations, max_iterations);
/* In the loop we perform blocking polls while the HW is sampling at
@@ -2239,8 +2258,8 @@ test_polling(void)
user_ns = (end_times.tms_utime - start_times.tms_utime) * tick_ns;
kernel_ns = (end_times.tms_stime - start_times.tms_stime) * tick_ns;
- igt_debug("%d blocking reads during test with ~25Hz OA sampling (expect no more than %d)\n",
- n, max_iterations);
+ igt_debug("%d non-blocking reads during test with %lu Hz OA sampling (expect no more than %d)\n",
+ n, NSEC_PER_SEC / oa_period, max_iterations);
igt_debug("%d extra iterations seen, not related to periodic sampling (e.g. context switches)\n",
n_extra_iterations);
igt_debug("time in userspace = %"PRIu64"ns (+-%dns) (start utime = %d, end = %d)\n",
@@ -4588,6 +4607,23 @@ test_sysctl_defaults(void)
igt_assert_eq(max_freq, 100000);
}
+static int i915_perf_revision(int fd)
+{
+ drm_i915_getparam_t gp;
+ int value = 1, ret;
+
+ gp.param = I915_PARAM_PERF_REVISION;
+ gp.value = &value;
+ ret = igt_ioctl(drm_fd, DRM_IOCTL_I915_GETPARAM, &gp);
+ if (ret == -1) {
+ /* If the param is missing, consider version 1. */
+ igt_assert_eq(errno, EINVAL);
+ return 1;
+ }
+
+ return value;
+}
+
igt_main
{
igt_fixture {
@@ -4670,11 +4706,43 @@ igt_main
igt_subtest("enable-disable")
test_enable_disable();
- igt_subtest("blocking")
- test_blocking();
+ igt_describe("Test blocking read with default hrtimer frequency");
+ igt_subtest("blocking") {
+ test_blocking(40 * 1000 * 1000 /* 40ms oa period */,
+ false /* set_kernel_hrtimer */,
+ 5 * 1000 * 1000 /* default 5ms/200Hz hrtimer */);
+ }
+
+ igt_describe("Test blocking read with different hrtimer frequencies");
+ igt_subtest("blocking-parameterized") {
+ igt_require(i915_perf_revision(drm_fd) >= 5);
+
+ test_blocking(10 * 1000 * 1000 /* 10ms oa period */,
+ true /* set_kernel_hrtimer */,
+ 40 * 1000 * 1000 /* default 40ms hrtimer */);
+ test_blocking(500 * 1000 /* 500us oa period */,
+ true /* set_kernel_hrtimer */,
+ 2 * 1000 * 1000 /* default 2ms hrtimer */);
+ }
- igt_subtest("polling")
- test_polling();
+ igt_describe("Test polled read with default hrtimer frequency");
+ igt_subtest("polling") {
+ test_polling(40 * 1000 * 1000 /* 40ms oa period */,
+ false /* set_kernel_hrtimer */,
+ 5 * 1000 * 1000 /* default 5ms/200Hz hrtimer */);
+ }
+
+ igt_describe("Test polled read with different hrtimer frequencies");
+ igt_subtest("polling-parameterized") {
+ igt_require(i915_perf_revision(drm_fd) >= 5);
+
+ test_polling(10 * 1000 * 1000 /* 10ms oa period */,
+ true /* set_kernel_hrtimer */,
+ 40 * 1000 * 1000 /* default 40ms hrtimer */);
+ test_polling(500 * 1000 /* 500us oa period */,
+ true /* set_kernel_hrtimer */,
+ 2 * 1000 * 1000 /* default 2ms hrtimer */);
+ }
igt_subtest("short-reads")
test_short_reads();
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-25 19:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 19:53 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 1/3] include/drm-uapi: Update i915_drm.h for perf OA APIs Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling Umesh Nerlige Ramappa
2020-03-13 19:53 ` [igt-dev] [PATCH i-g-t 3/3] tools: Allow user to set poll delay in i915 perf recorder Umesh Nerlige Ramappa
2020-03-16 9:52 ` Lionel Landwerlin
2020-03-16 12:32 ` [igt-dev] ✗ GitLab.Pipeline: warning for Test configurable poll delay in perf OA (rev2) Patchwork
2020-03-16 12:49 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-03-16 17:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-19 22:52 [igt-dev] [PATCH i-g-t 0/3] Test configurable poll delay in perf OA Umesh Nerlige Ramappa
2020-03-19 22:52 ` [igt-dev] [PATCH i-g-t 2/3] tests/perf: new tests for parameterized OA buffer polling Umesh Nerlige Ramappa
2020-03-25 19:37 ` Dixit, Ashutosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.