* [PATCH net v2] net: broadcom: Select BROADCOM_PHY for BCMGENET
@ 2020-05-13 15:51 Florian Fainelli
2020-05-13 19:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2020-05-13 15:51 UTC (permalink / raw)
To: netdev
Cc: m.szyprowski, nsaenzjulienne, wahrenst, Florian Fainelli,
David S. Miller, Michael Chan, Saeed Mahameed, Andy Gospodarek,
Randy Dunlap, Geert Uytterhoeven, Thomas Gleixner, Tal Gilboa,
open list
The GENET controller on the Raspberry Pi 4 (2711) is typically
interfaced with an external Broadcom PHY via a RGMII electrical
interface. To make sure that delays are properly configured at the PHY
side, ensure that we the dedicated Broadcom PHY driver
(CONFIG_BROADCOM_PHY) is enabled for this to happen.
Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- use select instead of imply
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 53055ce5dfd6..2a69c0d06f3c 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -69,6 +69,7 @@ config BCMGENET
select BCM7XXX_PHY
select MDIO_BCM_UNIMAC
select DIMLIB
+ select BROADCOM_PHY if ARCH_BCM2835
help
This driver supports the built-in Ethernet MACs found in the
Broadcom BCM7xxx Set Top Box family chipset.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] net: broadcom: Select BROADCOM_PHY for BCMGENET
2020-05-13 15:51 [PATCH net v2] net: broadcom: Select BROADCOM_PHY for BCMGENET Florian Fainelli
@ 2020-05-13 19:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-13 19:49 UTC (permalink / raw)
To: f.fainelli
Cc: netdev, m.szyprowski, nsaenzjulienne, wahrenst, michael.chan,
saeedm, gospo, rdunlap, geert+renesas, tglx, talgi, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 13 May 2020 08:51:51 -0700
> The GENET controller on the Raspberry Pi 4 (2711) is typically
> interfaced with an external Broadcom PHY via a RGMII electrical
> interface. To make sure that delays are properly configured at the PHY
> side, ensure that we the dedicated Broadcom PHY driver
> (CONFIG_BROADCOM_PHY) is enabled for this to happen.
>
> Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed")
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied and queued up for -stable, thanks Florian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 15:51 [PATCH net v2] net: broadcom: Select BROADCOM_PHY for BCMGENET Florian Fainelli
2020-05-13 19:49 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.