* [PATCH] mdcheck: Log when done
@ 2020-05-13 13:16 Paul Menzel
2020-05-14 15:09 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Paul Menzel @ 2020-05-13 13:16 UTC (permalink / raw)
To: Jes Sorensen; +Cc: Donald Buczek, linux-raid, Paul Menzel
From: Donald Buczek <buczek@molgen.mpg.de>
Currently mdcheck (when called with `--duration`) logs only the
beginning of the check, the pausing and the continuation but not the
completion.
So, log the completion, too, so that it can be determined how long the
raid check took.
2020-05-08T18:00:02+02:00 deadpool root: mdcheck start checking /dev/md0
2020-05-08T18:00:02+02:00 deadpool root: mdcheck start checking /dev/md1
2020-05-09T15:32:04+02:00 deadpool root: mdcheck finished checking /dev/md1
2020-05-09T17:38:04+02:00 deadpool root: mdcheck finished checking /dev/md0
Cc: linux-raid@vger.kernel.org
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
misc/mdcheck | 2 ++
1 file changed, 2 insertions(+)
diff --git a/misc/mdcheck b/misc/mdcheck
index 42d4094..700c3e2 100644
--- a/misc/mdcheck
+++ b/misc/mdcheck
@@ -125,11 +125,13 @@ do
do
eval fl=\$MD_${i}_fl
eval sys=\$MD_${i}_sys
+ eval dev=\$MD_${i}_dev
if [ -z "$fl" ]; then continue; fi
if [ "`cat $sys/md/sync_action`" != 'check' ]
then
+ logger -p daemon.info mdcheck finished checking $dev
eval MD_${i}_fl=
rm -f $fl
continue;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mdcheck: Log when done
2020-05-13 13:16 [PATCH] mdcheck: Log when done Paul Menzel
@ 2020-05-14 15:09 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2020-05-14 15:09 UTC (permalink / raw)
To: Paul Menzel, Jes Sorensen; +Cc: Donald Buczek, linux-raid
On 5/13/20 9:16 AM, Paul Menzel wrote:
> From: Donald Buczek <buczek@molgen.mpg.de>
>
> Currently mdcheck (when called with `--duration`) logs only the
> beginning of the check, the pausing and the continuation but not the
> completion.
>
> So, log the completion, too, so that it can be determined how long the
> raid check took.
>
> 2020-05-08T18:00:02+02:00 deadpool root: mdcheck start checking /dev/md0
> 2020-05-08T18:00:02+02:00 deadpool root: mdcheck start checking /dev/md1
> 2020-05-09T15:32:04+02:00 deadpool root: mdcheck finished checking /dev/md1
> 2020-05-09T17:38:04+02:00 deadpool root: mdcheck finished checking /dev/md0
>
> Cc: linux-raid@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-14 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 13:16 [PATCH] mdcheck: Log when done Paul Menzel
2020-05-14 15:09 ` Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.