From: Jonathan Cameron <jic23@kernel.org> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: <linux-iio@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-kernel@vger.kernel.org>, <ludovic.desroches@microchip.com>, <eugen.hristev@microchip.com>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <alexandre.torgue@st.com>, <mcoquelin.stm32@gmail.com>, <ak@it-klinger.de> Subject: Re: [PATCH v2 1/8] iio: proximity: ping: pass reference to IIO device via call-stack Date: Sat, 16 May 2020 18:12:44 +0100 [thread overview] Message-ID: <20200516181244.4d22c60b@archlinux> (raw) In-Reply-To: <20200514131710.84201-2-alexandru.ardelean@analog.com> On Thu, 14 May 2020 16:17:03 +0300 Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > Since there will be some changes to how iio_priv_to_dev() is implemented, > it could be that the helper becomes a bit slower, as it will be hidden away > in the IIO core. > > For this driver, the IIO device can be passed directly as a parameter to > the ping_read() function, thus making it immune to the change of > iio_priv_to_dev(). > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Patch makes sense and I should have spotted this one during original review :( Going backwards and forwards is never a good idea even without the rework you have. But... (you knew that was coming :), there is no need to pass data to the the read function. It is the structure returned by iio_priv() and not used anywhere else in the read_raw callback. So might as well just pass the iio_dev and get the data structure with in the read function via iio_priv(indio_dev) Thanks, J > --- > drivers/iio/proximity/ping.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/proximity/ping.c b/drivers/iio/proximity/ping.c > index 12b893c5b0ee..ddc43a5a2ef8 100644 > --- a/drivers/iio/proximity/ping.c > +++ b/drivers/iio/proximity/ping.c > @@ -89,14 +89,13 @@ static irqreturn_t ping_handle_irq(int irq, void *dev_id) > return IRQ_HANDLED; > } > > -static int ping_read(struct ping_data *data) > +static int ping_read(struct iio_dev *indio_dev, struct ping_data *data) > { > int ret; > ktime_t ktime_dt; > s64 dt_ns; > u32 time_ns, distance_mm; > struct platform_device *pdev = to_platform_device(data->dev); > - struct iio_dev *indio_dev = iio_priv_to_dev(data); > > /* > * just one read-echo-cycle can take place at a time > @@ -236,7 +235,7 @@ static int ping_read_raw(struct iio_dev *indio_dev, > > switch (info) { > case IIO_CHAN_INFO_RAW: > - ret = ping_read(data); > + ret = ping_read(indio_dev, data); > if (ret < 0) > return ret; > *val = ret;
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: alexandre.belloni@bootlin.com, alexandre.torgue@st.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, ak@it-klinger.de, mcoquelin.stm32@gmail.com, eugen.hristev@microchip.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/8] iio: proximity: ping: pass reference to IIO device via call-stack Date: Sat, 16 May 2020 18:12:44 +0100 [thread overview] Message-ID: <20200516181244.4d22c60b@archlinux> (raw) In-Reply-To: <20200514131710.84201-2-alexandru.ardelean@analog.com> On Thu, 14 May 2020 16:17:03 +0300 Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > Since there will be some changes to how iio_priv_to_dev() is implemented, > it could be that the helper becomes a bit slower, as it will be hidden away > in the IIO core. > > For this driver, the IIO device can be passed directly as a parameter to > the ping_read() function, thus making it immune to the change of > iio_priv_to_dev(). > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Patch makes sense and I should have spotted this one during original review :( Going backwards and forwards is never a good idea even without the rework you have. But... (you knew that was coming :), there is no need to pass data to the the read function. It is the structure returned by iio_priv() and not used anywhere else in the read_raw callback. So might as well just pass the iio_dev and get the data structure with in the read function via iio_priv(indio_dev) Thanks, J > --- > drivers/iio/proximity/ping.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/proximity/ping.c b/drivers/iio/proximity/ping.c > index 12b893c5b0ee..ddc43a5a2ef8 100644 > --- a/drivers/iio/proximity/ping.c > +++ b/drivers/iio/proximity/ping.c > @@ -89,14 +89,13 @@ static irqreturn_t ping_handle_irq(int irq, void *dev_id) > return IRQ_HANDLED; > } > > -static int ping_read(struct ping_data *data) > +static int ping_read(struct iio_dev *indio_dev, struct ping_data *data) > { > int ret; > ktime_t ktime_dt; > s64 dt_ns; > u32 time_ns, distance_mm; > struct platform_device *pdev = to_platform_device(data->dev); > - struct iio_dev *indio_dev = iio_priv_to_dev(data); > > /* > * just one read-echo-cycle can take place at a time > @@ -236,7 +235,7 @@ static int ping_read_raw(struct iio_dev *indio_dev, > > switch (info) { > case IIO_CHAN_INFO_RAW: > - ret = ping_read(data); > + ret = ping_read(indio_dev, data); > if (ret < 0) > return ret; > *val = ret; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-16 17:13 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 13:17 [PATCH v2 0/8] iio: core: wrap IIO device into an iio_dev_opaque object Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-14 13:17 ` [PATCH v2 1/8] iio: proximity: ping: pass reference to IIO device via call-stack Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-16 17:12 ` Jonathan Cameron [this message] 2020-05-16 17:12 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 2/8] iio: at91-sama5d2_adc: pass ref to IIO device via param for int function Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-16 17:15 ` Jonathan Cameron 2020-05-16 17:15 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 3/8] iio: at91_adc: " Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-16 17:17 ` Jonathan Cameron 2020-05-16 17:17 ` Jonathan Cameron 2020-05-18 8:32 ` Ardelean, Alexandru 2020-05-18 8:32 ` Ardelean, Alexandru 2020-05-21 18:19 ` Jonathan Cameron 2020-05-21 18:19 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 4/8] iio: stm32-dfsdm-adc: pass iio device as arg for the interrupt handler Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-16 17:20 ` Jonathan Cameron 2020-05-16 17:20 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 5/8] iio: stm32-adc: " Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-16 17:21 ` Jonathan Cameron 2020-05-16 17:21 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 6/8] iio: core: wrap IIO device into an iio_dev_opaque object Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-16 17:28 ` Jonathan Cameron 2020-05-16 17:28 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 7/8] iio: core: simplify alloc alignment code Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-15 7:12 ` Sa, Nuno 2020-05-15 7:12 ` Sa, Nuno 2020-05-15 11:47 ` Ardelean, Alexandru 2020-05-15 11:47 ` Ardelean, Alexandru 2020-05-15 12:37 ` Sa, Nuno 2020-05-15 12:37 ` Sa, Nuno 2020-05-16 17:30 ` Jonathan Cameron 2020-05-16 17:30 ` Jonathan Cameron 2020-05-14 13:17 ` [PATCH v2 8/8] iio: core: move debugfs data on the private iio dev info Alexandru Ardelean 2020-05-14 13:17 ` Alexandru Ardelean 2020-05-22 6:58 ` [PATCH v2 0/8] iio: core: wrap IIO device into an iio_dev_opaque object Ardelean, Alexandru 2020-05-22 6:58 ` Ardelean, Alexandru
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200516181244.4d22c60b@archlinux \ --to=jic23@kernel.org \ --cc=ak@it-klinger.de \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=alexandru.ardelean@analog.com \ --cc=eugen.hristev@microchip.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=ludovic.desroches@microchip.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=nicolas.ferre@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.