* [PATCH] mt76: mt7915: fix locking bug in mt7915_sta_rc_update()
@ 2020-05-20 12:05 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-05-20 12:05 UTC (permalink / raw)
To: Felix Fietkau, Ryder Lee
Cc: Lorenzo Bianconi, Kalle Valo, Jakub Kicinski, Matthias Brugger,
YF Luo, Shayne Chen, Yiwei Chung, Chih-Min Chen, linux-wireless,
linux-mediatek, kernel-janitors
This function calls rcu_read_lock() twice instead of unlocking.
Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
index 98567374c2c9..3f00f5439c7c 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
@@ -790,7 +790,7 @@ mt7915_sta_rc_update(struct ieee80211_hw *hw,
rcu_read_unlock();
return;
}
- rcu_read_lock();
+ rcu_read_unlock();
set_bit(changed, &msta->stats.changed);
ieee80211_queue_work(hw, &msta->stats_work);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mt76: mt7915: fix locking bug in mt7915_sta_rc_update()
@ 2020-05-20 12:05 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-05-20 12:05 UTC (permalink / raw)
To: Felix Fietkau, Ryder Lee
Cc: kernel-janitors, linux-wireless, YF Luo, Chih-Min Chen,
Matthias Brugger, Yiwei Chung, linux-mediatek, Lorenzo Bianconi,
Jakub Kicinski, Kalle Valo, Shayne Chen
This function calls rcu_read_lock() twice instead of unlocking.
Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
index 98567374c2c9..3f00f5439c7c 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
@@ -790,7 +790,7 @@ mt7915_sta_rc_update(struct ieee80211_hw *hw,
rcu_read_unlock();
return;
}
- rcu_read_lock();
+ rcu_read_unlock();
set_bit(changed, &msta->stats.changed);
ieee80211_queue_work(hw, &msta->stats_work);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mt76: mt7915: fix locking bug in mt7915_sta_rc_update()
@ 2020-05-20 12:05 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-05-20 12:05 UTC (permalink / raw)
To: Felix Fietkau, Ryder Lee
Cc: kernel-janitors, linux-wireless, YF Luo, Chih-Min Chen,
Matthias Brugger, Yiwei Chung, linux-mediatek, Lorenzo Bianconi,
Jakub Kicinski, Kalle Valo, Shayne Chen
This function calls rcu_read_lock() twice instead of unlocking.
Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
index 98567374c2c9..3f00f5439c7c 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
@@ -790,7 +790,7 @@ mt7915_sta_rc_update(struct ieee80211_hw *hw,
rcu_read_unlock();
return;
}
- rcu_read_lock();
+ rcu_read_unlock();
set_bit(changed, &msta->stats.changed);
ieee80211_queue_work(hw, &msta->stats_work);
--
2.26.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-20 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 12:05 [PATCH] mt76: mt7915: fix locking bug in mt7915_sta_rc_update() Dan Carpenter
2020-05-20 12:05 ` Dan Carpenter
2020-05-20 12:05 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.