From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
computersforpeace@gmail.com, kdasu.kdev@gmail.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sumit.semwal@linaro.org, linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4] mtd: rawnand: brcmnand: correctly verify erased pages
Date: Sun, 24 May 2020 21:16:58 +0200 [thread overview]
Message-ID: <20200524191658.29742-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20200512082451.771212-1-noltari@gmail.com>
On Tue, 2020-05-12 at 08:24:51 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote:
> The current code checks that the whole OOB area is erased.
> This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will
> fail due to the usable OOB bytes not being 0xff.
> Correct this by only checking that data and ECC bytes aren't 0xff.
>
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
computersforpeace@gmail.com, kdasu.kdev@gmail.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sumit.semwal@linaro.org, linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4] mtd: rawnand: brcmnand: correctly verify erased pages
Date: Sun, 24 May 2020 21:16:58 +0200 [thread overview]
Message-ID: <20200524191658.29742-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20200512082451.771212-1-noltari@gmail.com>
On Tue, 2020-05-12 at 08:24:51 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote:
> The current code checks that the whole OOB area is erased.
> This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will
> fail due to the usable OOB bytes not being 0xff.
> Correct this by only checking that data and ECC bytes aren't 0xff.
>
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
computersforpeace@gmail.com, kdasu.kdev@gmail.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sumit.semwal@linaro.org, linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4] mtd: rawnand: brcmnand: correctly verify erased pages
Date: Sun, 24 May 2020 21:16:58 +0200 [thread overview]
Message-ID: <20200524191658.29742-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20200512082451.771212-1-noltari@gmail.com>
On Tue, 2020-05-12 at 08:24:51 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote:
> The current code checks that the whole OOB area is erased.
> This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will
> fail due to the usable OOB bytes not being 0xff.
> Correct this by only checking that data and ECC bytes aren't 0xff.
>
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-24 19:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 9:29 [PATCH] nand: brcmnand: correctly verify erased pages Álvaro Fernández Rojas
2020-05-04 9:29 ` Álvaro Fernández Rojas
2020-05-04 9:29 ` Álvaro Fernández Rojas
2020-05-04 21:43 ` Florian Fainelli
2020-05-04 21:43 ` Florian Fainelli
2020-05-04 21:43 ` Florian Fainelli
2020-05-05 8:24 ` Álvaro Fernández Rojas
2020-05-05 8:20 ` [PATCH v2] " Álvaro Fernández Rojas
2020-05-05 8:20 ` Álvaro Fernández Rojas
2020-05-05 8:20 ` Álvaro Fernández Rojas
2020-05-11 16:43 ` Miquel Raynal
2020-05-11 16:43 ` Miquel Raynal
2020-05-12 6:51 ` [PATCH v3] mtd: rawnand: " Álvaro Fernández Rojas
2020-05-12 6:51 ` Álvaro Fernández Rojas
2020-05-12 6:51 ` Álvaro Fernández Rojas
2020-05-12 7:16 ` Miquel Raynal
2020-05-12 7:16 ` Miquel Raynal
2020-05-12 7:16 ` Miquel Raynal
2020-05-12 7:24 ` Álvaro Fernández Rojas
2020-05-12 7:24 ` Álvaro Fernández Rojas
2020-05-12 7:24 ` Álvaro Fernández Rojas
2020-05-12 7:34 ` Miquel Raynal
2020-05-12 7:34 ` Miquel Raynal
2020-05-12 7:34 ` Miquel Raynal
2020-05-12 8:24 ` Álvaro Fernández Rojas
2020-05-12 8:24 ` Álvaro Fernández Rojas
2020-05-12 8:24 ` Álvaro Fernández Rojas
2020-05-12 8:24 ` [PATCH v4] " Álvaro Fernández Rojas
2020-05-12 8:24 ` Álvaro Fernández Rojas
2020-05-12 8:24 ` Álvaro Fernández Rojas
2020-05-24 19:16 ` Miquel Raynal [this message]
2020-05-24 19:16 ` Miquel Raynal
2020-05-24 19:16 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524191658.29742-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kdasu.kdev@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=noltari@gmail.com \
--cc=richard@nod.at \
--cc=sumit.semwal@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.