All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: arm@kernel.org, Rob Herring <robh@kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Lokesh Vutla <lokeshvutla@ti.com>, Keerthy <j-keerthy@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
	Olof Johansson <olof@lixom.net>,
	linux-omap@vger.kernel.org,
	afzal mohammed <afzal.mohd.ma@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack
Date: Thu, 28 May 2020 06:50:57 -0700	[thread overview]
Message-ID: <20200528135057.GO37466@atomide.com> (raw)
In-Reply-To: <20200528134621.GN37466@atomide.com>

* Tony Lindgren <tony@atomide.com> [200528 13:47]:
> * Arnd Bergmann <arnd@arndb.de> [200528 09:20]:
> > The OMAP4 timer code had a special hack for using the broadcast timer
> > without SMP. Since the dmtimer is now gone, this also needs to be dropped
> > to avoid a link failure for non-SMP AM43xx configurations:
> > 
> > kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast':
> > tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast'
> 
> Hmm this sounds like a regression though. Isn't this needed for using
> the ARM local timers on non-SMP SoC, so a separate timer from dmtimer?
> 
> I've probably removed something accidentally to cause this.

Sounds like arch/arm/mach-omap2/Makefile change needs to be removed
to always still build in timer.o. And probably timer.c needs back
the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER.

I'll take a look today.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh@kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Lokesh Vutla <lokeshvutla@ti.com>, Keerthy <j-keerthy@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
	arm@kernel.org, Olof Johansson <olof@lixom.net>,
	linux-omap@vger.kernel.org,
	afzal mohammed <afzal.mohd.ma@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack
Date: Thu, 28 May 2020 06:50:57 -0700	[thread overview]
Message-ID: <20200528135057.GO37466@atomide.com> (raw)
In-Reply-To: <20200528134621.GN37466@atomide.com>

* Tony Lindgren <tony@atomide.com> [200528 13:47]:
> * Arnd Bergmann <arnd@arndb.de> [200528 09:20]:
> > The OMAP4 timer code had a special hack for using the broadcast timer
> > without SMP. Since the dmtimer is now gone, this also needs to be dropped
> > to avoid a link failure for non-SMP AM43xx configurations:
> > 
> > kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast':
> > tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast'
> 
> Hmm this sounds like a regression though. Isn't this needed for using
> the ARM local timers on non-SMP SoC, so a separate timer from dmtimer?
> 
> I've probably removed something accidentally to cause this.

Sounds like arch/arm/mach-omap2/Makefile change needs to be removed
to always still build in timer.o. And probably timer.c needs back
the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER.

I'll take a look today.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-28 13:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  9:19 [PATCH] ARM: omap2: drop broken broadcast timer hack Arnd Bergmann
2020-05-28  9:19 ` Arnd Bergmann
2020-05-28 13:46 ` Tony Lindgren
2020-05-28 13:46   ` Tony Lindgren
2020-05-28 13:50   ` Tony Lindgren [this message]
2020-05-28 13:50     ` Tony Lindgren
2020-05-28 15:57     ` Tony Lindgren
2020-05-28 15:57       ` Tony Lindgren
2020-05-28 16:18       ` santosh.shilimkar
2020-05-28 16:18         ` santosh.shilimkar
2020-05-28 20:33         ` Arnd Bergmann
2020-05-28 20:33           ` Arnd Bergmann
2020-05-28 20:38           ` Tony Lindgren
2020-05-28 20:38             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528135057.GO37466@atomide.com \
    --to=tony@atomide.com \
    --cc=afzal.mohd.ma@gmail.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=geert+renesas@glider.be \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=olof@lixom.net \
    --cc=robh@kernel.org \
    --cc=santosh.shilimkar@oracle.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.