From: Mark Brown <broonie@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Fabien Parent <fparent@baylibre.com>,
Stephane Le Provost <stephane.leprovost@mediatek.com>,
Pedro Tsai <pedro.tsai@mediatek.com>,
Andrew Perepech <andrew.perepech@mediatek.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 1/2] regmap: provide helpers for simple bit operations
Date: Thu, 28 May 2020 15:44:56 +0100 [thread overview]
Message-ID: <20200528144456.GG3606@sirena.org.uk> (raw)
In-Reply-To: <20200528142241.20466-2-brgl@bgdev.pl>
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
On Thu, May 28, 2020 at 04:22:40PM +0200, Bartosz Golaszewski wrote:
> + return (val & bits) == bits ? 1 : 0;
The tenery here is redundant, it's converting a boolean value into a
boolean value. Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Stephane Le Provost <stephane.leprovost@mediatek.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
linux-kernel@vger.kernel.org, Mark Lee <Mark-MC.Lee@mediatek.com>,
Fabien Parent <fparent@baylibre.com>,
Pedro Tsai <pedro.tsai@mediatek.com>,
linux-mediatek@lists.infradead.org,
Andrew Perepech <andrew.perepech@mediatek.com>,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] regmap: provide helpers for simple bit operations
Date: Thu, 28 May 2020 15:44:56 +0100 [thread overview]
Message-ID: <20200528144456.GG3606@sirena.org.uk> (raw)
In-Reply-To: <20200528142241.20466-2-brgl@bgdev.pl>
[-- Attachment #1.1: Type: text/plain, Size: 224 bytes --]
On Thu, May 28, 2020 at 04:22:40PM +0200, Bartosz Golaszewski wrote:
> + return (val & bits) == bits ? 1 : 0;
The tenery here is redundant, it's converting a boolean value into a
boolean value. Otherwise this looks good.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Stephane Le Provost <stephane.leprovost@mediatek.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
linux-kernel@vger.kernel.org, Mark Lee <Mark-MC.Lee@mediatek.com>,
Fabien Parent <fparent@baylibre.com>,
Pedro Tsai <pedro.tsai@mediatek.com>,
linux-mediatek@lists.infradead.org,
Andrew Perepech <andrew.perepech@mediatek.com>,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] regmap: provide helpers for simple bit operations
Date: Thu, 28 May 2020 15:44:56 +0100 [thread overview]
Message-ID: <20200528144456.GG3606@sirena.org.uk> (raw)
In-Reply-To: <20200528142241.20466-2-brgl@bgdev.pl>
[-- Attachment #1.1: Type: text/plain, Size: 224 bytes --]
On Thu, May 28, 2020 at 04:22:40PM +0200, Bartosz Golaszewski wrote:
> + return (val & bits) == bits ? 1 : 0;
The tenery here is redundant, it's converting a boolean value into a
boolean value. Otherwise this looks good.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-28 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:22 [PATCH v2 0/2] regmap: provide simple bitops and use them in a driver Bartosz Golaszewski
2020-05-28 14:22 ` Bartosz Golaszewski
2020-05-28 14:22 ` Bartosz Golaszewski
2020-05-28 14:22 ` [PATCH v2 1/2] regmap: provide helpers for simple bit operations Bartosz Golaszewski
2020-05-28 14:22 ` Bartosz Golaszewski
2020-05-28 14:22 ` Bartosz Golaszewski
2020-05-28 14:44 ` Mark Brown [this message]
2020-05-28 14:44 ` Mark Brown
2020-05-28 14:44 ` Mark Brown
2020-05-28 14:49 ` Bartosz Golaszewski
2020-05-28 14:49 ` Bartosz Golaszewski
2020-05-28 14:49 ` Bartosz Golaszewski
2020-05-28 15:05 ` Mark Brown
2020-05-28 15:05 ` Mark Brown
2020-05-28 15:05 ` Mark Brown
2020-05-28 14:22 ` [PATCH v2 2/2] net: ethernet: mtk-star-emac: use regmap bitops Bartosz Golaszewski
2020-05-28 14:22 ` Bartosz Golaszewski
2020-05-28 14:22 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528144456.GG3606@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew.perepech@mediatek.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=fparent@baylibre.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pedro.tsai@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=stephane.leprovost@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.