All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-fbdev@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org, linux-geode@lists.infradead.org,
	dri-devel@lists.freedesktop.org, Adrian Bunk <bunk@stusta.de>,
	Andres Salomon <dilinger@queued.net>,
	David Vrabel <dvrabel@arcom.com>
Subject: Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() for gx1fb_map_video_memory()
Date: Thu, 4 Jun 2020 11:22:34 +0300	[thread overview]
Message-ID: <20200604112234.7d840c15@eldfell.localdomain> (raw)
In-Reply-To: <20200603092547.1424428-1-hslester96@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Wed,  3 Jun 2020 17:25:47 +0800
Chuhong Yuan <hslester96@gmail.com> wrote:

> Although gx1fb_probe() has handled the failure of gx1fb_map_video_memory()
> partly, it does not call pci_disable_device() as gx1fb_map_video_memory()
> calls pci_enable_device().
> Add the missed function call to fix the bug.
> 
> Fixes: 53eed4ec8bcd ("[PATCH] fbdev: geode updates]")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/video/fbdev/geode/gx1fb_core.c | 37 ++++++++++++++++++--------
>  1 file changed, 26 insertions(+), 11 deletions(-)

Hi,

there is a typo in the patch subject, the driver seems to be called
geode, not geocode.


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-fbdev@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-geode@lists.infradead.org,
	Andres Salomon <dilinger@queued.net>,
	David Vrabel <dvrabel@arcom.com>, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() for gx1fb_map_video_memory()
Date: Thu, 04 Jun 2020 08:22:34 +0000	[thread overview]
Message-ID: <20200604112234.7d840c15@eldfell.localdomain> (raw)
In-Reply-To: <20200603092547.1424428-1-hslester96@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Wed,  3 Jun 2020 17:25:47 +0800
Chuhong Yuan <hslester96@gmail.com> wrote:

> Although gx1fb_probe() has handled the failure of gx1fb_map_video_memory()
> partly, it does not call pci_disable_device() as gx1fb_map_video_memory()
> calls pci_enable_device().
> Add the missed function call to fix the bug.
> 
> Fixes: 53eed4ec8bcd ("[PATCH] fbdev: geode updates]")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/video/fbdev/geode/gx1fb_core.c | 37 ++++++++++++++++++--------
>  1 file changed, 26 insertions(+), 11 deletions(-)

Hi,

there is a typo in the patch subject, the driver seems to be called
geode, not geocode.


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-fbdev@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-geode@lists.infradead.org,
	Andres Salomon <dilinger@queued.net>,
	David Vrabel <dvrabel@arcom.com>, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() for gx1fb_map_video_memory()
Date: Thu, 4 Jun 2020 11:22:34 +0300	[thread overview]
Message-ID: <20200604112234.7d840c15@eldfell.localdomain> (raw)
In-Reply-To: <20200603092547.1424428-1-hslester96@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 682 bytes --]

On Wed,  3 Jun 2020 17:25:47 +0800
Chuhong Yuan <hslester96@gmail.com> wrote:

> Although gx1fb_probe() has handled the failure of gx1fb_map_video_memory()
> partly, it does not call pci_disable_device() as gx1fb_map_video_memory()
> calls pci_enable_device().
> Add the missed function call to fix the bug.
> 
> Fixes: 53eed4ec8bcd ("[PATCH] fbdev: geode updates]")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/video/fbdev/geode/gx1fb_core.c | 37 ++++++++++++++++++--------
>  1 file changed, 26 insertions(+), 11 deletions(-)

Hi,

there is a typo in the patch subject, the driver seems to be called
geode, not geocode.


Thanks,
pq

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-04  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  9:25 [PATCH] fbdev: geocode: Add the missed pci_disable_device() for gx1fb_map_video_memory() Chuhong Yuan
2020-06-03  9:25 ` Chuhong Yuan
2020-06-03  9:25 ` Chuhong Yuan
2020-06-04  8:22 ` Pekka Paalanen [this message]
2020-06-04  8:22   ` Pekka Paalanen
2020-06-04  8:22   ` Pekka Paalanen
2020-06-03 16:48 [PATCH] fbdev: geocode: Add the missed pci_disable_device() in gx1fb_map_video_memory() Markus Elfring
2020-06-03 16:48 ` Markus Elfring
2020-06-03 16:48 ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604112234.7d840c15@eldfell.localdomain \
    --to=ppaalanen@gmail.com \
    --cc=akpm@osdl.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=bunk@stusta.de \
    --cc=dilinger@queued.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvrabel@arcom.com \
    --cc=hslester96@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.