All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	ludovic.desroches@microchip.com, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, linux@armlinux.org.uk,
	kamel.bouhara@bootlin.com
Subject: Re: [RFC PATCH 0/4] i2c: core: add generic GPIO bus recovery
Date: Sun, 5 Jul 2020 23:09:42 +0200	[thread overview]
Message-ID: <20200705210942.GA1055@kunai> (raw)
In-Reply-To: <20200619141904.910889-1-codrin.ciubotariu@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

On Fri, Jun 19, 2020 at 05:19:00PM +0300, Codrin Ciubotariu wrote:
> GPIO recovery has been added already for some I2C bus drivers, such as
> imx, pxa and at91. These drivers use similar bindings and have more or
> less the same code for recovery. For this reason, we aim to move the
> GPIO bus recovery implementation to the I2C core so that other drivers
> can benefit from it, with small modifications.
> This implementation initializes the pinctrl states and the SDA/SCL
> GPIOs based on common bindings. The I2C bus drivers can still use
> different bindings or other particular recovery steps if needed.
> The ugly part with this patch series is the handle of PROBE_DEFER
> which could be returned by devm_gpiod_get(). This changes things a
> little for i2c_register_adapter() and for this reason this step is
> implemented in a sperate patch.
> The at91 Microchip driver is the first to use this implementation,
> with an AI to move the rest of the drivers in the following steps.

Thanks for doing this! On a first high level review, this looks very
good. I have one question in patch 1. From Tuesday on, I'll be
off-the-net for two weeks. Still I think it will be all good for the 5.9
merge window unless we encounter an unexpected problem. But as said, so
far it is looking good!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
	kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org,
	ludovic.desroches@microchip.com, robh+dt@kernel.org,
	linux-i2c@vger.kernel.org, linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 0/4] i2c: core: add generic GPIO bus recovery
Date: Sun, 5 Jul 2020 23:09:42 +0200	[thread overview]
Message-ID: <20200705210942.GA1055@kunai> (raw)
In-Reply-To: <20200619141904.910889-1-codrin.ciubotariu@microchip.com>


[-- Attachment #1.1: Type: text/plain, Size: 1291 bytes --]

On Fri, Jun 19, 2020 at 05:19:00PM +0300, Codrin Ciubotariu wrote:
> GPIO recovery has been added already for some I2C bus drivers, such as
> imx, pxa and at91. These drivers use similar bindings and have more or
> less the same code for recovery. For this reason, we aim to move the
> GPIO bus recovery implementation to the I2C core so that other drivers
> can benefit from it, with small modifications.
> This implementation initializes the pinctrl states and the SDA/SCL
> GPIOs based on common bindings. The I2C bus drivers can still use
> different bindings or other particular recovery steps if needed.
> The ugly part with this patch series is the handle of PROBE_DEFER
> which could be returned by devm_gpiod_get(). This changes things a
> little for i2c_register_adapter() and for this reason this step is
> implemented in a sperate patch.
> The at91 Microchip driver is the first to use this implementation,
> with an AI to move the rest of the drivers in the following steps.

Thanks for doing this! On a first high level review, this looks very
good. I have one question in patch 1. From Tuesday on, I'll be
off-the-net for two weeks. Still I think it will be all good for the 5.9
merge window unless we encounter an unexpected problem. But as said, so
far it is looking good!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-05 21:10 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 14:19 [RFC PATCH 0/4] i2c: core: add generic GPIO bus recovery Codrin Ciubotariu
2020-06-19 14:19 ` Codrin Ciubotariu
2020-06-19 14:19 ` [RFC PATCH 1/4] dt-binding: i2c: add generic properties for " Codrin Ciubotariu
2020-06-19 14:19   ` Codrin Ciubotariu
2020-07-05 21:19   ` Wolfram Sang
2020-07-05 21:19     ` Wolfram Sang
2020-07-24 19:39     ` Wolfram Sang
2020-07-24 19:39       ` Wolfram Sang
2020-07-24 20:52       ` Russell King - ARM Linux admin
2020-07-24 20:52         ` Russell King - ARM Linux admin
2020-07-27 10:44         ` Codrin.Ciubotariu
2020-07-27 10:44           ` Codrin.Ciubotariu
2020-07-27 10:50           ` Russell King - ARM Linux admin
2020-07-27 10:50             ` Russell King - ARM Linux admin
2020-07-30  9:00             ` Codrin.Ciubotariu
2020-07-30  9:00               ` Codrin.Ciubotariu
2020-08-03 14:16               ` Russell King - ARM Linux admin
2020-08-03 14:16                 ` Russell King - ARM Linux admin
2020-08-03 16:42                 ` Codrin.Ciubotariu
2020-08-03 16:42                   ` Codrin.Ciubotariu
2020-07-15 19:21   ` Rob Herring
2020-07-15 19:21     ` Rob Herring
2020-06-19 14:19 ` [RFC PATCH 2/4] i2c: core: add generic I2C GPIO recovery Codrin Ciubotariu
2020-06-19 14:19   ` Codrin Ciubotariu
2020-08-02 16:54   ` Wolfram Sang
2020-08-02 16:54     ` Wolfram Sang
2020-08-03 13:27     ` Codrin.Ciubotariu
2020-08-03 13:27       ` Codrin.Ciubotariu
2020-08-03 16:49       ` wsa
2020-08-03 16:49         ` wsa
2020-06-19 14:19 ` [RFC PATCH 3/4] i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs Codrin Ciubotariu
2020-06-19 14:19   ` Codrin Ciubotariu
2020-08-02 17:05   ` Wolfram Sang
2020-08-02 17:05     ` Wolfram Sang
2020-08-03 15:33     ` Codrin.Ciubotariu
2020-08-03 15:33       ` Codrin.Ciubotariu
2020-08-03 16:59       ` wsa
2020-08-03 16:59         ` wsa
2020-06-19 14:19 ` [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery Codrin Ciubotariu
2020-06-19 14:19   ` Codrin Ciubotariu
2020-08-02 17:08   ` Wolfram Sang
2020-08-02 17:08     ` Wolfram Sang
2020-08-03 15:42     ` Codrin.Ciubotariu
2020-08-03 15:42       ` Codrin.Ciubotariu
2020-08-03 16:59       ` wsa
2020-08-03 16:59         ` wsa
2020-08-26  6:14       ` Wolfram Sang
2020-08-26  6:14         ` Wolfram Sang
2020-09-04  8:55         ` Codrin.Ciubotariu
2020-09-04  8:55           ` Codrin.Ciubotariu
2020-09-04  9:20           ` Wolfram Sang
2020-09-04  9:20             ` Wolfram Sang
2020-07-05 21:09 ` Wolfram Sang [this message]
2020-07-05 21:09   ` [RFC PATCH 0/4] i2c: core: add " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705210942.GA1055@kunai \
    --to=wsa@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kamel.bouhara@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.