[PATCH] documentation/poky.ent: Add screen

[PATCH] documentation/poky.ent: Add screen

[Leon Anavi]

Add screen to the list of packages for Ubuntu. Without screen or
an alternative terminal, executing -c devshell fails due to the
following error:

ERROR: do_devshell: No valid terminal found, unable to open devshell.

Tested on a fresh installation of Ubuntu 18.04.4 LTS.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
---
 documentation/poky.ent | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/documentation/poky.ent b/documentation/poky.ent
index aec8d455e..5e3563937 100755
--- a/documentation/poky.ent
+++ b/documentation/poky.ent
@@ -62,7 +62,7 @@
 <!ENTITY UBUNTU_HOST_PACKAGES_ESSENTIAL "gawk wget git-core diffstat unzip texinfo gcc-multilib \
      build-essential chrpath socat cpio python3 python3-pip python3-pexpect \
      xz-utils debianutils iputils-ping python3-git python3-jinja2 libegl1-mesa libsdl1.2-dev \
-     pylint3 xterm python3-subunit mesa-common-dev">
+     pylint3 xterm python3-subunit mesa-common-dev screen">
 <!ENTITY FEDORA_HOST_PACKAGES_ESSENTIAL "gawk make wget tar bzip2 gzip python3 unzip perl patch \
      diffutils diffstat git cpp gcc gcc-c++ glibc-devel texinfo chrpath \
      ccache perl-Data-Dumper perl-Text-ParseWords perl-Thread-Queue perl-bignum socat \
-- 
2.17.1

Re: [docs] [PATCH] documentation/poky.ent: Add screen

[Peter Kjellerstedt]

> -----Original Message-----
> From: docs@lists.yoctoproject.org <docs@lists.yoctoproject.org> On Behalf
> Of Leon Anavi
> Sent: den 7 juli 2020 11:37
> To: docs@lists.yoctoproject.org
> Cc: Leon Anavi <leon.anavi@konsulko.com>
> Subject: [docs] [PATCH] documentation/poky.ent: Add screen
> 
> Add screen to the list of packages for Ubuntu. Without screen or
> an alternative terminal, executing -c devshell fails due to the
> following error:
> 
> ERROR: do_devshell: No valid terminal found, unable to open devshell.
> 
> Tested on a fresh installation of Ubuntu 18.04.4 LTS.
> 
> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> ---
>  documentation/poky.ent | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/documentation/poky.ent b/documentation/poky.ent
> index aec8d455e..5e3563937 100755
> --- a/documentation/poky.ent
> +++ b/documentation/poky.ent
> @@ -62,7 +62,7 @@
>  <!ENTITY UBUNTU_HOST_PACKAGES_ESSENTIAL "gawk wget git-core diffstat unzip texinfo gcc-multilib \
>       build-essential chrpath socat cpio python3 python3-pip python3-pexpect \
>       xz-utils debianutils iputils-ping python3-git python3-jinja2 libegl1-mesa libsdl1.2-dev \
> -     pylint3 xterm python3-subunit mesa-common-dev">
> +     pylint3 xterm python3-subunit mesa-common-dev screen">
                ^^^^^
Doesn't "xterm" fulfill the requirement for a valid terminal?
It is already specified for all the distros, not only Ubuntu.

>  <!ENTITY FEDORA_HOST_PACKAGES_ESSENTIAL "gawk make wget tar bzip2 gzip python3 unzip perl patch \
>       diffutils diffstat git cpp gcc gcc-c++ glibc-devel texinfo chrpath \
>       ccache perl-Data-Dumper perl-Text-ParseWords perl-Thread-Queue perl-bignum socat \
> --
> 2.17.1

//Peter

Re: [docs] [PATCH] documentation/poky.ent: Add screen

[Leon Anavi]

Hi Peter,

On 8.07.20 г. 1:15 ч., Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: docs@lists.yoctoproject.org <docs@lists.yoctoproject.org> On Behalf
>> Of Leon Anavi
>> Sent: den 7 juli 2020 11:37
>> To: docs@lists.yoctoproject.org
>> Cc: Leon Anavi <leon.anavi@konsulko.com>
>> Subject: [docs] [PATCH] documentation/poky.ent: Add screen
>>
>> Add screen to the list of packages for Ubuntu. Without screen or
>> an alternative terminal, executing -c devshell fails due to the
>> following error:
>>
>> ERROR: do_devshell: No valid terminal found, unable to open devshell.
>>
>> Tested on a fresh installation of Ubuntu 18.04.4 LTS.
>>
>> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
>> ---
>>   documentation/poky.ent | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/documentation/poky.ent b/documentation/poky.ent
>> index aec8d455e..5e3563937 100755
>> --- a/documentation/poky.ent
>> +++ b/documentation/poky.ent
>> @@ -62,7 +62,7 @@
>>   <!ENTITY UBUNTU_HOST_PACKAGES_ESSENTIAL "gawk wget git-core diffstat unzip texinfo gcc-multilib \
>>        build-essential chrpath socat cpio python3 python3-pip python3-pexpect \
>>        xz-utils debianutils iputils-ping python3-git python3-jinja2 libegl1-mesa libsdl1.2-dev \
>> -     pylint3 xterm python3-subunit mesa-common-dev">
>> +     pylint3 xterm python3-subunit mesa-common-dev screen">
>                  ^^^^^
> Doesn't "xterm" fulfill the requirement for a valid terminal?

No, because in my case I am logging remotely to the build machine via 
SSH. Here are more details (without installed screen):

* I have xterm installed:

$ dpkg -l | grep xterm
ii  xterm 330-1ubuntu2                                     amd64        
X terminal emulator

* I am using release Dunfell:

$ git branch
* dunfell

* devshell fails:

$ bitbake u-boot -c devshell

ERROR: u-boot-1_2020.01-r0 do_devshell: No valid terminal found, unable 
to open devshell.
Tried the following commands:
     tmux split-window -c "{cwd}" "do_terminal"
     tmux new-window -c "{cwd}" -n "OpenEmbedded Developer Shell" 
"do_terminal"
     xfce4-terminal -T "OpenEmbedded Developer Shell" -e "do_terminal"
     terminology -T="OpenEmbedded Developer Shell" -e do_terminal
     mate-terminal --disable-factory -t "OpenEmbedded Developer Shell" 
-x do_terminal
     konsole --separate --workdir . -p tabtitle="OpenEmbedded Developer 
Shell" -e do_terminal
     gnome-terminal -t "OpenEmbedded Developer Shell" -- do_terminal
     xterm -T "OpenEmbedded Developer Shell" -e do_terminal
     rxvt -T "OpenEmbedded Developer Shell" -e do_terminal
     tmux new -c "{cwd}" -d -s devshell -n devshell "do_terminal"
     screen -D -m -t "OpenEmbedded Developer Shell" -S devshell do_terminal

I believe often developer login via SSH to build machines therefore it 
will be useful to have screen in the list of packages.

Best regards,
Leon

> It is already specified for all the distros, not only Ubuntu.
>
>>   <!ENTITY FEDORA_HOST_PACKAGES_ESSENTIAL "gawk make wget tar bzip2 gzip python3 unzip perl patch \
>>        diffutils diffstat git cpp gcc gcc-c++ glibc-devel texinfo chrpath \
>>        ccache perl-Data-Dumper perl-Text-ParseWords perl-Thread-Queue perl-bignum socat \
>> --
>> 2.17.1
> //Peter
>
-- 
Leon Anavi
Software Engineer
konsulko.com

Re: [docs] [PATCH] documentation/poky.ent: Add screen

[Peter Kjellerstedt]

> -----Original Message-----
> From: Leon Anavi <leon.anavi@konsulko.com>
> Sent: den 8 juli 2020 00:35
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>;
> docs@lists.yoctoproject.org
> Subject: Re: [docs] [PATCH] documentation/poky.ent: Add screen
> 
> Hi Peter,
> 
> On 8.07.20 г. 1:15 ч., Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: docs@lists.yoctoproject.org <docs@lists.yoctoproject.org> On
> Behalf
> >> Of Leon Anavi
> >> Sent: den 7 juli 2020 11:37
> >> To: docs@lists.yoctoproject.org
> >> Cc: Leon Anavi <leon.anavi@konsulko.com>
> >> Subject: [docs] [PATCH] documentation/poky.ent: Add screen
> >>
> >> Add screen to the list of packages for Ubuntu. Without screen or
> >> an alternative terminal, executing -c devshell fails due to the
> >> following error:
> >>
> >> ERROR: do_devshell: No valid terminal found, unable to open devshell.
> >>
> >> Tested on a fresh installation of Ubuntu 18.04.4 LTS.
> >>
> >> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> >> ---
> >>   documentation/poky.ent | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/documentation/poky.ent b/documentation/poky.ent
> >> index aec8d455e..5e3563937 100755
> >> --- a/documentation/poky.ent
> >> +++ b/documentation/poky.ent
> >> @@ -62,7 +62,7 @@
> >>   <!ENTITY UBUNTU_HOST_PACKAGES_ESSENTIAL "gawk wget git-core diffstat
> unzip texinfo gcc-multilib \
> >>        build-essential chrpath socat cpio python3 python3-pip python3-
> pexpect \
> >>        xz-utils debianutils iputils-ping python3-git python3-jinja2
> libegl1-mesa libsdl1.2-dev \
> >> -     pylint3 xterm python3-subunit mesa-common-dev">
> >> +     pylint3 xterm python3-subunit mesa-common-dev screen">
> >                  ^^^^^
> > Doesn't "xterm" fulfill the requirement for a valid terminal?
> 
> No, because in my case I am logging remotely to the build machine via
> SSH. Here are more details (without installed screen):
> 
> * I have xterm installed:
> 
> $ dpkg -l | grep xterm
> ii  xterm 330-1ubuntu2                                     amd64
> X terminal emulator
> 
> * I am using release Dunfell:
> 
> $ git branch
> * dunfell
> 
> * devshell fails:
> 
> $ bitbake u-boot -c devshell
> 
> ERROR: u-boot-1_2020.01-r0 do_devshell: No valid terminal found, unable
> to open devshell.
> Tried the following commands:
>      tmux split-window -c "{cwd}" "do_terminal"
>      tmux new-window -c "{cwd}" -n "OpenEmbedded Developer Shell" "do_terminal"
>      xfce4-terminal -T "OpenEmbedded Developer Shell" -e "do_terminal"
>      terminology -T="OpenEmbedded Developer Shell" -e do_terminal
>      mate-terminal --disable-factory -t "OpenEmbedded Developer Shell" -x do_terminal
>      konsole --separate --workdir . -p tabtitle="OpenEmbedded Developer Shell" -e do_terminal
>      gnome-terminal -t "OpenEmbedded Developer Shell" -- do_terminal
>      xterm -T "OpenEmbedded Developer Shell" -e do_terminal
>      rxvt -T "OpenEmbedded Developer Shell" -e do_terminal
>      tmux new -c "{cwd}" -d -s devshell -n devshell "do_terminal"
>      screen -D -m -t "OpenEmbedded Developer Shell" -S devshell do_terminal
> 
> I believe often developer login via SSH to build machines therefore it
> will be useful to have screen in the list of packages.

Well, you can argue that any or all of the above commands should be 
added to the list then. Which terminal one prefers is very much a 
personal choice (I for one hate both screen and tmux and never use 
them). The *_HOST_PACKAGES_ESSENTIAL variables are supposed to list 
only the essential packages needed to build and run a QEMU image 
with graphics support, and I will argue that screen does not fill 
that requirement. The error message above should be more than 
enough to help anyone select a suitable terminal to install if they 
want to use devshell.

> Best regards,
> Leon
> 
> > It is already specified for all the distros, not only Ubuntu.
> >
> >>   <!ENTITY FEDORA_HOST_PACKAGES_ESSENTIAL "gawk make wget tar bzip2
> gzip python3 unzip perl patch \
> >>        diffutils diffstat git cpp gcc gcc-c++ glibc-devel texinfo
> chrpath \
> >>        ccache perl-Data-Dumper perl-Text-ParseWords perl-Thread-Queue
> perl-bignum socat \
> >> --
> >> 2.17.1
> > //Peter
> >
> --
> Leon Anavi
> Software Engineer
> konsulko.com

//Peter