* [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102")
@ 2020-07-06 20:53 Jarkko Sakkinen
2020-07-06 21:47 ` Jerry Snitselaar
2020-07-07 9:41 ` Greg Kroah-Hartman
0 siblings, 2 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-07-06 20:53 UTC (permalink / raw)
To: linux-integrity
Cc: Jarkko Sakkinen, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, Jerry Snitselaar, open list
Removing IFX0102 from tpm_tis was not a right move because both tpm_tis
and tpm_infineon use the same device ID. Revert the commit and add a
remark about a bug caused by commit 93e1b7d42e1e ("[PATCH] tpm: add HID
module parameter").
Fixes: e918e570415c ("tpm_tis: Remove the HID IFX0102")
Reported-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
drivers/char/tpm/tpm_tis.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index c58ea10fc92f..0b214963539d 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -235,9 +235,17 @@ static int tpm_tis_pnp_init(struct pnp_dev *pnp_dev,
return tpm_tis_init(&pnp_dev->dev, &tpm_info);
}
+/*
+ * There is a known bug caused by 93e1b7d42e1e ("[PATCH] tpm: add HID module
+ * parameter"). This commit added IFX0102 device ID, which is also used by
+ * tpm_infineon but ignored to add quirks to probe which driver ought to be
+ * used.
+ */
+
static struct pnp_device_id tpm_pnp_tbl[] = {
{"PNP0C31", 0}, /* TPM */
{"ATM1200", 0}, /* Atmel */
+ {"IFX0102", 0}, /* Infineon */
{"BCM0101", 0}, /* Broadcom */
{"BCM0102", 0}, /* Broadcom */
{"NSC1200", 0}, /* National */
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102")
2020-07-06 20:53 [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102") Jarkko Sakkinen
@ 2020-07-06 21:47 ` Jerry Snitselaar
2020-07-07 2:22 ` Jarkko Sakkinen
2020-07-07 9:41 ` Greg Kroah-Hartman
1 sibling, 1 reply; 5+ messages in thread
From: Jerry Snitselaar @ 2020-07-06 21:47 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: linux-integrity, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, open list
Jarkko Sakkinen @ 2020-07-06 13:53 MST:
> Removing IFX0102 from tpm_tis was not a right move because both tpm_tis
> and tpm_infineon use the same device ID. Revert the commit and add a
> remark about a bug caused by commit 93e1b7d42e1e ("[PATCH] tpm: add HID
> module parameter").
>
> Fixes: e918e570415c ("tpm_tis: Remove the HID IFX0102")
> Reported-by: Peter Huewe <peterhuewe@gmx.de>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> ---
> drivers/char/tpm/tpm_tis.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index c58ea10fc92f..0b214963539d 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -235,9 +235,17 @@ static int tpm_tis_pnp_init(struct pnp_dev *pnp_dev,
> return tpm_tis_init(&pnp_dev->dev, &tpm_info);
> }
>
> +/*
> + * There is a known bug caused by 93e1b7d42e1e ("[PATCH] tpm: add HID module
> + * parameter"). This commit added IFX0102 device ID, which is also used by
> + * tpm_infineon but ignored to add quirks to probe which driver ought to be
> + * used.
> + */
> +
> static struct pnp_device_id tpm_pnp_tbl[] = {
> {"PNP0C31", 0}, /* TPM */
> {"ATM1200", 0}, /* Atmel */
> + {"IFX0102", 0}, /* Infineon */
> {"BCM0101", 0}, /* Broadcom */
> {"BCM0102", 0}, /* Broadcom */
> {"NSC1200", 0}, /* National */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102")
2020-07-06 21:47 ` Jerry Snitselaar
@ 2020-07-07 2:22 ` Jarkko Sakkinen
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-07-07 2:22 UTC (permalink / raw)
To: Jerry Snitselaar
Cc: linux-integrity, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, open list
On Mon, Jul 06, 2020 at 02:47:07PM -0700, Jerry Snitselaar wrote:
>
> Jarkko Sakkinen @ 2020-07-06 13:53 MST:
>
> > Removing IFX0102 from tpm_tis was not a right move because both tpm_tis
> > and tpm_infineon use the same device ID. Revert the commit and add a
> > remark about a bug caused by commit 93e1b7d42e1e ("[PATCH] tpm: add HID
> > module parameter").
> >
> > Fixes: e918e570415c ("tpm_tis: Remove the HID IFX0102")
> > Reported-by: Peter Huewe <peterhuewe@gmx.de>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Thanks.
PR sent https://lkml.org/lkml/2020/7/6/1127
/Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102")
2020-07-06 20:53 [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102") Jarkko Sakkinen
2020-07-06 21:47 ` Jerry Snitselaar
@ 2020-07-07 9:41 ` Greg Kroah-Hartman
2020-07-08 13:35 ` Jarkko Sakkinen
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-07 9:41 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: linux-integrity, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Jerry Snitselaar, open list
On Mon, Jul 06, 2020 at 11:53:42PM +0300, Jarkko Sakkinen wrote:
> Removing IFX0102 from tpm_tis was not a right move because both tpm_tis
> and tpm_infineon use the same device ID. Revert the commit and add a
> remark about a bug caused by commit 93e1b7d42e1e ("[PATCH] tpm: add HID
> module parameter").
>
> Fixes: e918e570415c ("tpm_tis: Remove the HID IFX0102")
> Reported-by: Peter Huewe <peterhuewe@gmx.de>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
As the original was asked to be applied to the stable trees, this one
should have as well.
I'll go drop it from the stable queues right now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102")
2020-07-07 9:41 ` Greg Kroah-Hartman
@ 2020-07-08 13:35 ` Jarkko Sakkinen
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-07-08 13:35 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-integrity, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Jerry Snitselaar, open list
On Tue, Jul 07, 2020 at 11:41:40AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 06, 2020 at 11:53:42PM +0300, Jarkko Sakkinen wrote:
> > Removing IFX0102 from tpm_tis was not a right move because both tpm_tis
> > and tpm_infineon use the same device ID. Revert the commit and add a
> > remark about a bug caused by commit 93e1b7d42e1e ("[PATCH] tpm: add HID
> > module parameter").
> >
> > Fixes: e918e570415c ("tpm_tis: Remove the HID IFX0102")
> > Reported-by: Peter Huewe <peterhuewe@gmx.de>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> As the original was asked to be applied to the stable trees, this one
> should have as well.
>
> I'll go drop it from the stable queues right now, thanks.
>
> greg k-h
Ah, apologies for my ignorance.
/Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-08 13:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 20:53 [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102") Jarkko Sakkinen
2020-07-06 21:47 ` Jerry Snitselaar
2020-07-07 2:22 ` Jarkko Sakkinen
2020-07-07 9:41 ` Greg Kroah-Hartman
2020-07-08 13:35 ` Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.