All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/6] gpio: max77620: Replace 8 with MAX77620_GPIO_NR
Date: Wed,  8 Jul 2020 23:23:50 +0300	[thread overview]
Message-ID: <20200708202355.28507-2-digetx@gmail.com> (raw)
In-Reply-To: <20200708202355.28507-1-digetx@gmail.com>

The MAX77620_GPIO_NR enum value represents the total number of GPIOs,
let's use it instead of a raw value in order to improve the code's
readability a tad.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/gpio/gpio-max77620.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index 313bd02dd893..4c0c9ec2587d 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -19,8 +19,8 @@ struct max77620_gpio {
 	struct regmap		*rmap;
 	struct device		*dev;
 	struct mutex		buslock; /* irq_bus_lock */
-	unsigned int		irq_type[8];
-	bool			irq_enabled[8];
+	unsigned int		irq_type[MAX77620_GPIO_NR];
+	bool			irq_enabled[MAX77620_GPIO_NR];
 };
 
 static irqreturn_t max77620_gpio_irqhandler(int irq, void *data)
@@ -38,7 +38,7 @@ static irqreturn_t max77620_gpio_irqhandler(int irq, void *data)
 
 	pending = value;
 
-	for_each_set_bit(offset, &pending, 8) {
+	for_each_set_bit(offset, &pending, MAX77620_GPIO_NR) {
 		unsigned int virq;
 
 		virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset);
-- 
2.26.0

  reply	other threads:[~2020-07-08 20:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 20:23 [PATCH v3 0/6] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 20:23 ` Dmitry Osipenko
2020-07-08 20:23 ` Dmitry Osipenko [this message]
2020-07-09 14:54   ` [PATCH v3 1/6] gpio: max77620: Replace 8 with MAX77620_GPIO_NR Laxman Dewangan
2020-07-09 14:54     ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 2/6] gpio: max77620: Fix missing release of interrupt Dmitry Osipenko
     [not found]   ` <20200708202355.28507-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 14:57     ` Laxman Dewangan
2020-07-09 14:57       ` Laxman Dewangan
     [not found]       ` <80f4d1ff-8096-9060-3cf0-a59448866c40-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-09 16:36         ` Dmitry Osipenko
2020-07-09 16:36           ` Dmitry Osipenko
     [not found] ` <20200708202355.28507-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-08 20:23   ` [PATCH v3 3/6] gpio: max77620: Don't set of_node Dmitry Osipenko
2020-07-08 20:23     ` Dmitry Osipenko
     [not found]     ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ@mail.gmail.com>
     [not found]       ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-08 21:44         ` Dmitry Osipenko
2020-07-08 21:44           ` Dmitry Osipenko
     [not found]           ` <675c4691-d372-4fe1-d515-c86fdba2f588-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09  9:07             ` Andy Shevchenko
2020-07-09  9:07               ` Andy Shevchenko
     [not found]               ` <CAHp75Vd89QpwaGvkpzG+pxnLd8S2guPCARLW5xPwhxXL8ZRfFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-09 10:38                 ` Dmitry Osipenko
2020-07-09 10:38                   ` Dmitry Osipenko
     [not found]     ` <20200708202355.28507-4-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 14:58       ` Laxman Dewangan
2020-07-09 14:58         ` Laxman Dewangan
2020-07-08 20:23   ` [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts Dmitry Osipenko
2020-07-08 20:23     ` Dmitry Osipenko
2020-07-09 15:03     ` Laxman Dewangan
2020-07-09 15:03       ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 4/6] gpio: max77620: Don't shadow error code of platform_get_irq() Dmitry Osipenko
     [not found]   ` <20200708202355.28507-5-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 15:01     ` Laxman Dewangan
2020-07-09 15:01       ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 5/6] gpio: max77620: Use irqchip template Dmitry Osipenko
     [not found]   ` <20200708202355.28507-6-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 15:03     ` Laxman Dewangan
2020-07-09 15:03       ` Laxman Dewangan
     [not found] ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA@mail.gmail.com>
     [not found]   ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-08 21:49     ` [PATCH v1 0/5] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 21:49       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708202355.28507-2-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.