From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Bartosz Golaszewski <bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node Date: Thu, 9 Jul 2020 00:44:34 +0300 [thread overview] Message-ID: <675c4691-d372-4fe1-d515-c86fdba2f588@gmail.com> (raw) In-Reply-To: <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 08.07.2020 23:57, Andy Shevchenko пишет: > > > On Wednesday, July 8, 2020, Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org > <mailto:digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>> wrote: > > The gpiochip_add_data() takes care of setting the of_node to the > parent's > device of_node, hence there is no need to do it manually in the driver's > code. This patch corrects the parent's device pointer and removes the > unnecessary setting of the of_node. > > > I gave a second look and I think my suggestion is wrong. Here is an > interesting propagation of the parent device node to its grand son, > leaving son’s one untouched. Original code has intentions to do that way. The [1] says that gpio_chip.parent should point at the "device providing the GPIOs". That's the pdev->dev.parent in the case of this driver. MAX77620 is an MFD PMIC device that has virtual sub-devices like GPIO controller, PINCTRL and RTC. The MFD is the parent device that provides the GPIOs [2]. [1] https://elixir.bootlin.com/linux/v5.8-rc3/source/include/linux/gpio/driver.h#L276 [2] https://elixir.bootlin.com/linux/v5.8-rc3/source/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi#L48 I think the old code was wrong and this patch is correct, please correct me if I'm missing something. > Suggested-by: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org > <mailto:andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>> > Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org > <mailto:digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>> > --- > drivers/gpio/gpio-max77620.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c > index 7f7e8d4bf0d3..39d431da2dbc 100644 > --- a/drivers/gpio/gpio-max77620.c > +++ b/drivers/gpio/gpio-max77620.c > @@ -279,7 +279,7 @@ static int max77620_gpio_probe(struct > platform_device *pdev) > mgpio->dev = &pdev->dev; > > mgpio->gpio_chip.label = pdev->name; > - mgpio->gpio_chip.parent = &pdev->dev; > + mgpio->gpio_chip.parent = pdev->dev.parent; > mgpio->gpio_chip.direction_input = max77620_gpio_dir_input; > mgpio->gpio_chip.get = max77620_gpio_get; > mgpio->gpio_chip.direction_output = max77620_gpio_dir_output; > @@ -288,9 +288,6 @@ static int max77620_gpio_probe(struct > platform_device *pdev) > mgpio->gpio_chip.ngpio = MAX77620_GPIO_NR; > mgpio->gpio_chip.can_sleep = 1; > mgpio->gpio_chip.base = -1; > -#ifdef CONFIG_OF_GPIO > - mgpio->gpio_chip.of_node = pdev->dev.parent->of_node; > -#endif > > platform_set_drvdata(pdev, mgpio); > > -- > 2.26.0 > > > > -- > With Best Regards, > Andy Shevchenko > >
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Laxman Dewangan <ldewangan@nvidia.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Linus Walleij <linus.walleij@linaro.org>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node Date: Thu, 9 Jul 2020 00:44:34 +0300 [thread overview] Message-ID: <675c4691-d372-4fe1-d515-c86fdba2f588@gmail.com> (raw) In-Reply-To: <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ@mail.gmail.com> 08.07.2020 23:57, Andy Shevchenko пишет: > > > On Wednesday, July 8, 2020, Dmitry Osipenko <digetx@gmail.com > <mailto:digetx@gmail.com>> wrote: > > The gpiochip_add_data() takes care of setting the of_node to the > parent's > device of_node, hence there is no need to do it manually in the driver's > code. This patch corrects the parent's device pointer and removes the > unnecessary setting of the of_node. > > > I gave a second look and I think my suggestion is wrong. Here is an > interesting propagation of the parent device node to its grand son, > leaving son’s one untouched. Original code has intentions to do that way. The [1] says that gpio_chip.parent should point at the "device providing the GPIOs". That's the pdev->dev.parent in the case of this driver. MAX77620 is an MFD PMIC device that has virtual sub-devices like GPIO controller, PINCTRL and RTC. The MFD is the parent device that provides the GPIOs [2]. [1] https://elixir.bootlin.com/linux/v5.8-rc3/source/include/linux/gpio/driver.h#L276 [2] https://elixir.bootlin.com/linux/v5.8-rc3/source/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi#L48 I think the old code was wrong and this patch is correct, please correct me if I'm missing something. > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com > <mailto:andy.shevchenko@gmail.com>> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com > <mailto:digetx@gmail.com>> > --- > drivers/gpio/gpio-max77620.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c > index 7f7e8d4bf0d3..39d431da2dbc 100644 > --- a/drivers/gpio/gpio-max77620.c > +++ b/drivers/gpio/gpio-max77620.c > @@ -279,7 +279,7 @@ static int max77620_gpio_probe(struct > platform_device *pdev) > mgpio->dev = &pdev->dev; > > mgpio->gpio_chip.label = pdev->name; > - mgpio->gpio_chip.parent = &pdev->dev; > + mgpio->gpio_chip.parent = pdev->dev.parent; > mgpio->gpio_chip.direction_input = max77620_gpio_dir_input; > mgpio->gpio_chip.get = max77620_gpio_get; > mgpio->gpio_chip.direction_output = max77620_gpio_dir_output; > @@ -288,9 +288,6 @@ static int max77620_gpio_probe(struct > platform_device *pdev) > mgpio->gpio_chip.ngpio = MAX77620_GPIO_NR; > mgpio->gpio_chip.can_sleep = 1; > mgpio->gpio_chip.base = -1; > -#ifdef CONFIG_OF_GPIO > - mgpio->gpio_chip.of_node = pdev->dev.parent->of_node; > -#endif > > platform_set_drvdata(pdev, mgpio); > > -- > 2.26.0 > > > > -- > With Best Regards, > Andy Shevchenko > >
next prev parent reply other threads:[~2020-07-08 21:44 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-08 20:23 [PATCH v3 0/6] Improvements for MAX77620 GPIO driver Dmitry Osipenko 2020-07-08 20:23 ` Dmitry Osipenko 2020-07-08 20:23 ` [PATCH v3 1/6] gpio: max77620: Replace 8 with MAX77620_GPIO_NR Dmitry Osipenko 2020-07-09 14:54 ` Laxman Dewangan 2020-07-09 14:54 ` Laxman Dewangan 2020-07-08 20:23 ` [PATCH v3 2/6] gpio: max77620: Fix missing release of interrupt Dmitry Osipenko [not found] ` <20200708202355.28507-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-09 14:57 ` Laxman Dewangan 2020-07-09 14:57 ` Laxman Dewangan [not found] ` <80f4d1ff-8096-9060-3cf0-a59448866c40-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-09 16:36 ` Dmitry Osipenko 2020-07-09 16:36 ` Dmitry Osipenko [not found] ` <20200708202355.28507-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-08 20:23 ` [PATCH v3 3/6] gpio: max77620: Don't set of_node Dmitry Osipenko 2020-07-08 20:23 ` Dmitry Osipenko [not found] ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ@mail.gmail.com> [not found] ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2020-07-08 21:44 ` Dmitry Osipenko [this message] 2020-07-08 21:44 ` Dmitry Osipenko [not found] ` <675c4691-d372-4fe1-d515-c86fdba2f588-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-09 9:07 ` Andy Shevchenko 2020-07-09 9:07 ` Andy Shevchenko [not found] ` <CAHp75Vd89QpwaGvkpzG+pxnLd8S2guPCARLW5xPwhxXL8ZRfFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2020-07-09 10:38 ` Dmitry Osipenko 2020-07-09 10:38 ` Dmitry Osipenko [not found] ` <20200708202355.28507-4-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-09 14:58 ` Laxman Dewangan 2020-07-09 14:58 ` Laxman Dewangan 2020-07-08 20:23 ` [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts Dmitry Osipenko 2020-07-08 20:23 ` Dmitry Osipenko 2020-07-09 15:03 ` Laxman Dewangan 2020-07-09 15:03 ` Laxman Dewangan 2020-07-08 20:23 ` [PATCH v3 4/6] gpio: max77620: Don't shadow error code of platform_get_irq() Dmitry Osipenko [not found] ` <20200708202355.28507-5-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-09 15:01 ` Laxman Dewangan 2020-07-09 15:01 ` Laxman Dewangan 2020-07-08 20:23 ` [PATCH v3 5/6] gpio: max77620: Use irqchip template Dmitry Osipenko [not found] ` <20200708202355.28507-6-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-09 15:03 ` Laxman Dewangan 2020-07-09 15:03 ` Laxman Dewangan [not found] ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA@mail.gmail.com> [not found] ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2020-07-08 21:49 ` [PATCH v1 0/5] Improvements for MAX77620 GPIO driver Dmitry Osipenko 2020-07-08 21:49 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=675c4691-d372-4fe1-d515-c86fdba2f588@gmail.com \ --to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \ --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.