All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/selftest: Fix an error code in live_noa_gpr()
Date: Tue, 14 Jul 2020 18:08:52 +0000	[thread overview]
Message-ID: <20200714180852.GC2571@kadam> (raw)
In-Reply-To: <159474692212.3188.5286642208247298191@build.alporthouse.com>

On Tue, Jul 14, 2020 at 06:15:22PM +0100, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2020-07-14 15:39:21)
> > On 14/07/2020 17:36, Dan Carpenter wrote:
> > > The error code needs to be set on this path.  It currently returns
> > > success.
> > >
> > > Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
> > > Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > v2: Fix a different bug instead.  :P  Colin fixed mine already.
> 
> I was thinking that Colin already sent the patch for this one...

Colin sent a fix for my v1 bug.  commit d2921096e707 ("drm/i915/selftest:
fix an error return path where err is not being set") but I don't think
he fixed this one.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/selftest: Fix an error code in live_noa_gpr()
Date: Tue, 14 Jul 2020 21:08:52 +0300	[thread overview]
Message-ID: <20200714180852.GC2571@kadam> (raw)
In-Reply-To: <159474692212.3188.5286642208247298191@build.alporthouse.com>

On Tue, Jul 14, 2020 at 06:15:22PM +0100, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2020-07-14 15:39:21)
> > On 14/07/2020 17:36, Dan Carpenter wrote:
> > > The error code needs to be set on this path.  It currently returns
> > > success.
> > >
> > > Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
> > > Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > v2: Fix a different bug instead.  :P  Colin fixed mine already.
> 
> I was thinking that Colin already sent the patch for this one...

Colin sent a fix for my v1 bug.  commit d2921096e707 ("drm/i915/selftest:
fix an error return path where err is not being set") but I don't think
he fixed this one.

regards,
dan carpenter

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-07-14 18:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 14:12 [PATCH] drm/i915/selftest: Fix an error code in live_noa_gpr() Dan Carpenter
2020-07-14 14:12 ` [Intel-gfx] " Dan Carpenter
2020-07-14 14:16 ` Lionel Landwerlin
2020-07-14 14:16   ` [Intel-gfx] " Lionel Landwerlin
2020-07-14 14:31   ` Dan Carpenter
2020-07-14 14:31     ` [Intel-gfx] " Dan Carpenter
2020-07-14 14:36   ` [PATCH v2] " Dan Carpenter
2020-07-14 14:36     ` [Intel-gfx] " Dan Carpenter
2020-07-14 14:39     ` Lionel Landwerlin
2020-07-14 14:39       ` [Intel-gfx] " Lionel Landwerlin
2020-07-14 17:15       ` Chris Wilson
2020-07-14 17:15         ` Chris Wilson
2020-07-14 18:08         ` Dan Carpenter [this message]
2020-07-14 18:08           ` Dan Carpenter
2020-07-14 18:12           ` Colin Ian King
2020-07-14 18:12             ` Colin Ian King
2020-07-14 14:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-14 15:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Fix an error code in live_noa_gpr() (rev2) Patchwork
2020-07-14 17:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-02-15 15:58 ` [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier() Dan Carpenter
2021-02-15 15:58   ` [Intel-gfx] " Dan Carpenter
2021-02-15 16:35   ` Chris Wilson
2021-02-15 18:12   ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-15 20:32   ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714180852.GC2571@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.